From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Ojha Subject: Re: [PATCH] remoteproc: silence an uninitialized variable warning Date: Thu, 4 Apr 2019 14:47:39 +0530 Message-ID: References: <20190404084204.GA20193@kadam> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190404084204.GA20193@kadam> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Dan Carpenter , Andy Gross Cc: David Brown , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On 4/4/2019 2:12 PM, Dan Carpenter wrote: > Smatch complains that "ret" might be uninitialized. I can see why it > generates the warning, but I don't know if it's actually possible. > Anyway initializing "ret" here is harmless. > > Signed-off-by: Dan Carpenter > --- > drivers/soc/qcom/mdt_loader.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/mdt_loader.c b/drivers/soc/qcom/mdt_loader.c > index 1c488024c698..fc58d660692f 100644 > --- a/drivers/soc/qcom/mdt_loader.c > +++ b/drivers/soc/qcom/mdt_loader.c > @@ -188,7 +188,7 @@ static int __qcom_mdt_load(struct device *dev, const struct firmware *fw, > > if (reloc_base) > *reloc_base = mem_reloc; > - > + ret = 0; You are overriding the value here, better keep it at the start. Thanks, Mukesh > out: > kfree(fw_name); >