From: Yassine Oudjana <y.oudjana@protonmail.com>
To: "Barnabás Czémán" <barnabas.czeman@mainlining.org>,
"Robert Foss" <rfoss@kernel.org>,
"Todor Tomov" <todor.too@gmail.com>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Hans Verkuil" <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: qcom: camss: fix VFE pm domain off
Date: Wed, 27 Nov 2024 10:01:14 +0000 [thread overview]
Message-ID: <a0a41b77-ee63-4d55-8c91-baf667c25cba@protonmail.com> (raw)
On 22/11/2024 5:06 am, Barnabás Czémán wrote:
> Fix NULL pointer check before device_link_del
> is called.
>
> Fixes: eb73facec2c2 ("media: qcom: camss: Use common VFE pm_domain_on/pm_domain_off where applicable")
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
> ---
> drivers/media/platform/qcom/camss/camss-vfe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> ---
> base-commit: decc701f41d07481893fdea942c0ac6b226e84cd
> change-id: 20241122-vfe_pm_domain_off-c57008e54167
>
> Best regards,
>
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
> index 80a62ba11295042802cbaec617fb87c492ea6a55..1bf1473331f63b9ab106d21ea263c84d851c8a31 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
> @@ -595,7 +595,7 @@ void vfe_isr_reset_ack(struct vfe_device *vfe)
> */
> void vfe_pm_domain_off(struct vfe_device *vfe)
> {
> - if (!vfe->genpd)
> + if (!vfe->genpd_link)
> return;
>
> device_link_del(vfe->genpd_link);
Tested-by: Yassine Oudjana <y.oudjana@protonmail.com>
next reply other threads:[~2024-11-27 10:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 10:01 Yassine Oudjana [this message]
2024-11-28 9:10 ` [PATCH] media: qcom: camss: fix VFE pm domain off Vladimir Zapolskiy
2024-11-28 10:27 ` barnabas.czeman
2024-11-28 12:02 ` Bryan O'Donoghue
2024-11-28 13:22 ` Vladimir Zapolskiy
2024-11-28 14:24 ` barnabas.czeman
2024-11-29 8:44 ` Vladimir Zapolskiy
-- strict thread matches above, loose matches on Subject: below --
2024-11-22 2:06 Barnabás Czémán
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0a41b77-ee63-4d55-8c91-baf667c25cba@protonmail.com \
--to=y.oudjana@protonmail.com \
--cc=barnabas.czeman@mainlining.org \
--cc=bryan.odonoghue@linaro.org \
--cc=hverkuil@xs4all.nl \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox