From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Vikram Sharma <quic_vikramsa@quicinc.com>,
rfoss@kernel.org, todor.too@gmail.com, mchehab@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
andersson@kernel.org, konradybcio@kernel.org,
hverkuil-cisco@xs4all.nl, cros-qcom-dts-watchers@chromium.org,
catalin.marinas@arm.com, will@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, quic_svankada@quicinc.com,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/7] media: qcom: camss: enable vfe 690 for qcs8300
Date: Mon, 28 Jul 2025 15:14:50 +0100 [thread overview]
Message-ID: <a0c910f2-3c7b-4740-b16b-f1efced107db@linaro.org> (raw)
In-Reply-To: <20250711131134.215382-6-quic_vikramsa@quicinc.com>
On 11/07/2025 14:11, Vikram Sharma wrote:
> The vfe in qcs8300 is version 690, it is same as vfe used in
> sa8775p. vfe gen3 have support for vfe 690.
>
> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
> ---
> .../platform/qcom/camss/camss-vfe-gen3.c | 4 +-
> drivers/media/platform/qcom/camss/camss-vfe.c | 2 +
> drivers/media/platform/qcom/camss/camss.c | 180 ++++++++++++++++++
> 3 files changed, 185 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe-gen3.c b/drivers/media/platform/qcom/camss/camss-vfe-gen3.c
> index a5eddc8c76ae..92ee7c7b8a47 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe-gen3.c
> +++ b/drivers/media/platform/qcom/camss/camss-vfe-gen3.c
> @@ -13,7 +13,9 @@
> #include "camss-vfe.h"
>
> #define IS_VFE_690(vfe) \
> - (vfe->camss->res->version == CAMSS_8775P ? true : false)
> + ((vfe->camss->res->version == CAMSS_8775P) ||\
> + (vfe->camss->res->version == CAMSS_8300) ?\
> + true : false)
>
> #define BUS_REG_BASE_690 \
> (vfe_is_lite(vfe) ? 0x480 : 0x400)
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
> index 99cbe09343f2..1d40184d7d04 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
> @@ -344,6 +344,7 @@ static u32 vfe_src_pad_code(struct vfe_line *line, u32 sink_code,
> case CAMSS_8x96:
> case CAMSS_8250:
> case CAMSS_8280XP:
> + case CAMSS_8300:
> case CAMSS_845:
> case CAMSS_8550:
> case CAMSS_8775P:
> @@ -1974,6 +1975,7 @@ static int vfe_bpl_align(struct vfe_device *vfe)
> case CAMSS_7280:
> case CAMSS_8250:
> case CAMSS_8280XP:
> + case CAMSS_8300:
> case CAMSS_845:
> case CAMSS_8550:
> case CAMSS_8775P:
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index b0fd5fd307a1..abfaa489cc0c 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -2623,6 +2623,186 @@ static const struct camss_subdev_resources csid_res_8300[] = {
> },
> };
>
> +static const struct camss_subdev_resources vfe_res_8300[] = {
> + /* VFE0 */
> + {
> + .regulators = {},
> + .clock = { "cpas_vfe0", "vfe0", "vfe0_fast_ahb",
> + "cpas_ahb", "gcc_axi_hf", "gcc_axi_sf",
> + "core_ahb", "cpas_fast_ahb_clk", "camnoc_axi",
> + "icp_ahb"},
> + .clock_rate = {
> + { 0 },
> + { 480000000 },
> + { 300000000, 400000000 },
> + { 300000000, 400000000 },
> + { 0 },
> + { 0 },
> + { 0, 80000000 },
> + { 300000000, 400000000 },
> + { 400000000 },
> + { 0 },
> + },
> + .reg = { "vfe0" },
> + .interrupt = { "vfe0" },
> + .vfe = {
> + .line_num = 3,
> + .is_lite = false,
> + .has_pd = false,
> + .pd_name = NULL,
> + .hw_ops = &vfe_ops_gen3,
> + .formats_rdi = &vfe_formats_rdi_845,
> + .formats_pix = &vfe_formats_pix_845
> + }
> + },
> + /* VFE1 */
> + {
> + .regulators = {},
> + .clock = { "cpas_vfe1", "vfe1", "vfe1_fast_ahb",
> + "cpas_ahb", "gcc_axi_hf", "gcc_axi_sf",
> + "core_ahb", "cpas_fast_ahb_clk", "camnoc_axi",
> + "icp_ahb"},
> + .clock_rate = {
> + { 0 },
> + { 480000000 },
> + { 300000000, 400000000 },
> + { 300000000, 400000000 },
> + { 0 },
> + { 0 },
> + { 0, 80000000 },
> + { 300000000, 400000000 },
> + { 400000000 },
> + { 0 },
> + },
> + .reg = { "vfe1" },
> + .interrupt = { "vfe1" },
> + .vfe = {
> + .line_num = 3,
> + .is_lite = false,
> + .has_pd = false,
> + .pd_name = NULL,
> + .hw_ops = &vfe_ops_gen3,
> + .formats_rdi = &vfe_formats_rdi_845,
> + .formats_pix = &vfe_formats_pix_845
> + }
> + },
> + /* VFE2 (lite) */
> + {
> + .regulators = {},
> + .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
> + "vfe_lite_csid", "vfe_lite_cphy_rx",
> + "vfe_lite"},
> + .clock_rate = {
> + { 0, 0, 0, 0 },
> + { 300000000, 400000000, 400000000, 400000000 },
> + { 400000000, 400000000, 400000000, 400000000 },
> + { 400000000, 400000000, 400000000, 400000000 },
> + { 480000000, 600000000, 600000000, 600000000 },
> + },
> + .reg = { "vfe_lite0" },
> + .interrupt = { "vfe_lite0" },
> + .vfe = {
> + .line_num = 4,
> + .is_lite = true,
> + .hw_ops = &vfe_ops_gen3,
> + .formats_rdi = &vfe_formats_rdi_845,
> + .formats_pix = &vfe_formats_pix_845
> + }
> + },
> + /* VFE3 (lite) */
> + {
> + .regulators = {},
> + .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
> + "vfe_lite_csid", "vfe_lite_cphy_rx",
> + "vfe_lite"},
> + .clock_rate = {
> + { 0, 0, 0, 0 },
> + { 300000000, 400000000, 400000000, 400000000 },
> + { 400000000, 400000000, 400000000, 400000000 },
> + { 400000000, 400000000, 400000000, 400000000 },
> + { 480000000, 600000000, 600000000, 600000000 },
> + },
> + .reg = { "vfe_lite1" },
> + .interrupt = { "vfe_lite1" },
> + .vfe = {
> + .line_num = 4,
> + .is_lite = true,
> + .hw_ops = &vfe_ops_gen3,
> + .formats_rdi = &vfe_formats_rdi_845,
> + .formats_pix = &vfe_formats_pix_845
> + }
> + },
> + /* VFE4 (lite) */
> + {
> + .regulators = {},
> + .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
> + "vfe_lite_csid", "vfe_lite_cphy_rx",
> + "vfe_lite"},
> + .clock_rate = {
> + { 0, 0, 0, 0 },
> + { 300000000, 400000000, 400000000, 400000000 },
> + { 400000000, 400000000, 400000000, 400000000 },
> + { 400000000, 400000000, 400000000, 400000000 },
> + { 480000000, 600000000, 600000000, 600000000 },
> + },
> + .reg = { "vfe_lite2" },
> + .interrupt = { "vfe_lite2" },
> + .vfe = {
> + .line_num = 4,
> + .is_lite = true,
> + .hw_ops = &vfe_ops_gen3,
> + .formats_rdi = &vfe_formats_rdi_845,
> + .formats_pix = &vfe_formats_pix_845
> + }
> + },
> + /* VFE5 (lite) */
> + {
> + .regulators = {},
> + .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
> + "vfe_lite_csid", "vfe_lite_cphy_rx",
> + "vfe_lite"},
> + .clock_rate = {
> + { 0, 0, 0, 0 },
> + { 300000000, 400000000, 400000000, 400000000 },
> + { 400000000, 400000000, 400000000, 400000000 },
> + { 400000000, 400000000, 400000000, 400000000 },
> + { 480000000, 600000000, 600000000, 600000000 },
> + },
> + .reg = { "vfe_lite3" },
> + .interrupt = { "vfe_lite3" },
> + .vfe = {
> + .line_num = 4,
> + .is_lite = true,
> + .hw_ops = &vfe_ops_gen3,
> + .formats_rdi = &vfe_formats_rdi_845,
> + .formats_pix = &vfe_formats_pix_845
> + }
> + },
> + /* VFE6 (lite) */
> + {
> + .regulators = {},
> + .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
> + "vfe_lite_csid", "vfe_lite_cphy_rx",
> + "vfe_lite"},
> + .clock_rate = {
> + { 0, 0, 0, 0 },
> + { 300000000, 400000000, 400000000, 400000000 },
> + { 400000000, 400000000, 400000000, 400000000 },
> + { 400000000, 400000000, 400000000, 400000000 },
> + { 480000000, 600000000, 600000000, 600000000 },
> + },
> + .reg = { "vfe_lite4" },
> + .interrupt = { "vfe_lite4" },
> + .vfe = {
> + .line_num = 4,
> + .is_lite = true,
> + .hw_ops = &vfe_ops_gen3,
> + .formats_rdi = &vfe_formats_rdi_845,
> + .formats_pix = &vfe_formats_pix_845
> + }
> + },
> +};
> +
> static const struct camss_subdev_resources csiphy_res_8775p[] = {
> /* CSIPHY0 */
> {
This generally looks fine. Please have a look at your pretty extensive
list of clocks and decide if you really need all of them.
I'll trust you to come back with the appropriate list, perhaps even the
list above.
next prev parent reply other threads:[~2025-07-28 14:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 13:11 [PATCH v2 0/7] qcom: qcs8300: Add qcs8300 camss support Vikram Sharma
2025-07-11 13:11 ` [PATCH v2 1/7] media: dt-bindings: Add qcom,qcs8300-camss compatible Vikram Sharma
2025-07-11 13:36 ` Krzysztof Kozlowski
2025-07-11 13:11 ` [PATCH v2 2/7] arm64: dts: qcom: qcs8300: Add support for camss Vikram Sharma
2025-07-11 13:35 ` Krzysztof Kozlowski
2025-07-11 13:41 ` Vikram Sharma
2025-07-11 13:11 ` [PATCH v2 3/7] media: qcom: camss: Add qcs8300 compatible Vikram Sharma
2025-07-28 14:12 ` Bryan O'Donoghue
2025-07-11 13:11 ` [PATCH v2 4/7] media: qcom: camss: enable csid 690 for qcs8300 Vikram Sharma
2025-07-14 9:35 ` Konrad Dybcio
2025-07-11 13:11 ` [PATCH v2 5/7] media: qcom: camss: enable vfe " Vikram Sharma
2025-07-28 14:14 ` Bryan O'Donoghue [this message]
2025-07-11 13:11 ` [PATCH v2 6/7] media: qcom: camss: Add support for CSIPHY QCS8300 Vikram Sharma
2025-07-28 14:15 ` Bryan O'Donoghue
2025-07-11 13:11 ` [PATCH v2 7/7] media: qcom: camss: Enumerate resources for QCS8300 Vikram Sharma
2025-07-28 14:16 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0c910f2-3c7b-4740-b16b-f1efced107db@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_svankada@quicinc.com \
--cc=quic_vikramsa@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).