From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1337BC6FA82 for ; Fri, 23 Sep 2022 17:26:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229625AbiIWR0k (ORCPT ); Fri, 23 Sep 2022 13:26:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231186AbiIWR0d (ORCPT ); Fri, 23 Sep 2022 13:26:33 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3362E14F290 for ; Fri, 23 Sep 2022 10:26:32 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id i26so1294156lfp.11 for ; Fri, 23 Sep 2022 10:26:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=d2aMGH6UHNRKejwJPNEF8etSbQwBB3RTv4C2uFoQ+hQ=; b=Rxm2qRqAZnLWxG+kWDcYrS34l/7LustMqorREHAh37L7BpSVEAe75br2Cga0STKUHa mBzvUCgSYj1AXSH8JrCJ/PyICy+z6sDl4alwbLljG5XhYTcUSTYIZz00wGLa9XAAO1MY HX/IEuup1VLNDKZl23dFQFmkzWB3LE0UwMJ3ptrhrJaHjLKRy/1He8PUQt/J6g84y5e8 CCcrlnPmk+Wpuu9YJrqd7aj151JMn1O8BQl1DT9E4j6p+xfFDgfP2OY/PRLYsQXsjxEb X7NcAO75+UgZr0VdTFCL9mXE0fuXMZhP03tWOBXSS/RXDMgIxg3UwfnyuQsEP5QaimcI qbkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=d2aMGH6UHNRKejwJPNEF8etSbQwBB3RTv4C2uFoQ+hQ=; b=lQewNebxFs5ZK4cDwF3XdcPlzb6P+Mh4VTTA1uFvCP31ml6dzqPJHSk3VSTGeOv4Ww 1PTu4NvWDVlkl9mM2UhBHB94uiwOz0uqtg2NwoHMwxEu8H/GefQ/ZCs5Mo9PmzZgyI7S HX1yhGItuR1weNRSmCR+CvFHFV6D1fMNlP1t5aQNiP5wXeDbKrtWFuV32/B28nGCX2tq V++TGwnUAhUrRNwq4Io+9kJa5cuJwD5h8FomYin0GYCeTPFrE3VCD/ZjizUtAsr8Tj5q TUzM/5Mv9N2iYal+qwXA4K9bXkt7K69oCJlcx1kcHUq1W9IBArVIooTKGajO0ujYy1fM XzDg== X-Gm-Message-State: ACrzQf21KgYjuxPmmMeoqzpgQ4nvSBa6RmUuU3r10wxV6Vxr44+8xz/k r++lgG3CNlHUZQF8iz/jnFL8tA== X-Google-Smtp-Source: AMsMyM6RSipJh6L8w0HLJBu4EMBCoIT3+KEpfBtSapvzTG4RRLReX34X6mW4Pz3ej2J0UKIzYk7uBg== X-Received: by 2002:a19:650f:0:b0:494:827e:5ef5 with SMTP id z15-20020a19650f000000b00494827e5ef5mr3487893lfb.411.1663953990513; Fri, 23 Sep 2022 10:26:30 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id p9-20020a2eba09000000b0026c037747bfsm1481226lja.3.2022.09.23.10.26.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Sep 2022 10:26:30 -0700 (PDT) Message-ID: Date: Fri, 23 Sep 2022 19:26:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v8 7/7] remoteproc: qcom: Add support for memory sandbox Content-Language: en-US To: Srinivasa Rao Mandadapu , linux-remoteproc@vger.kernel.org, agross@kernel.org, andersson@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, quic_plai@quicinc.com, bgoswami@quicinc.com, perex@perex.cz, tiwai@suse.com, srinivas.kandagatla@linaro.org, quic_rohkumar@quicinc.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, swboyd@chromium.org, judyhsiao@chromium.org, devicetree@vger.kernel.org References: <1663938340-24345-1-git-send-email-quic_srivasam@quicinc.com> <1663938340-24345-8-git-send-email-quic_srivasam@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <1663938340-24345-8-git-send-email-quic_srivasam@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 23/09/2022 15:05, Srinivasa Rao Mandadapu wrote: > Update pil driver with SMMU mapping for allowing authorised > memory access to ADSP firmware, by carveout reserved adsp memory > region from device tree file. > Thank you for your patch. There is something to discuss/improve. > + if (!rproc->domain) > + return -EINVAL; > + > + ret = of_parse_phandle_with_args(adsp->dev->of_node, "iommus", "#iommu-cells", 0, &args); I think your bindings do not allow iommus property. Best regards, Krzysztof