From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C7AAC7EE29 for ; Thu, 25 May 2023 23:18:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236327AbjEYXSb (ORCPT ); Thu, 25 May 2023 19:18:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241269AbjEYXSZ (ORCPT ); Thu, 25 May 2023 19:18:25 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83D2EE55 for ; Thu, 25 May 2023 16:18:21 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-4f380cd1019so53329e87.1 for ; Thu, 25 May 2023 16:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685056699; x=1687648699; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nVpMlft04baQe3FGBQ1uPFAK60NKjDWRg8PgqN8ZkKs=; b=GWTOtMpfSAgViyuzSRA6mbYzXhGs2FqqTAwIzKk3x37OoFGbj85vDXPTmX+X0nyUPj lG1Fhx76fjwSnGCNkjGDFbwZWQzxlot5ZPq2QY+XP7yxKv+C6/LY4US57qZgGBn+RJZ4 CVWdzs0wvNq8SCL04pSVU9U2QvGY3cLy21bZakUGE299pqo26qW40fk0z1F5Mb0I2Cev 5V/EoO9gAIuMbozA/5zAWCi8KYlQOv5YvyrecOuybW2ze6N7yRHa+ge0NWYZJCRnyz14 wvgY/Qo55yWcXyOTKZIrc6eqQa1xrO+v8yHLgvlWJeh0xMSuwb1r8GLEn6PoJTi6ha97 NF6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685056699; x=1687648699; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nVpMlft04baQe3FGBQ1uPFAK60NKjDWRg8PgqN8ZkKs=; b=G/PUKuqtsxTU8MJEvV9ZCRGJvKeZdnxAd10iOjlYwOSCyByEACRNJ6HAMD7gaNQxF0 MF1IsGeRdUX69ioBrhXcUXB2T4qd41PsXfgmREO0Nxkz8Z+43MNmZreLXyjNgfgp/6/W t0YoKqzg9jaRVG1D87qxqeNen+e0xaN09hbNy4olXP8NFb9ZH8hpxjPty7dT41SUHrxa 0dHMR0rxsijNunTwu0uTfV8cfXOEMqMzCa7bu6WReGmKXqbhRMtq5xPCaFj3cvwFImMk TANHiYulOtRuQBQXMnsU7nAwFS+AN3F7pkr8Yhx5oG5T0ZJKl215On4byeTCSVJxrZfI HQ5Q== X-Gm-Message-State: AC+VfDw5IfW9PWQiUth8TW6R/V3Hx+eCwhqS8c38DGfWdkNSU4o1k6Yn DXjh2UD/wHxTIrYMsLBVxs5cFQSQmUrzTPFzdQc= X-Google-Smtp-Source: ACHHUZ42t+kPWopue5lTtE9aHyixf26vmAWbHIBbKEH6AO1badc8c70TkbKv9vO1kH8MBf6kPbL44A== X-Received: by 2002:a05:6512:410:b0:4f4:d805:cf62 with SMTP id u16-20020a056512041000b004f4d805cf62mr950794lfk.5.1685056699552; Thu, 25 May 2023 16:18:19 -0700 (PDT) Received: from [192.168.1.101] (abyj77.neoplus.adsl.tpnet.pl. [83.9.29.77]) by smtp.gmail.com with ESMTPSA id t9-20020ac243a9000000b004edc485f86bsm366766lfl.239.2023.05.25.16.18.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 May 2023 16:18:19 -0700 (PDT) Message-ID: Date: Fri, 26 May 2023 01:18:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v4 3/5] soc: qcom: smem: introduce qcom_smem_get_soc_id() Content-Language: en-US To: Robert Marko , agross@kernel.org, andersson@kernel.org, ilia.lin@kernel.org, rafael@kernel.org, viresh.kumar@linaro.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org Cc: ansuelsmth@gmail.com References: <20230525210214.78235-1-robimarko@gmail.com> <20230525210214.78235-3-robimarko@gmail.com> From: Konrad Dybcio In-Reply-To: <20230525210214.78235-3-robimarko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 25.05.2023 23:02, Robert Marko wrote: > Introduce a helper to return the SoC SMEM ID, which is used to identify the > exact SoC model as there may be differences in the same SoC family. > > Currently, cpufreq-nvmem does this completely in the driver and there has > been more interest expresed for other drivers to use this information so > lets expose a common helper to prevent redoing it in individual drivers > since this field is present on every SMEM table version. > > Signed-off-by: Robert Marko > --- > Changes in v4: > * Change helper name to qcom_smem_get_soc_id() > * Remove len and just pass NULL, that is sufficient here > > Changes in v3: > * Change export to EXPORT_SYMBOL_GPL > * Use an argument for returning SoC ID > * Update kerneldoc > --- > drivers/soc/qcom/smem.c | 23 +++++++++++++++++++++++ > include/linux/soc/qcom/smem.h | 2 ++ > 2 files changed, 25 insertions(+) > > diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c > index bc98520c4969..78cf79ea4924 100644 > --- a/drivers/soc/qcom/smem.c > +++ b/drivers/soc/qcom/smem.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > > /* > * The Qualcomm shared memory system is a allocate only heap structure that > @@ -772,6 +773,28 @@ phys_addr_t qcom_smem_virt_to_phys(void *p) > } > EXPORT_SYMBOL_GPL(qcom_smem_virt_to_phys); > > +/** > + * qcom_smem_get_soc_id() - return the SoC ID > + * @id: On success, we return the SoC ID here. > + * > + * Look up SoC ID from HW/SW build ID and return it. > + * > + * Return: 0 on success, negative errno on failure. > + */ > +int qcom_smem_get_soc_id(u32 *id) __le32 *id LGTM otherwise! Konrad > +{ > + struct socinfo *info; > + > + info = qcom_smem_get(QCOM_SMEM_HOST_ANY, SMEM_HW_SW_BUILD_ID, NULL); > + if (IS_ERR(info)) > + return PTR_ERR(info); > + > + *id = info->id; > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(qcom_smem_get_soc_id); > + > static int qcom_smem_get_sbl_version(struct qcom_smem *smem) > { > struct smem_header *header; > diff --git a/include/linux/soc/qcom/smem.h b/include/linux/soc/qcom/smem.h > index 86e1b358688a..223db6a9c733 100644 > --- a/include/linux/soc/qcom/smem.h > +++ b/include/linux/soc/qcom/smem.h > @@ -11,4 +11,6 @@ int qcom_smem_get_free_space(unsigned host); > > phys_addr_t qcom_smem_virt_to_phys(void *p); > > +int qcom_smem_get_soc_id(u32 *id); > + > #endif