From: Krzysztof Kozlowski <krzk@kernel.org>
To: Xin Liu <quic_liuxin@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@quicinc.com,
quic_jiegan@quicinc.com, quic_aiquny@quicinc.com,
quic_tingweiz@quicinc.com
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: qcs8300-ride: Add watchdog node
Date: Thu, 21 Nov 2024 11:19:36 +0100 [thread overview]
Message-ID: <a1dde768-aeb8-4777-b4f9-d3c52b046fbd@kernel.org> (raw)
In-Reply-To: <64ec97a7-8e91-44d7-85ff-8b00304214fc@quicinc.com>
On 21/11/2024 10:44, Xin Liu wrote:
>
>
> 在 2024/11/21 0:59, Krzysztof Kozlowski 写道:
>> On 19/11/2024 11:23, Xin Liu wrote:
>>> Add watchdog clock on the Qualcomm QCS8300 Ride platform.
>>>
>>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
>>> ---
>>> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> index 7eed19a694c3..3024338bcfbc 100644
>>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> @@ -265,3 +265,7 @@ &ufs_mem_phy {
>>> vdda-pll-supply = <&vreg_l5a>;
>>> status = "okay";
>>> };
>>> +
>>> +&watchdog {
>>> + clocks = <&sleep_clk>;
>>> +};
>>> \ No newline at end of file
>>
>> Look, your patches have errors...
>>
> This is the information when I apply my patch.
> ../linux-next$ git am ./wdt/test.patch
> Applying: arm64: dts: qcom: qcs8300-ride: Add watchdog node
> ../linux-next$
>
> There are no error messages here.
So I made up that above error message? You sent patch with an error
message. I responded directly under it, so what can I say more?
You refuse to fix this, so I NAK this patch.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-21 10:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 10:23 [PATCH v2 0/3] Enable Watchdog on QCS8300 Xin Liu
2024-11-19 10:23 ` [PATCH v2 1/3] dt-bindings: watchdog: Document Qualcomm QCS8300 watchdog Xin Liu
2024-11-19 10:23 ` [PATCH v2 2/3] arm64: dts: qcom: qcs8300: Add watchdog node Xin Liu
2024-11-20 17:00 ` Krzysztof Kozlowski
2024-11-22 7:59 ` Xin Liu
2024-11-19 10:23 ` [PATCH v2 3/3] arm64: dts: qcom: qcs8300-ride: " Xin Liu
2024-11-20 16:59 ` Krzysztof Kozlowski
2024-11-21 9:44 ` Xin Liu
2024-11-21 10:19 ` Krzysztof Kozlowski [this message]
2024-11-21 11:58 ` Xin Liu
2024-11-21 18:48 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1dde768-aeb8-4777-b4f9-d3c52b046fbd@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_aiquny@quicinc.com \
--cc=quic_jiegan@quicinc.com \
--cc=quic_liuxin@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox