From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01619C433EF for ; Tue, 22 Feb 2022 14:10:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231466AbiBVOK3 (ORCPT ); Tue, 22 Feb 2022 09:10:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230196AbiBVOK3 (ORCPT ); Tue, 22 Feb 2022 09:10:29 -0500 Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB52615F617 for ; Tue, 22 Feb 2022 06:10:03 -0800 (PST) Received: by mail-qv1-xf2a.google.com with SMTP id a1so1145159qvl.6 for ; Tue, 22 Feb 2022 06:10:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=XR5FZFGaIIKTzVrtc+qtDeldPYFhK+vnor66vP4A6qE=; b=d2PXqmoJdsG3+AVpuPryy+/yq70x6q2BsCW0wo1sZ2XTr6NKseHqDZJFWBX5EdjBaj lUh2Q62sr7Z6VEHYqQZ9bZeQLO5HNGcAldRPjVodDIoO/jUnZXQIWaH9KqdlHqqZN5bZ m6CsUUE5mShjmYVas/8ImoZiaDWRUg0Sbl4UKOLiIDFkFGxD4reVTeEP0U9l8D5TTemm apZVoAWDK42QHzKM9M2M8FtvZl2CIxrF516twZ+oet52mrU3UEJZ6a0iIdT1O+lVPX1L 1ealdeBBMSt62qEBjdRqwPJNYxRyqGgEcRpfAgNobS7zu2sqEY0jNdK+VvnbDrwOyAu2 WgKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=XR5FZFGaIIKTzVrtc+qtDeldPYFhK+vnor66vP4A6qE=; b=MoCpoUcV/iHsd2av+uSNSmUGhQ4ZB1aBqhYFR9crsd0jypI/Vb59sTugFDJmC4Q7rE +ryfH2TFUkr38X0i6/Nw5ExZ77lwX+QC+FP9/H7DhycKuq1f3QBA9ErTyovJFA2hsaen dvFIogS9r1rGLLEpdf8o5IWvwe+McsnZyeNWgF9Mqu/d8NmllcIh91/2g8nB6REzR+K8 xtbXXoigkLvGgirpQJKZ5GITptXoUk+RayCAMdn7XibBVyPHLMbMFxT4KgosWSOCYrFH 6yShMIOPtKBgMUIlEeAcoytlzZkL2t+dB1x1Nm5dzKDPhuVcm0cfK9odHPkaIdC3lqCQ ul+Q== X-Gm-Message-State: AOAM530shiaY+0i2XArCYUHEAYO36sGztwke1aiOImHne2BEjknuLSSy E8M/x6qusxzV4QNCB741BHb1EpmGRKJO9fqw X-Google-Smtp-Source: ABdhPJwWqciVne655CNWHtCM8/p9iRCfk7DpJuRiXA0dp7NT/73hA5DeKFBPUvXQ25aZwkNYKL2lVA== X-Received: by 2002:a05:622a:206:b0:2dd:dbdb:f598 with SMTP id b6-20020a05622a020600b002dddbdbf598mr13521885qtx.138.1645539002901; Tue, 22 Feb 2022 06:10:02 -0800 (PST) Received: from [172.22.22.26] (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id e9sm306676qkm.27.2022.02.22.06.10.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Feb 2022 06:10:02 -0800 (PST) Message-ID: Date: Tue, 22 Feb 2022 08:10:00 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 16/25] bus: mhi: ep: Add support for powering up the MHI endpoint stack Content-Language: en-US To: Manivannan Sadhasivam Cc: mhi@lists.linux.dev, quic_hemantk@quicinc.com, quic_bbhatt@quicinc.com, quic_jhugo@quicinc.com, vinod.koul@linaro.org, bjorn.andersson@linaro.org, dmitry.baryshkov@linaro.org, quic_vbadigan@quicinc.com, quic_cang@quicinc.com, quic_skananth@quicinc.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220212182117.49438-1-manivannan.sadhasivam@linaro.org> <20220212182117.49438-17-manivannan.sadhasivam@linaro.org> <10240bc5-ef9f-7555-402e-57ca2b0b0a14@linaro.org> <20220222090816.GD5029@thinkpad> From: Alex Elder In-Reply-To: <20220222090816.GD5029@thinkpad> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2/22/22 3:08 AM, Manivannan Sadhasivam wrote: > On Tue, Feb 15, 2022 at 04:39:37PM -0600, Alex Elder wrote: >> On 2/12/22 12:21 PM, Manivannan Sadhasivam wrote: >>> Add support for MHI endpoint power_up that includes initializing the MMIO >>> and rings, caching the host MHI registers, and setting the MHI state to M0. >>> After registering the MHI EP controller, the stack has to be powered up >>> for usage. >>> >>> Signed-off-by: Manivannan Sadhasivam >> >> Very little to say on this one. -Alex >> >>> --- >>> drivers/bus/mhi/ep/internal.h | 6 + >>> drivers/bus/mhi/ep/main.c | 229 ++++++++++++++++++++++++++++++++++ >>> include/linux/mhi_ep.h | 22 ++++ >>> 3 files changed, 257 insertions(+) >>> >>> diff --git a/drivers/bus/mhi/ep/internal.h b/drivers/bus/mhi/ep/internal.h >>> index e4e8f06c2898..ee8c5974f0c0 100644 >>> --- a/drivers/bus/mhi/ep/internal.h >>> +++ b/drivers/bus/mhi/ep/internal.h >>> @@ -242,4 +242,10 @@ int mhi_ep_set_m0_state(struct mhi_ep_cntrl *mhi_cntrl); >>> int mhi_ep_set_m3_state(struct mhi_ep_cntrl *mhi_cntrl); >>> int mhi_ep_set_ready_state(struct mhi_ep_cntrl *mhi_cntrl); >>> +/* MHI EP memory management functions */ >>> +int mhi_ep_alloc_map(struct mhi_ep_cntrl *mhi_cntrl, u64 pci_addr, size_t size, >>> + phys_addr_t *phys_ptr, void __iomem **virt); >>> +void mhi_ep_unmap_free(struct mhi_ep_cntrl *mhi_cntrl, u64 pci_addr, phys_addr_t phys, >>> + void __iomem *virt, size_t size); >>> + >>> #endif >>> diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c > > [...] > >>> + >>> +static void mhi_ep_enable_int(struct mhi_ep_cntrl *mhi_cntrl) >>> +{ >> >> Are channel doorbell interrupts enabled separately now? >> (There was previously an enable_chdb_interrupts() call.) >> > > Doorbell interrupts are enabled when the corresponding channel gets started. > Enabling all interrupts here triggers spurious irqs as some of the interrupts > associated with hw channels always get triggered. This is excellent. Thanks for the explanation. -Alex > > Thanks, > Mani