From: Neil Armstrong <neil.armstrong@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
"Al Cooper" <alcooperx@gmail.com>,
"Alexander Shiyan" <shc_work@mail.ru>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Baruch Siach" <baruch@tkos.co.il>,
"Bjorn Andersson" <andersson@kernel.org>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"David S. Miller" <davem@davemloft.net>,
"Fabio Estevam" <festevam@gmail.com>,
"Hammer Hsieh" <hammerh0314@gmail.com>,
"Christian König" <christian.koenig@amd.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Kumaravel Thiagarajan" <kumaravel.thiagarajan@microchip.com>,
"Laxman Dewangan" <ldewangan@nvidia.com>,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
"Maciej W. Rozycki" <macro@orcam.me.uk>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Michal Simek" <michal.simek@amd.com>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Pali Rohár" <pali@kernel.org>,
"Patrice Chotard" <patrice.chotard@foss.st.com>,
"Peter Korsgaard" <jacmet@sunsite.dk>,
"Richard Genoud" <richard.genoud@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Stefani Seibold" <stefani@seibold.net>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Taichi Sugaya" <sugaya.taichi@socionext.com>,
"Takao Orito" <orito.takao@socionext.com>,
"Tharun Kumar P" <tharunkumar.pasumarthi@microchip.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Timur Tabi" <timur@kernel.org>,
"Vineet Gupta" <vgupta@kernel.org>
Subject: Re: [PATCH 00/15] tty: serial: switch from circ_buf to kfifo
Date: Mon, 22 Apr 2024 09:50:40 +0200 [thread overview]
Message-ID: <a27572a5-2f1c-46ff-8528-4cae17c8e5e9@linaro.org> (raw)
In-Reply-To: <2024042030-gumdrop-outdoors-fc81@gregkh>
Hi Greg,
On 20/04/2024 07:42, Greg KH wrote:
> On Fri, Apr 19, 2024 at 05:12:28PM +0200, Neil Armstrong wrote:
>> This patchset has at least broken all Amlogic and Qualcomm boards so
>> far, only part of them were fixed in next- but this serie has been
>> merged in v1 with no serious testing and should've been dropped
>> immediately when the first regressions were reported.
>
> What is not yet fixed with the recent patch that was just sent to the
> list?
>
> Doing core changes like this is hard, I have seen no lack of willingness
> to fix reported problems or major breakages that would deserve a revert.
It broken all Amlogic and Qualcomm boards, are we sure it didn't break other systems that are not CI tested on -next ?
This serie clearly deserved a v2, patch 11 wasn't seriously reviewed, and it deserved a ping on the RFT before sending a v1.
I don't understand why speeding up this changeset and applying it without any reviews nor tests was so important.
Thanks,
Neil
>
> greg k-h
next prev parent reply other threads:[~2024-04-22 7:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 6:08 [PATCH 00/15] tty: serial: switch from circ_buf to kfifo Jiri Slaby (SUSE)
2024-04-05 6:08 ` [PATCH 11/15] tty: msm_serial: use dmaengine_prep_slave_sg() Jiri Slaby (SUSE)
2024-04-15 21:17 ` Marek Szyprowski
2024-04-16 10:23 ` Jiri Slaby
2024-04-17 10:15 ` Marek Szyprowski
2024-04-17 10:50 ` Jiri Slaby
2024-04-17 12:45 ` Marek Szyprowski
2024-04-19 7:17 ` Jiri Slaby
2024-04-19 7:43 ` Jiri Slaby
2024-04-19 7:53 ` Jiri Slaby
2024-04-19 8:00 ` Marek Szyprowski
2024-04-19 8:09 ` Jiri Slaby
[not found] ` <CGME20240415125847eucas1p2bc180c35f40f9c490c713679871af9ae@eucas1p2.samsung.com>
[not found] ` <20240405060826.2521-13-jirislaby@kernel.org>
2024-04-15 12:58 ` [PATCH 12/15] tty: serial: switch from circ_buf to kfifo Marek Szyprowski
2024-04-15 13:28 ` Jiri Slaby
2024-04-15 14:17 ` Marek Szyprowski
2024-04-16 5:48 ` [PATCH] serial: meson+qcom: don't advance the kfifo twice Jiri Slaby (SUSE)
2024-04-17 10:08 ` [PATCH 12/15] tty: serial: switch from circ_buf to kfifo Anders Roxell
2024-04-17 10:20 ` Marek Szyprowski
2024-04-17 11:19 ` Anders Roxell
2024-04-22 6:45 ` Jiri Slaby
2024-04-22 10:05 ` Anders Roxell
2024-04-19 15:12 ` [PATCH 00/15] " Neil Armstrong
2024-04-20 5:42 ` Greg KH
2024-04-22 7:50 ` Neil Armstrong [this message]
2024-04-22 5:51 ` Jiri Slaby
2024-04-22 7:43 ` neil.armstrong
2024-06-07 20:32 ` Ferry Toth
2024-06-10 20:16 ` Ferry Toth
2024-06-11 7:36 ` Jiri Slaby
2024-06-12 13:13 ` Ilpo Järvinen
2024-06-16 20:55 ` Ferry Toth
2024-06-17 6:23 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a27572a5-2f1c-46ff-8528-4cae17c8e5e9@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=alcooperx@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=aneesh.kumar@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=baruch@tkos.co.il \
--cc=christian.koenig@amd.com \
--cc=christophe.leroy@csgroup.eu \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hammerh0314@gmail.com \
--cc=jacmet@sunsite.dk \
--cc=jbrunet@baylibre.com \
--cc=jirislaby@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=khilman@baylibre.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kumaravel.thiagarajan@microchip.com \
--cc=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=macro@orcam.me.uk \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@amd.com \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.ibm.com \
--cc=nicolas.ferre@microchip.com \
--cc=npiggin@gmail.com \
--cc=orito.takao@socionext.com \
--cc=orsonzhai@gmail.com \
--cc=pali@kernel.org \
--cc=patrice.chotard@foss.st.com \
--cc=richard.genoud@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shc_work@mail.ru \
--cc=stefani@seibold.net \
--cc=sugaya.taichi@socionext.com \
--cc=sumit.semwal@linaro.org \
--cc=tharunkumar.pasumarthi@microchip.com \
--cc=thierry.reding@gmail.com \
--cc=timur@kernel.org \
--cc=vgupta@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox