From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Georgi Djakov <djakov@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 03/10] interconnect: qcom: icc-rpm: Let nodes drive their own bus clock
Date: Tue, 1 Aug 2023 13:29:16 +0200 [thread overview]
Message-ID: <a289c4ed-7a05-76ea-edfc-3148cfd6c020@linaro.org> (raw)
In-Reply-To: <ZMjlZyFcB9IFEG60@gerhold.net>
On 1.08.2023 12:58, Stephan Gerhold wrote:
> On Mon, Jul 31, 2023 at 12:52:19PM +0200, Konrad Dybcio wrote:
>> If this hardware couldn't get messier, some nodes are supposed to drive
>> their own bus clock.. Presumably to connect to some intermediate
>> interface between the node itself and the bus it's (supposed to be)
>> connected to.
>>
>> Expand the node struct with the necessary data and hook up the
>> allocations & calculations.
>>
>> To save on memory (not very many nodes have their own clocks), allocate
>> a pointer to an array instead of allocating an array within
>> qcom_icc_node.
>>
>
> Only on ARM32 though. On ARM64 you waste extra memory:
>
> u32 bus_clk_rate[QCOM_SMD_RPM_STATE_NUM];
> sizeof(bus_clk_rate) = QCOM_SMD_RPM_STATE_NUM * sizeof(bus_clk_rate[0])
> = 2 * 4
> = 8
>
> u32 *bus_clk_rate;
> sizeof(bus_clk_rate) = sizeof(ptr)
> = 8 (for ARM64)
> + 2 * 4 + malloc overhead
> for each node with bus_clk_desc
>
> which is > 8 from above.
>
> I'm not quite convinced this optimization is worth it.
Right, u32 is not the same size as *u32, brain fart :D
Konrad
next prev parent reply other threads:[~2023-08-01 11:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 10:52 [PATCH v2 00/10] Fix up icc clock rate calculation on some platforms Konrad Dybcio
2023-07-31 10:52 ` [PATCH v2 01/10] interconnect: qcom: icc-rpm: Add AB/IB calculations coefficients Konrad Dybcio
2023-08-01 10:53 ` Stephan Gerhold
2023-07-31 10:52 ` [PATCH v2 02/10] interconnect: qcom: icc-rpm: Separate out clock rate calulcations Konrad Dybcio
2023-07-31 10:52 ` [PATCH v2 03/10] interconnect: qcom: icc-rpm: Let nodes drive their own bus clock Konrad Dybcio
2023-08-01 10:58 ` Stephan Gerhold
2023-08-01 11:29 ` Konrad Dybcio [this message]
2023-07-31 10:52 ` [PATCH v2 04/10] interconnect: qcom: icc-rpm: Check for node-specific rate coefficients Konrad Dybcio
2023-08-01 11:01 ` Stephan Gerhold
2023-07-31 10:52 ` [PATCH v2 05/10] interconnect: qcom: qcm2290: Hook up MAS_APPS_PROC's bus clock Konrad Dybcio
2023-07-31 10:52 ` [PATCH v2 06/10] interconnect: qcom: qcm2290: Set AB coefficients Konrad Dybcio
2023-07-31 10:52 ` [PATCH v2 07/10] interconnect: qcom: qcm2290: Update EBI channel configuration Konrad Dybcio
2023-07-31 10:52 ` [PATCH v2 08/10] interconnect: qcom: sdm660: Set AB/IB coefficients Konrad Dybcio
2023-07-31 10:52 ` [PATCH v2 09/10] interconnect: qcom: msm8996: " Konrad Dybcio
2023-07-31 10:52 ` [PATCH v2 10/10] clk: qcom: smd-rpm: Move CPUSS_GNoC clock to interconnect Konrad Dybcio
2023-08-04 16:31 ` [PATCH v2 00/10] Fix up icc clock rate calculation on some platforms Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a289c4ed-7a05-76ea-edfc-3148cfd6c020@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=djakov@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox