Re: [PATCH v5] crypto: qce - Add runtime PM and interconnect bandwidth scaling support

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 11/20/25 7:24 AM, quic_utiwari@quicinc.com wrote:
> From: Udit Tiwari <quic_utiwari@quicinc.com>
> 
> The Qualcomm Crypto Engine (QCE) driver currently lacks support for
> runtime power management (PM) and interconnect bandwidth control.
> As a result, the hardware remains fully powered and clocks stay
> enabled even when the device is idle. Additionally, static
> interconnect bandwidth votes are held indefinitely, preventing the
> system from reclaiming unused bandwidth.

[...]

> @@ -90,13 +93,17 @@ static int qce_handle_queue(struct qce_device *qce,
>  	struct crypto_async_request *async_req, *backlog;
>  	int ret = 0, err;
>  
> +	ret = pm_runtime_resume_and_get(qce->dev);
> +	if (ret < 0)
> +		return ret;
> +

This is quite new, but maybe we could use

ACQUIRE(pm_runtime_active_try, pm)(qce->dev);
ret = ACQUIRE_ERR(pm_runtime_active_auto_try, &pm)
if (ret)
	return ret;

and drop the goto-s

Konrad