From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF548C678D5 for ; Wed, 11 Jan 2023 11:26:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232343AbjAKLZi (ORCPT ); Wed, 11 Jan 2023 06:25:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233509AbjAKLZC (ORCPT ); Wed, 11 Jan 2023 06:25:02 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5A1A10FC9 for ; Wed, 11 Jan 2023 03:25:01 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id v2so3698282wrw.10 for ; Wed, 11 Jan 2023 03:25:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qbdDKI4Ey6JY+q0XVlpG88pauoONaYof/XvXYc94UzA=; b=Qhw27iT/0tu/MU2cQXm2Dr6zbSB2A3n5D989VL7VYjalRm1qn5xDYtaN9B+c5b6Hm+ K0qEVuZubWBPIcqPkvyvmdi11MhcjWkQ2Xo1N1fVK/XfdPZ8cqYcGvjUzE7oht1/Uwt2 nc3t/s0O0DpjCietGC8WAYerFzWjjr7IxgndJbu993xkE29Y9HmZ630ur4auKA9K8ozL WrbeJIOv0urwLcFvMNKe4s8rOsEjL7C5CVgnazM9yTNuuZCkKHnsss5O0mUuUSQEa+4A D6sqEjQ73+Bh2zmdJCwE8iBFCxwIC/DodX518Q3mxomziX5LCuewJaHxwAKa+vJsCnjB j+1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qbdDKI4Ey6JY+q0XVlpG88pauoONaYof/XvXYc94UzA=; b=Fi0fr6ZtbCkyzII2hskmLyz/gt0d5yAG1uG6pcFxrv30mHZKj5/2Db7ToKDMTEKyVT Mp5U06JgIpC1x0dXIw8TcCuwvqGTF4oNhsfHidXzJ5bI2lhGUIvZI57hSNW9qzu1NMSr eqVz2mFxzo488FIbdTfPG9Gen3XAxSiF42MRHJ3nhd+DXZrfQvTCbuY/4U1SNJeZoy5X k2vaIcRtK7fjjIver62wVacA+2TZAEeizCvJqIXApm0FgRBsdQneYGaaCW7e3zcxKqGs jep7vCRFVnqtefSMIXug0llR/w0F9WjR8Ed2qOXPy8L4rFS2CEiwoK1+ws7SQ+hlMCIC PbDg== X-Gm-Message-State: AFqh2koix/wUKgEhUjaPM7NSPqFttbgvPJqLdzPFK2QT5PsLTgXs8j52 Rs95YjUTDGGmqB8JGnstXjFkUA== X-Google-Smtp-Source: AMrXdXs+MEEL6QPXWp25IjjQP0ytvbLLgmYxzxdMAWuUKHHACK6fUF60Dkt6yH8ZKfS6vurGKMKxag== X-Received: by 2002:adf:dc81:0:b0:293:fff0:63b3 with SMTP id r1-20020adfdc81000000b00293fff063b3mr24022963wrj.4.1673436300202; Wed, 11 Jan 2023 03:25:00 -0800 (PST) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id q16-20020adff950000000b002bcaa47bf78sm4253734wrr.26.2023.01.11.03.24.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jan 2023 03:24:59 -0800 (PST) Message-ID: Date: Wed, 11 Jan 2023 12:24:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] thermal/drivers/qcom: Remove duplicate set next trip point interrupt code Content-Language: en-US To: Bjorn Andersson Cc: rafael@kernel.org, dmitry.baryshkov@linaro.org, konrad.dybcio@linaro.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, Amit Kucheria , Thara Gopinath , Andy Gross , Zhang Rui , open list References: <20230110103420.2430518-1-daniel.lezcano@kernel.org> <20230110181328.el2kicyrg2j554c2@builder.lan> From: Daniel Lezcano In-Reply-To: <20230110181328.el2kicyrg2j554c2@builder.lan> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 10/01/2023 19:13, Bjorn Andersson wrote: > On Tue, Jan 10, 2023 at 11:34:20AM +0100, Daniel Lezcano wrote: >> From: Daniel Lezcano >> >> The tsens driver reprogram the next trip points in the irq >> handler. This function then call thermal_zone_device_update(). >> >> However, thermal_zone_device_update() calls thermal_zone_set_trips() >> and from there it calls the backend 'set_trips' ops. This one in turn >> reprogram the next trip points (low/high). >> >> Consequently, the code setting the next trip points interrupt in the >> interrupt handle is not needed and could be removed. >> > > > Reviewed-by: Bjorn Andersson > >> Signed-off-by: Daniel Lezcano >> Signed-off-by: Daniel Lezcano > > The last one should be the address you sent your patch from, and that > was the first one. So I think you should drop this one. Thanks for the review. I'll remove the duplicated SoB. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog