From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70248C433F5 for ; Sun, 9 Oct 2022 18:55:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230153AbiJISzy (ORCPT ); Sun, 9 Oct 2022 14:55:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230034AbiJISzx (ORCPT ); Sun, 9 Oct 2022 14:55:53 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F2D8659E for ; Sun, 9 Oct 2022 11:55:52 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id f37so13813923lfv.8 for ; Sun, 09 Oct 2022 11:55:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qH4ZdZe+x9C/mI7GHILlpyuEO7Jb1CNK+ic7+GHbAPg=; b=U67pc2OnzYA36zslKIYqtHiPcMCpSF7wMvMSO3Ncc7e7XL4rSnYrEgUVrEq5SVQ3Jk uK9TEAAsUiahgTYMsFuMpELEL3XYe1l1WY4z7K8NtsVsxGL7kjDBGRSZS622q3mb5vrK bFtZI96xetuaJyGuSbGpTMzg1sWCiBdqiJX7ifEXJ/NW8yldlwsFFwncDIutLsMQFFIA 9A0qENGe9B0nTnApk7TRWE4myDf2aK20z5RQ0McOfYvLuURpLcy7rrFc1hQJqBPu3YxO ppd1k+MPhESgcA/+n31BW1JR6etJ4e/nWL/S09r9Oyn+ppQEJwhEPcbmkhAs4lcoNuEr H9ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qH4ZdZe+x9C/mI7GHILlpyuEO7Jb1CNK+ic7+GHbAPg=; b=EF95UJ+Yfxpncsbu0JhbMRTPFTRpWin+MKcle95bchhMdr5bQfUcWkNvI3Cai6cqTv EHA1JPn35Cxl6Snb9hDfuvOU8r9Crf/rrP1k3ksLhCc7IhwOgPxwO/+57IWbyINGvL/v x5sNkGGnnUDbUd40Gr5OFoDd1AEHMJIvg545q7Vcix5QoCVa1opZgHpysB3eZ2MwAeGh 0DGt+AP/lbgOVkrwtA0QZDCvFALD2kNl/MUIx6lgO5WOjBGHsUmJKvAw00aQdG6+96E1 lVG15vNSfu+UvKdXotu8WcHPD34ipC5uGiv5Q0gaO9Ix09ScjGgTMY1CnKcojYu3uQJg IFAg== X-Gm-Message-State: ACrzQf0h2K/nEDBYDKikuuTzx7Ispm2vBJAFLVxexLk66Nq/03ZWSs+3 wsp9ynreqZi/yufvQen1Pcgyew== X-Google-Smtp-Source: AMsMyM5XudCQ8+NtBNRpwa0An+WQMISOz2GaDYRpbDg8sJiqOjSyAFsOtplF00BqphiaiAFA/WnMKQ== X-Received: by 2002:a05:6512:6d2:b0:4a2:4f62:270 with SMTP id u18-20020a05651206d200b004a24f620270mr5064072lff.143.1665341750545; Sun, 09 Oct 2022 11:55:50 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id h15-20020ac250cf000000b00499b27a329esm1108791lfm.300.2022.10.09.11.55.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Oct 2022 11:55:50 -0700 (PDT) Message-ID: Date: Sun, 9 Oct 2022 21:55:49 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v3 05/10] drm/msm/dsi: Appropriately set dsc->mux_word_size based on bpc Content-Language: en-GB To: Marijn Suijten , phone-devel@vger.kernel.org, Rob Clark , Abhinav Kumar , Vinod Koul Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Sean Paul , David Airlie , Daniel Vetter , Douglas Anderson , Vladimir Lypak , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20221009184824.457416-1-marijn.suijten@somainline.org> <20221009184824.457416-6-marijn.suijten@somainline.org> From: Dmitry Baryshkov In-Reply-To: <20221009184824.457416-6-marijn.suijten@somainline.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 09/10/2022 21:48, Marijn Suijten wrote: > This field is currently unread but will come into effect when duplicated > code below is migrated to call drm_dsc_compute_rc_parameters(), which > uses the bpc-dependent value of the local variable mux_words_size in > much the same way. > > The hardcoded constant seems to be a remnant from the `/* bpc 8 */` > comment right above, indicating that this group of field assignments is > applicable to bpc = 8 exclusively and should probably bail out on > different bpc values, until constants for other bpc values are added (or > the current ones are confirmed to be correct across multiple bpc's). > > Fixes: b9080324d6ca ("drm/msm/dsi: add support for dsc data") > Signed-off-by: Marijn Suijten Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry