From: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
To: Youssef Samir <youssef.abdulrahman@oss.qualcomm.com>,
carl.vanderlip@oss.qualcomm.com, troy.hanson@oss.qualcomm.com,
zachary.mckevitt@oss.qualcomm.com
Cc: ogabbay@kernel.org, lizhi.hou@amd.com,
karol.wachowski@linux.intel.com, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] accel/qaic: Replace user defined overflow check
Date: Mon, 20 Oct 2025 09:05:16 -0600 [thread overview]
Message-ID: <a4367373-a0a4-4876-bec0-d8a560244c40@oss.qualcomm.com> (raw)
In-Reply-To: <20251015152239.167226-1-youssef.abdulrahman@oss.qualcomm.com>
On 10/15/2025 9:22 AM, Youssef Samir wrote:
> From: Sourab Bera <quic_sourbera@quicinc.com>
>
> Replace the current logic to check overflow, with the kernel-provided
> macro `check_mul_overflow` in the function __qaic_execute_bo_ioctl().
>
> Signed-off-by: Sourab Bera <quic_sourbera@quicinc.com>
> Signed-off-by: Youssef Samir <youssef.abdulrahman@oss.qualcomm.com>
Youssef,
It looks like this conflicts with "accel/qaic: Replace kcalloc +
copy_from_user with memdup_array_user". It looks like we don't need to
bring back the overflow check, which would make this change no longer
needed.
Can you have a look and see if you agree?
-Jeff
next prev parent reply other threads:[~2025-10-20 15:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 15:22 [PATCH] accel/qaic: Replace user defined overflow check Youssef Samir
2025-10-15 16:01 ` Carl Vanderlip
2025-10-15 16:42 ` Jeff Hugo
2025-10-17 15:13 ` Falkowski, Maciej
2025-10-20 15:05 ` Jeff Hugo [this message]
2025-10-21 16:03 ` Youssef Abdulrahman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4367373-a0a4-4876-bec0-d8a560244c40@oss.qualcomm.com \
--to=jeff.hugo@oss.qualcomm.com \
--cc=carl.vanderlip@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=karol.wachowski@linux.intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=lizhi.hou@amd.com \
--cc=ogabbay@kernel.org \
--cc=troy.hanson@oss.qualcomm.com \
--cc=youssef.abdulrahman@oss.qualcomm.com \
--cc=zachary.mckevitt@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox