From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Jianhua Lu <lujianhua000@gmail.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: linux@roeck-us.net, heikki.krogerus@linux.intel.com,
gregkh@linuxfoundation.org, andersson@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
luca.weiss@fairphone.com, linux-usb@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
caleb.connolly@linaro.org, konrad.dybcio@linaro.org,
subbaram@quicinc.com, jackp@quicinc.com,
robertom@qti.qualcomm.com
Subject: Re: [PATCH v6 13/13] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM orientation-switch for usb_1_qmpphy
Date: Mon, 1 May 2023 18:04:04 +0100 [thread overview]
Message-ID: <a43cadd1-05fe-33de-60cc-09064bd068d1@linaro.org> (raw)
In-Reply-To: <ZE_cr5X3UNKObsXd@Gentoo>
On 01/05/2023 16:37, Jianhua Lu wrote:
>> &usb_2 {
>> @@ -1375,6 +1383,12 @@ pm8150b_role_switch_out: endpoint {
>> remote-endpoint = <&dwc3_role_switch_in>;
>> };
>> };
> you should add port@0 for usb_1_hsphy because it is required.
So the yaml doesn't require hs but arguably could be made to be more
flexible to accommodate different hardware realities, like ours here.
>
>> + port@1 {
> Same
Hmm, well actually I think the port should be port@0 here and port@1
should be dropped so, I'll do that.
---
bod
next prev parent reply other threads:[~2023-05-01 17:15 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 12:10 [PATCH v6 00/13] Add Qualcomm PMIC TPCM support Bryan O'Donoghue
2023-05-01 12:10 ` [PATCH v6 01/13] dt-bindings: regulator: qcom,usb-vbus-regulator: Mark reg as required Bryan O'Donoghue
2023-05-01 12:11 ` [PATCH v6 02/13] dt-bindings: regulator: qcom,usb-vbus-regulator: Mark regulator-*-microamp required Bryan O'Donoghue
2023-05-01 12:11 ` [PATCH v6 03/13] dt-bindings: phy: qcom,sc7180-qmp-usb3-dp-phy: Add orientation-switch as optional Bryan O'Donoghue
2023-05-01 12:11 ` [PATCH v6 04/13] dt-bindings: phy: qcom,sc7180-qmp-usb3-dp-phy: Add input and output ports Bryan O'Donoghue
2023-05-02 10:45 ` Krzysztof Kozlowski
2023-05-02 10:51 ` Krzysztof Kozlowski
2023-05-01 12:11 ` [PATCH v6 05/13] dt-bindings: usb: Add Qualcomm PMIC Type-C Bryan O'Donoghue
2023-05-02 10:56 ` Krzysztof Kozlowski
2023-05-01 12:11 ` [PATCH v6 06/13] dt-bindings: mfd: qcom,spmi-pmic: Add typec to SPMI device types Bryan O'Donoghue
2023-05-01 12:11 ` [PATCH v6 07/13] usb: typec: qcom: Add Qualcomm PMIC Type-C driver Bryan O'Donoghue
2023-05-01 13:31 ` Guenter Roeck
2023-05-01 17:50 ` Caleb Connolly
2023-05-01 12:11 ` [PATCH v6 08/13] arm64: dts: qcom: sm8250: Define ports for qmpphy orientation-switching Bryan O'Donoghue
2023-05-02 11:01 ` Konrad Dybcio
2023-05-01 12:11 ` [PATCH v6 09/13] arm64: dts: qcom: pm8150b: Add a TCPM description Bryan O'Donoghue
2023-05-01 12:11 ` [PATCH v6 10/13] arm64: dts: qcom: qrb5165-rb5: Switch on Type-C VBUS boost Bryan O'Donoghue
2023-05-02 10:56 ` Konrad Dybcio
2023-05-01 12:11 ` [PATCH v6 11/13] arm64: dts: qcom: qrb5165-rb5: Switch on basic TCPM Bryan O'Donoghue
2023-05-01 15:28 ` Jianhua Lu
2023-05-02 10:57 ` Konrad Dybcio
2023-05-01 12:11 ` [PATCH v6 12/13] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM usb-role-switching for usb_1 Bryan O'Donoghue
2023-05-01 15:21 ` Jianhua Lu
2023-05-01 15:53 ` Bryan O'Donoghue
2023-05-01 16:04 ` Jianhua Lu
2023-05-01 15:30 ` Jianhua Lu
2023-05-02 11:00 ` Konrad Dybcio
2023-05-02 11:03 ` Bryan O'Donoghue
2023-05-02 11:13 ` Konrad Dybcio
2023-05-02 11:16 ` Bryan O'Donoghue
2023-05-02 11:47 ` Konrad Dybcio
2023-05-02 12:10 ` Bryan O'Donoghue
2023-05-07 21:09 ` Bryan O'Donoghue
2023-05-01 12:11 ` [PATCH v6 13/13] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM orientation-switch for usb_1_qmpphy Bryan O'Donoghue
2023-05-01 15:34 ` Jianhua Lu
2023-05-01 16:00 ` Bryan O'Donoghue
2023-05-01 15:37 ` Jianhua Lu
2023-05-01 17:04 ` Bryan O'Donoghue [this message]
2023-05-02 11:01 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a43cadd1-05fe-33de-60cc-09064bd068d1@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jackp@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luca.weiss@fairphone.com \
--cc=lujianhua000@gmail.com \
--cc=robertom@qti.qualcomm.com \
--cc=robh+dt@kernel.org \
--cc=subbaram@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox