From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A912C61DA4 for ; Wed, 15 Feb 2023 00:10:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231944AbjBOAKQ (ORCPT ); Tue, 14 Feb 2023 19:10:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231966AbjBOAKP (ORCPT ); Tue, 14 Feb 2023 19:10:15 -0500 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B75BF311C7 for ; Tue, 14 Feb 2023 16:10:05 -0800 (PST) Received: by mail-ej1-x62c.google.com with SMTP id qb15so42121163ejc.1 for ; Tue, 14 Feb 2023 16:10:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8azonh6JuDM6yxIBz+UeUT9A+K1dkd2wXajwtSP1wNo=; b=M81D30xtRjOeLl0/ENzu5hw5o44r66wXeRX9tMqeqWbvV5eTiAz6wRgQsVd4/yn6fe SAKjUk0EPFpyoa8Dvqn3ZvIakxe7sLp0X+nspxQ5cTfv2bidV27zMg6BUMRgSsZlcuuw TBTKWTzkzOJqsKkIc5C5wZDSGyhoyXGFeMz0RnLqa4VU8wgXO8Bd/iaewBWTWFYhhszM qWRWxprx/WJG87+hRrYuXOKHioz/3aXutio53bdNErHWICAYbdDPhYY5+QcqodOBSNjs b1iSINmG4DeIxZnvwm4Z0RhQVVE6oPERfmVh5tunqmLPIQP6j+OyF9f+jxHo04ct4LYM j3PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8azonh6JuDM6yxIBz+UeUT9A+K1dkd2wXajwtSP1wNo=; b=ngGNmRkiAJwlu/zGTBEvBVkrou0wZf0hf0ohXUTk+Ahal8sok4cQ41+F+/q60v/Hh1 Bz9cautYCKduSBuT0s7lbrvkenzxFTZCi4CJkVYQ4hG93H+WlZ7L0F0E8U1k2/JatSPL 2NoX+/WKyzCEaABcd9YCZFH5MMNMzlNOqirKRXd0ejKJH1kIPQBMDFasmsUJpje7FtGU sODY2Yu7caEhhptyfMUq8iY6ZbCeXnDbNnXQGZWSNhnGZi1e3sH/4jZQEDouT5bxOw4E Ov5p4yZBBWFXhQ1+qu6qMvCfrbLRllvYNwHvdDsTjNNkFSUj4INnFJ4suN+C0sNqLunq 1OTg== X-Gm-Message-State: AO0yUKXcdT3GF1QBYtsmE8dfOU+dUXuiUYaONHU/q/H/Liw7H9n0OOfv gbh1EgWl26Jr5mMyzGY+MnCYLM6cuUYsdcOl X-Google-Smtp-Source: AK7set/gKNIqLXNJwW+JD/xwd56nsFrvF97bkqwOd4DklH3lI/hfm72F9UxypL4PvkVMgtm0dKAn9w== X-Received: by 2002:a17:906:9159:b0:866:6b08:946b with SMTP id y25-20020a170906915900b008666b08946bmr254841ejw.39.1676419804292; Tue, 14 Feb 2023 16:10:04 -0800 (PST) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id kg3-20020a17090776e300b0088a2aebb146sm8848566ejc.52.2023.02.14.16.10.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Feb 2023 16:10:03 -0800 (PST) Message-ID: Date: Wed, 15 Feb 2023 02:10:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 10/14] drm/msm/a6xx: Fix up A6XX protected registers Content-Language: en-GB To: Rob Clark , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org, marijn.suijten@somainline.org, Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Akhil P Oommen , Chia-I Wu , Douglas Anderson , Jonathan Marek , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20230214173145.2482651-1-konrad.dybcio@linaro.org> <20230214173145.2482651-11-konrad.dybcio@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 14/02/2023 23:56, Rob Clark wrote: > On Tue, Feb 14, 2023 at 9:32 AM Konrad Dybcio wrote: >> >> One of the protected ranges was too small (compared to the data we >> have downstream). Fix it. >> >> Fixes: 408434036958 ("drm/msm/a6xx: update/fix CP_PROTECT initialization") >> Signed-off-by: Konrad Dybcio >> --- >> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >> index 503c750216e6..d6b38bfdb3b4 100644 >> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >> @@ -690,7 +690,7 @@ static const u32 a6xx_protect[] = { >> A6XX_PROTECT_NORDWR(0x00800, 0x0082), >> A6XX_PROTECT_NORDWR(0x008a0, 0x0008), >> A6XX_PROTECT_NORDWR(0x008ab, 0x0024), >> - A6XX_PROTECT_RDONLY(0x008de, 0x00ae), >> + A6XX_PROTECT_RDONLY(0x008d0, 0x00bc), > > Nak, this is intentional, we need userspace to be able to configure > the CP counters. Otherwise this would break fdperf, perfetto, etc > > (although maybe we should comment where we diverge from downstream) Yes, please. Otherwise it is extremely hard to understand the reason for diversion between the vendor driver and our one. > > BR, > -R > >> A6XX_PROTECT_NORDWR(0x00900, 0x004d), >> A6XX_PROTECT_NORDWR(0x0098d, 0x0272), >> A6XX_PROTECT_NORDWR(0x00e00, 0x0001), >> -- >> 2.39.1 >> -- With best wishes Dmitry