From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanimir Varbanov Subject: Re: [PATCH] media: venus: fix reported size of 0-length buffers Date: Mon, 26 Nov 2018 11:45:46 +0200 Message-ID: References: <20181113093048.236201-1-acourbot@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20181113093048.236201-1-acourbot@chromium.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Alexandre Courbot , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org Hi Alex, Thanks for the patch! On 11/13/18 11:30 AM, Alexandre Courbot wrote: > The last buffer is often signaled by an empty buffer with the > V4L2_BUF_FLAG_LAST flag set. Such buffers were returned with the > bytesused field set to the full size of the OPB, which leads > user-space to believe that the buffer actually contains useful data. Fix > this by passing the number of bytes reported used by the firmware. > > Signed-off-by: Alexandre Courbot > --- > drivers/media/platform/qcom/venus/vdec.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Acked-by: Stanimir Varbanov > > diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c > index 189ec975c6bb..282de21cf2e1 100644 > --- a/drivers/media/platform/qcom/venus/vdec.c > +++ b/drivers/media/platform/qcom/venus/vdec.c > @@ -885,10 +885,8 @@ static void vdec_buf_done(struct venus_inst *inst, unsigned int buf_type, > vbuf->field = V4L2_FIELD_NONE; > > if (type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) { > - unsigned int opb_sz = venus_helper_get_opb_size(inst); > - > vb = &vbuf->vb2_buf; > - vb2_set_plane_payload(vb, 0, bytesused ? : opb_sz); > + vb2_set_plane_payload(vb, 0, bytesused); > vb->planes[0].data_offset = data_offset; > vb->timestamp = timestamp_us * NSEC_PER_USEC; > vbuf->sequence = inst->sequence_cap++; > -- regards, Stan