From: Sergey Ryazanov <ryazanov.s.a@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Jakub Kicinski" <kuba@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Loic Poulain" <loic.poulain@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>
Cc: Andy Gross <agross@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Stephan Gerhold <stephan@gerhold.net>,
Johannes Berg <johannes@sipsolutions.net>,
netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH net-next 08/10] net: wwan: qcom_bam_dmux: Convert to platform remove callback returning void
Date: Thu, 23 Nov 2023 00:23:53 +0200 [thread overview]
Message-ID: <a62e93f0-7d95-41ee-91c1-cbdd316f94d7@gmail.com> (raw)
In-Reply-To: <20231117095922.876489-9-u.kleine-koenig@pengutronix.de>
On 17.11.2023 11:59, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
prev parent reply other threads:[~2023-11-22 22:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 9:59 [PATCH net-next 00/10] net*: Convert to platform remove callback returning void Uwe Kleine-König
2023-11-17 9:59 ` [PATCH net-next 08/10] net: wwan: qcom_bam_dmux: " Uwe Kleine-König
2023-11-22 22:23 ` Sergey Ryazanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a62e93f0-7d95-41ee-91c1-cbdd316f94d7@gmail.com \
--to=ryazanov.s.a@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=kernel@pengutronix.de \
--cc=konrad.dybcio@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephan@gerhold.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox