From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85F03334688 for ; Fri, 6 Mar 2026 05:54:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772776468; cv=none; b=D1s+sF5sEbk2dTqwMc9hjkzLSdc1LuU2wSlW5Tvl9xoJDe3xJ/eJwCbmU6rGyrmR6jXJiQPzfS9jXRY4S8MrSMfqWST1SUE042Fbe7KlxV5xZBUV68AMyODrjPA3losCueCBTwl8ylRbQLTZPu/0eMs8QZdWCaFrohLyEYgAqiQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772776468; c=relaxed/simple; bh=1MCBxd8ONA2ZUl2TduqrnVLDK4eXrvcft7zMT1NrBr0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tLsLgudXViOv7trsOwe8qvoPHff1bZ/RRHL7d6tz/fUrwM+wa3uKdG5K8vLgCITU2gw/qVO6bAgijyWyjvyy9W4anrw80FvBnkV1771ycrhRf6yVO/20hCYjHKBSa92c+IaMVGlippKO0lLqSBQqRRMoO4nQ9Fo2okrvsT6q5tc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MY3S1sSR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QAYNA9pg; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MY3S1sSR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QAYNA9pg" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6264aFXL3219036 for ; Fri, 6 Mar 2026 05:54:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QchZutdopGk7w2wn9deKlArVUAYhCfHgl2W9GAhcmFE=; b=MY3S1sSRejsUE7Al QFUg53eSFcZ0Ic0TojdBWidN3MJAmab0f5Eeqwu5evtgW+3RoVGfzgSFOVsel02F z7tZq3nwPWY3LMaKLua0bMz7+kZWS3xBRA34GHQGLpFXCC1wXsMsg2oJ+x53/FHm yi+fyXWg78dYRiAjJHbqvR9rtTfi6c4eFsPtN7FV0PqXJQuM+UvBLIJPE5TQM1zW WT4B5igPFPSmQ4R05mtLXGavmyighqBCzmdS+TDg41OssJ6NKHpAa+8z6sDBVppm 08k19YLxR4jxz2cMA+iyrDxqUt4OUjY4i3cZ+YGUQoo8CcdYmn4kANJpdf3Q86wh zYqgcA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqf25suk1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 05:54:25 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2ae50463d18so48206905ad.1 for ; Thu, 05 Mar 2026 21:54:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772776465; x=1773381265; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QchZutdopGk7w2wn9deKlArVUAYhCfHgl2W9GAhcmFE=; b=QAYNA9pg1dJDriC+Qf1N+bq/RaKLI2D39mFVkC/ZC57ZGN8AtYJbFxqlUCZPrXYfXK epDhLDlCK0lyhe8vGZBqR0E//i25XOn5IyivV4YpklIreLT9YLQ5NGGPceHKYHPFbHp3 VJcDWhkKu7IG6YCtObqisRgQPsNSoCmrTtD+rx0vvyvetpq7k87xF5Jwv0b+js4Ojegf nvZuswlY4rNsiWVeopBj1AHv7wkDVyolZUAWZalkLN/z1ulr9KWTltHZdtwCR2Hc5niY vxXwZqLU8Z2dY4Y2K5MiMnQtKpAnndFxK+Z009m4zspTakoTjVFNMxLoTbBr8bHvfPNF Pozw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772776465; x=1773381265; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QchZutdopGk7w2wn9deKlArVUAYhCfHgl2W9GAhcmFE=; b=BaAcgs6U1sLi/SU/17+WYdAyohcyRy2DacwVD5bkbRcbgVGMvxoRYiODJivyiMkvQZ GXFcolPE5QZvkvY9i0WoMMrtvhY2Hi8RKhktJcNgz53vN7wJ29blS26ZJMsptfBR+uyH iW6vSc4pKkm0mFDGn+hBYd3R3RrSICHa57Zl65oolbC9ILnJj60RL3rBm0AlGZniAhbF 1JpUkSObQmly2AQl+gG2IZB7YEy4c4YGVNDtyy+OqIAuFUPUsn0L0Q2NlD3O4yMyPKxc w7mBVqYEBvcfFM2V2TxXw3v8M7MGq+Qj/rYfRKui9KvS2/jZWrwR9WyFyeuj/Lw3v4fc 9gYg== X-Forwarded-Encrypted: i=1; AJvYcCVS3MAKqEfAwTl4oItQIGqDVprE1DxiYLJHuJ/Bnc3tu0WyPTq625Pgdnr2jznnZN5DW1MRzGXy2fA0Wysi@vger.kernel.org X-Gm-Message-State: AOJu0Yyu930UIRQ/DxS+15fL0mE8zHYh+r2DzrRzQ74ycdFzW0YNqAyn 1Ie2yUwkhFLu1hAG+U0T9V8oCqAkSF1QBUKMYx9BpYNgxHLGW2q7ULbiezqUfzdHPZoP53BQsZr m6ujDzzvIoxZuiJQV2GPTzKy1IxhnAm8OJeY69/jLWnbMgaFACJ21fwiosS7xY7Mv0nB1 X-Gm-Gg: ATEYQzyXi0VfyIPleiwnFNogR6j+aseqfridimL1iHf1kYZHZrDU4a0dN6h6wsKX3T9 RV6kTUPHcX5r8cnKmTMjvEFf7iDuBb0iHuJY71cVaNE/RtrXzAbcCbI54fl+YFajp4J2fqMrnH6 LlnXanzYY5UjkfpBHrlddqUpiECSD2vVWCUdHi9f6AtglB/f5mLhKbb4wmUc72/FK9HkL2pPkb9 OmUF+l2YtEgMXUM185iafZSU6Sg8lmwvcWmSgcdOHaNi8GfGhBjUTH1c3m9h5Qraqnqm8coIno4 hsLvq/6ajIimltimcQReMl7j+ZJ1IU7DdyDqpJWM3yE8S5BSBnH8RMcV2lan/iw16AOqeHUer/L vx18YotQMCkzGzic4KoyXB6ytMs9rynDf07943/0+T2XfHn/s4v1uOw== X-Received: by 2002:a17:903:3bac:b0:2ae:4ac7:bcb9 with SMTP id d9443c01a7336-2ae75b49d80mr42893245ad.9.1772776465089; Thu, 05 Mar 2026 21:54:25 -0800 (PST) X-Received: by 2002:a17:903:3bac:b0:2ae:4ac7:bcb9 with SMTP id d9443c01a7336-2ae75b49d80mr42892995ad.9.1772776464613; Thu, 05 Mar 2026 21:54:24 -0800 (PST) Received: from [10.0.0.3] ([106.222.231.181]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae840adb42sm7652355ad.81.2026.03.05.21.54.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Mar 2026 21:54:24 -0800 (PST) Message-ID: Date: Fri, 6 Mar 2026 11:24:20 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 02/11] media: qcom: iris: extract common set_preset_registers function Content-Language: en-US To: Dmitry Baryshkov , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260228-iris-platform-data-v2-0-acf036a3c84c@oss.qualcomm.com> <20260228-iris-platform-data-v2-2-acf036a3c84c@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260228-iris-platform-data-v2-2-acf036a3c84c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: JDCc5HuPnWHKYpFoZjiqnGsPp86Miulh X-Authority-Analysis: v=2.4 cv=Uvdu9uwB c=1 sm=1 tr=0 ts=69aa6c11 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=IrIcjQS8YOhLhDNCWt0oYA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=iAAPGlyahXlDWQVVwjIA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDA1MiBTYWx0ZWRfXxZ2ToRrwUo14 prGk7i004BGAj/9m4nwWniyeLVcAeOMDOUPPxZ0KGayYQx/g0GM/IzRjlB5/trcCHHO/ex2wCog Q/Sqn00590gj0yC0UdYRnDnLwiJKP8zX+wnc9I0S6XU99VX99RtubxL7ciRaa3cJlu0Yx0Ue7up PErjPDN71lLPhzCXjrOb0XzAHvoGfkaoh0rg4RQLSnn5pxvrbeqOUIwNem2xyrjzdvkKvmQ8ttq 69aDHjuiuv9fvnOh0i8Up0j+54108A6XXkpA7Juevyl5nrFOGFnXByPonYL6zEi13tfwSFMZADG b5TYojU67rlBh7jI5ucdegfkueftgVCsdSNAoad09VYHmZ6wfST0ZQTa6Xk9oS69JFCP15gqSHv 9IBQJ6DQbSHrbLrQ0L4B0NOZ099GDldrnF/Ndkg4SHFCH/R7Ur2My3Kw7T/k24hVQeIh4dqeWQ8 CSMytJtvKxnPJ0dJMDw== X-Proofpoint-GUID: JDCc5HuPnWHKYpFoZjiqnGsPp86Miulh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_02,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 malwarescore=0 spamscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060052 On 2/28/2026 8:56 PM, Dmitry Baryshkov wrote: > The set_preset_registers is (currently) common to all supported devices. > Extract it to a iris_vpu_common.c > Then it can be removed from platform data and can be called directly since as of now its common for all supported devices, this can change for a different VPU variant eg: AR50LT and at that time it can be changed to vpu ops. Thanks, Dikshita > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/iris_platform_gen1.c | 9 ++------- > drivers/media/platform/qcom/iris/iris_platform_gen2.c | 13 ++++--------- > drivers/media/platform/qcom/iris/iris_vpu_common.c | 5 +++++ > drivers/media/platform/qcom/iris/iris_vpu_common.h | 2 ++ > 4 files changed, 13 insertions(+), 16 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen1.c b/drivers/media/platform/qcom/iris/iris_platform_gen1.c > index 1bbdefc48d71..a3eebcacba7b 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_gen1.c > +++ b/drivers/media/platform/qcom/iris/iris_platform_gen1.c > @@ -260,11 +260,6 @@ static struct platform_inst_caps platform_inst_cap_sm8250 = { > .max_operating_rate = MAXIMUM_FPS, > }; > > -static void iris_set_sm8250_preset_registers(struct iris_core *core) > -{ > - writel(0x0, core->reg_base + 0xB0088); > -} > - > static const struct icc_info sm8250_icc_table[] = { > { "cpu-cfg", 1000, 1000 }, > { "video-mem", 1000, 15000000 }, > @@ -343,7 +338,7 @@ const struct iris_platform_data sm8250_data = { > .init_hfi_response_ops = iris_hfi_gen1_response_ops_init, > .get_vpu_buffer_size = iris_vpu_buf_size, > .vpu_ops = &iris_vpu2_ops, > - .set_preset_registers = iris_set_sm8250_preset_registers, > + .set_preset_registers = iris_vpu_set_preset_registers, > .icc_tbl = sm8250_icc_table, > .icc_tbl_size = ARRAY_SIZE(sm8250_icc_table), > .clk_rst_tbl = sm8250_clk_reset_table, > @@ -397,7 +392,7 @@ const struct iris_platform_data sc7280_data = { > .init_hfi_response_ops = iris_hfi_gen1_response_ops_init, > .get_vpu_buffer_size = iris_vpu_buf_size, > .vpu_ops = &iris_vpu2_ops, > - .set_preset_registers = iris_set_sm8250_preset_registers, > + .set_preset_registers = iris_vpu_set_preset_registers, > .icc_tbl = sm8250_icc_table, > .icc_tbl_size = ARRAY_SIZE(sm8250_icc_table), > .bw_tbl_dec = sc7280_bw_table_dec, > diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > index 1f23ddb972f0..f8754451ac18 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c > +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > @@ -756,11 +756,6 @@ static struct platform_inst_caps platform_inst_cap_sm8550 = { > .max_operating_rate = MAXIMUM_FPS, > }; > > -static void iris_set_sm8550_preset_registers(struct iris_core *core) > -{ > - writel(0x0, core->reg_base + 0xB0088); > -} > - > static const struct icc_info sm8550_icc_table[] = { > { "cpu-cfg", 1000, 1000 }, > { "video-mem", 1000, 15000000 }, > @@ -917,7 +912,7 @@ const struct iris_platform_data sm8550_data = { > .init_hfi_response_ops = iris_hfi_gen2_response_ops_init, > .get_vpu_buffer_size = iris_vpu_buf_size, > .vpu_ops = &iris_vpu3_ops, > - .set_preset_registers = iris_set_sm8550_preset_registers, > + .set_preset_registers = iris_vpu_set_preset_registers, > .icc_tbl = sm8550_icc_table, > .icc_tbl_size = ARRAY_SIZE(sm8550_icc_table), > .clk_rst_tbl = sm8550_clk_reset_table, > @@ -1018,7 +1013,7 @@ const struct iris_platform_data sm8650_data = { > .init_hfi_response_ops = iris_hfi_gen2_response_ops_init, > .get_vpu_buffer_size = iris_vpu33_buf_size, > .vpu_ops = &iris_vpu33_ops, > - .set_preset_registers = iris_set_sm8550_preset_registers, > + .set_preset_registers = iris_vpu_set_preset_registers, > .icc_tbl = sm8550_icc_table, > .icc_tbl_size = ARRAY_SIZE(sm8550_icc_table), > .clk_rst_tbl = sm8650_clk_reset_table, > @@ -1114,7 +1109,7 @@ const struct iris_platform_data sm8750_data = { > .init_hfi_response_ops = iris_hfi_gen2_response_ops_init, > .get_vpu_buffer_size = iris_vpu33_buf_size, > .vpu_ops = &iris_vpu35_ops, > - .set_preset_registers = iris_set_sm8550_preset_registers, > + .set_preset_registers = iris_vpu_set_preset_registers, > .icc_tbl = sm8550_icc_table, > .icc_tbl_size = ARRAY_SIZE(sm8550_icc_table), > .clk_rst_tbl = sm8750_clk_reset_table, > @@ -1212,7 +1207,7 @@ const struct iris_platform_data qcs8300_data = { > .init_hfi_response_ops = iris_hfi_gen2_response_ops_init, > .get_vpu_buffer_size = iris_vpu_buf_size, > .vpu_ops = &iris_vpu3_ops, > - .set_preset_registers = iris_set_sm8550_preset_registers, > + .set_preset_registers = iris_vpu_set_preset_registers, > .icc_tbl = sm8550_icc_table, > .icc_tbl_size = ARRAY_SIZE(sm8550_icc_table), > .clk_rst_tbl = sm8550_clk_reset_table, > diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.c b/drivers/media/platform/qcom/iris/iris_vpu_common.c > index 548e5f1727fd..e07e47dc9977 100644 > --- a/drivers/media/platform/qcom/iris/iris_vpu_common.c > +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c > @@ -485,3 +485,8 @@ int iris_vpu_power_on(struct iris_core *core) > > return ret; > } > + > +void iris_vpu_set_preset_registers(struct iris_core *core) > +{ > + writel(0x0, core->reg_base + 0xb0088); > +} > diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.h b/drivers/media/platform/qcom/iris/iris_vpu_common.h > index f6dffc613b82..07728c4c72b6 100644 > --- a/drivers/media/platform/qcom/iris/iris_vpu_common.h > +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.h > @@ -39,4 +39,6 @@ int iris_vpu35_vpu4x_power_on_controller(struct iris_core *core); > void iris_vpu35_vpu4x_program_bootup_registers(struct iris_core *core); > u64 iris_vpu3x_vpu4x_calculate_frequency(struct iris_inst *inst, size_t data_size); > > +void iris_vpu_set_preset_registers(struct iris_core *core); > + > #endif >