From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CCBFC433EF for ; Sat, 26 Feb 2022 23:38:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229471AbiBZXjA (ORCPT ); Sat, 26 Feb 2022 18:39:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbiBZXi7 (ORCPT ); Sat, 26 Feb 2022 18:38:59 -0500 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AE8223EE59 for ; Sat, 26 Feb 2022 15:38:24 -0800 (PST) Received: by mail-lj1-x22b.google.com with SMTP id f11so12335756ljq.11 for ; Sat, 26 Feb 2022 15:38:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=L77jjy3Pjb6haSmnZfnNmFgIofaBblWDltlBIh2LtP8=; b=ksCenEYJQP77iJl3VqiJjoJeFeq1I9QMUm9fBePnf75SO+2P4R5mUgZ2dv3tKUFnuu gar7ZtWVt828sugg+VnjuYXnlA7qzZVyxJ/2Fc+Wjuq4KHtxJ0pKzrAByvjmsM6JlnqZ o3WODvJDdShjW1l2b8nEOAU6Jfe/fzCXXKDuCF6N6sA1IHoRNmPLjt+RqDAg2H5bf3tY LCjY63dHcBz2Zl5OxOMr0PeQmKwW2ry49C2tXCnEXCRwy7A7FgqnlQ8YOxCxkHfhq120 2UqBGKjlKA8KKmGeZBCTcW2qvmwr3Heq5LdFUYauq5193lbCmssb9S8fYYA5VgSjT+Lu bCcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=L77jjy3Pjb6haSmnZfnNmFgIofaBblWDltlBIh2LtP8=; b=QKwzWkll+JVnA/KmJasP1AYfvU7bJS1/rWp0YMGTisw+52EQ8Qe/dTf2uYKCdT6U5Q NZZJTr4Q3juPmly1ttwBLDxIrp33YtsIhEdWBXMFiSOO5EueNhJj0lh58ikhsXzO7qv7 UDoG0SZG7zVYo7s7DAAX2lfyF/xexLHDK/EDb2YIUO5cG3R99KNGDI9guSDSCIDz6EYL 7EQcaBWLvUXyM2/jnGnD8FwdizY3cZ687USjnEBgA/RqZvNno5KZ6PVHGsfYQTUqqS1f /X1TbnEb2gAPLHPGRLHPy20ZfZGrV+6Od+qkIqpo3/L2ULlb1Ccl8NEb6ZcGRu63P6kr 5vsg== X-Gm-Message-State: AOAM53261YSXlJrHW7Dm7qBAuZhYKPycKur3TVXnwovWmb/RbYPsAo+D yDLG8hAgk4cjlXE6jTzZH+dFTA== X-Google-Smtp-Source: ABdhPJzI6jlwWxLLswkwolfMTDkejgzveyClOap+Ur9bxPwPT/5fOg85P4oWWg1y+wDGzOu5nl5a9A== X-Received: by 2002:a2e:7007:0:b0:246:2b76:31a with SMTP id l7-20020a2e7007000000b002462b76031amr9992267ljc.397.1645918702617; Sat, 26 Feb 2022 15:38:22 -0800 (PST) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id b3-20020ac25623000000b004435fb1f5basm550208lff.78.2022.02.26.15.38.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Feb 2022 15:38:22 -0800 (PST) Message-ID: Date: Sun, 27 Feb 2022 02:38:21 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH 1/2] dt-bindings: phy: qcom,qmp: Mark '#clock-cells' as a 'optional' property Content-Language: en-GB To: Bhupesh Sharma Cc: linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com, agross@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, robh+dt@kernel.org, Bjorn Andersson , Vinod Koul References: <20220224123248.67073-1-bhupesh.sharma@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 25/02/2022 12:16, Bhupesh Sharma wrote: > Hi Dmitry, > > Thanks for your review comments. > > On Thu, 24 Feb 2022 at 20:22, Dmitry Baryshkov > wrote: >> >> On Thu, 24 Feb 2022 at 15:33, Bhupesh Sharma wrote: >>> >>> Since '#clock-cells' is not a required property for several >>> QCoM boards supporting qmp-phy(s) (for e.g. sm8150, sm8250 or sm8350 SoC >>> based boards), mark it as an optional property instead. >> >> I believe the description is not correct. the clock-cells should not >> be used at all, so it should be removed from the root node. > > Hmm.. 'clock-cells' is still used for describing qmp phy pcie nodes for certain > devices like 'msm8996.dtsi'. I am not sure if removing it would impact existing > dts files. But let me try cleaning them up in v2. Checked. Unless I'm mistaken, msm8996.dtsi doesn't use #clock-cells in root QMP PHY nodes. > >> Also we should describe phy@ properties. > > Sure, I will add them in v2. > > Regards, > Bhupesh > >>> >>> This fixes the following '$ make dtbs_check' warning(s): >>> >>> sm8350-microsoft-surface-duo2.dt.yaml: phy@1d87000: >>> '#clock-cells' is a required property >>> >>> Cc: Bjorn Andersson >>> Cc: Vinod Koul >>> Cc: Rob Herring >>> Signed-off-by: Bhupesh Sharma >>> --- >>> Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml >>> index 9e0f60e682c4..746a929c63bb 100644 >>> --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml >>> +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml >>> @@ -115,7 +115,6 @@ patternProperties: >>> required: >>> - compatible >>> - reg >>> - - "#clock-cells" >>> - "#address-cells" >>> - "#size-cells" >>> - ranges >>> -- >>> 2.35.1 >>> >> >> >> -- >> With best wishes >> Dmitry -- With best wishes Dmitry