From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Jie Gan <jie.gan@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Tingwei Zhang <tingwei.zhang@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: glymur: add coresight nodes
Date: Mon, 23 Mar 2026 14:02:29 +0100 [thread overview]
Message-ID: <a73af369-b122-43d2-b28f-e97ab33352c9@oss.qualcomm.com> (raw)
In-Reply-To: <7972211e-d735-4401-ada9-b83c7b96b612@oss.qualcomm.com>
On 3/23/26 1:30 PM, Jie Gan wrote:
>
>
> On 3/23/2026 7:05 PM, Konrad Dybcio wrote:
>> On 3/18/26 12:42 PM, Jie Gan wrote:
>>> Add CoreSight nodes to enable trace paths like TPDM->ETF/STM->ETF.
>>> These devices are part of the AOSS, CDSP, QDSS, PCIe5, TraceNoc and
>>> some small subsystems, such as GCC, IPCC, PMU and so on.
>>>
>>> Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
>>> ---
>>> Changes in V2:
>>> 1. removed two cti devices due to GFX block is down
>>
>> i.e. "because GPU is not yet enabled"?
>
> Yeah, these CTI devices have clock issue for enabling due to the GPU block is not yet enabled.
Do they need the GPU to be online, or a clock from GPU_CC, or
maybe something else?
>>> - cti@11c42000
>>> - cti@11c4b000
>>> 2. changes two TPDM devices to static:
>>> - tpdm-cdsp-cmsr
>>> - tpdm-cdsp-cmsr2
>>
>> They were TPDM instances in v1. What's the reason for the change?
>
> These TPDMs havent clock source for accessing registers. We only need enable its ports to output trace data. So I have changed them to static-TPDM compatible.
The registers are clearly physically there. Are you saying that we
(currently?) can't enable the clock required to access them? Or is
there a design defect that's preventing us from doing so?
Konrad
next prev parent reply other threads:[~2026-03-23 13:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 11:42 [PATCH v2] arm64: dts: qcom: glymur: add coresight nodes Jie Gan
2026-03-23 11:05 ` Konrad Dybcio
2026-03-23 12:30 ` Jie Gan
2026-03-23 13:02 ` Konrad Dybcio [this message]
2026-03-23 13:27 ` Jie Gan
2026-03-23 14:03 ` Bjorn Andersson
2026-03-23 14:09 ` Jie Gan
2026-03-23 14:12 ` Konrad Dybcio
2026-03-23 14:18 ` Jie Gan
2026-03-25 0:59 ` Jie Gan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a73af369-b122-43d2-b28f-e97ab33352c9@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jie.gan@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tingwei.zhang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox