From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7191621CFFD for ; Tue, 23 Dec 2025 02:16:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766456196; cv=none; b=K3eR5Uy6jlDPX6s79/qqEkJlKWNduy3p2ME9Vq2QJuibabEGrzDWA8zmZOR9UbmuumFt5wAS5Ge8ar4ENBLYWkt11DRlSxS53AWKNp/ANFWq75SmWsUSCPtch9KwgpppvDcZiJxtX6PE1OVJgoT8ZKC+iCjjO9wq9De/wEu4mAo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766456196; c=relaxed/simple; bh=HxRjEvF5S+Bn8nhnzL0lUBRx86h41CIniVPwPvbrutE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=P3lfhrnqDS8pePLZgEf3miGjSSKxbCqv3mqSTRITjgnBLCzc9pqAYS/B8ctae4PChxla69O75BhLmIgp3DNH9yaE6vC+TbTYK/v4705Drt19jjjqpnLrMp7A/emuiM/IFtmwTECfhbT3tsXBRM5Ge9l+AWELxMY+KGg+7cgiHPI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=V5n4TvGK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IQPr6tC3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="V5n4TvGK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IQPr6tC3" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BMKEKbS4044452 for ; Tue, 23 Dec 2025 02:16:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BX4kp00cUTIqF2+i+oRIlkTaKl5Y4bXuMsl9PQdcnrA=; b=V5n4TvGKfrx2W/50 QtA4lZwOgutgCnA/1UrPUlpstQ1Nr6FfDFjAGRamQ+t7oOqyKRWYXwJ/3+nmr+za 7ChOErFQ7J1PNYgG7f5pFu5/nWagSTuGUfegR1C1xXQl5hLenSgTGPT5OyPf3vh/ GxPyeF0PunAmjLT+Bvx1YSbfdXIgfgSiKSllAh5V3MhIkP+FhWtxbFZcmgdOCtRr X0rSvKE9cU+QGEn7IZRZFlKeHAXwZXNBwisIZLwYJAnfh7B6uSqNFhMFOJPqpqMt 5cZfXppH1wNWNP2Z1hb8FwDLlnnDjKiSBoF5b9+4OqOxgXXfQwW8NnshwQbNhR7C /hYRaw== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7cuh8r8f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Dec 2025 02:16:34 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8b17194d321so588191985a.0 for ; Mon, 22 Dec 2025 18:16:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766456193; x=1767060993; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BX4kp00cUTIqF2+i+oRIlkTaKl5Y4bXuMsl9PQdcnrA=; b=IQPr6tC3fukXUUmnAOK+VqieriP9ZQjGmJbBvAXZf5uJX2k6bL0OkxQNlNdbSwuszN Vm+S0vMU/A/OiU3ZWj+3n0/8l71hSBNKEforXUFDoiStE5fbMphCmJwdigA6p8T3ZL46 dFddJcRx0/ZIeEAN/GjnyOZSDgXrKTngcpw48OAi2mtjUZFE3zWjuJ/fIO0La6B9RZUe OL3hHABw4UG9mXD8pw1kqiv6h3Akem64wuDQvEUE9sG4EAw5miIwZ8paDlAtFt/93M5A zDJjCjsYvCJ1LqYXxKJaPk948v/SmVPten88BPJNznRPDosogicqF63dgnfkSIo2dvsx 7QOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766456193; x=1767060993; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BX4kp00cUTIqF2+i+oRIlkTaKl5Y4bXuMsl9PQdcnrA=; b=Db4Iv2GfG+3vnzb2MYDjMO5axKpMhIhdJAHvofuZ3BHD2bKbix+VlJ+jvOSMVHFLJI t/xRtufdxUQ1iEevoRQ6ZzbASqpEfuFnT/WdOxrsqcA0XStJvszew3F7PRX8ks0ytaZO j3NiT4qOas/NHzP5jiXYft30NRYOcK+B36X0DsmA59P9r0vRUZRQzQVtTjiaduWCOwzD Pl+6qE/TMnBrD9a7/zalL4u5GXPskNpAuTM8SOEpvQ1YQNjiwQuz1W/Tvq4+yIlCigY5 hO8++MGzc4bfeBnh4/ra0OLzCEwDi+HlBhQZWKHagNgJwGIlDwcHFaIvkQL5OOFaS495 4emA== X-Gm-Message-State: AOJu0YxO3Mzj+Cy8hYPxIotY8LcIxd49xhhLP7icSccQT9cOTKX3JXSS plNQjkc8m1bzhHD6O6Td9Sx8VhznmoUOJUGOv8MbhPDb8oVQUjM61d5egmyvFzP5TZWJ+hS+ui/ FKZmrxxa4nKsIhYFDJhQ2fhPPFvggV3pn5oP4piN4o3xA9gjVVP+NMQWrnNniJ2+d89L4 X-Gm-Gg: AY/fxX516cf0mVlh2GOl0tJSTzOX+3R4IkvVKyZwvTN/Gb72q2W2f9QIGayWajrD0+h l81OSdafrF0M9bc4tQ2QyHw9lrhalffNARsRSh89oFHi6TS92GKe/HFVX64Qr9PlB+TGIlFOa9J P268EwwcYhgjtUH2ZYsA8xxZU371rESRyzeJe3o58bzlPxazwVBa4XIAOzFNh/5lb3LtdTUPXx7 1bb+mEAFvNeyuH6R4I6khVQKMM9DAF33dYUDsRSjFjA913uYkrV0Emr56tTv3aujhtMeYIDqGyC cMLUY/+DiWnl7KPqMNHySokoUR05CikoIh4hadnPyayvCKul/eU2AkHcoVrb5Zhti5+05wLwQDy ECKedCCCI8Uk15QCKj+o6XZnQLpQA/PmHeazLdTAJN8KxpFyEFKUCVSQVnVCTNaeUhfIVg3GY X-Received: by 2002:a05:620a:46a2:b0:8b4:3ea8:b30e with SMTP id af79cd13be357-8c08fd27810mr2018995185a.46.1766456193560; Mon, 22 Dec 2025 18:16:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IFqmopzBn8u2ezviYQp0qX7PRJlQCatO8SpKZPJ+5gMcp5GLL0l9H2hCgGmEX3VBIdmbU0FCw== X-Received: by 2002:a05:620a:46a2:b0:8b4:3ea8:b30e with SMTP id af79cd13be357-8c08fd27810mr2018992685a.46.1766456193092; Mon, 22 Dec 2025 18:16:33 -0800 (PST) Received: from [10.38.247.176] (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-88d9623fdd8sm93756866d6.4.2025.12.22.18.16.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Dec 2025 18:16:32 -0800 (PST) Message-ID: Date: Tue, 23 Dec 2025 10:16:25 +0800 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: qcom: talos-evk-camera: Add DT overlay To: Vladimir Zapolskiy , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Bryan O'Donoghue Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org References: <20251222-sm6150_evk-v1-0-4d260a31c00d@oss.qualcomm.com> <20251222-sm6150_evk-v1-3-4d260a31c00d@oss.qualcomm.com> <703a502c-883d-434a-8bcf-f785080f5102@oss.qualcomm.com> <091b863b-fa0a-4d3c-8461-60cdc4970992@linaro.org> Content-Language: en-US From: Wenmeng Liu In-Reply-To: <091b863b-fa0a-4d3c-8461-60cdc4970992@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: saqwws6qgfVwoY6RKE5VjFi59ugDAe1c X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjIzMDAxNyBTYWx0ZWRfXwk/0obyxn3a+ fWuymLThS4iwQiiUUO8iaAAxegFS6r+OksNpkkXUPqcg8p1tZ0NInu1CHyXt8uGq8JLoL3cFhQx UjFTUV9FWl3OTUaRLmqxCAYx/JLiYDx9u5YCZR7225co1H6bNkfEcbgWiGrG816GXY9D+GF85g6 Dm1OSPyNbYcxSdyRwXpxratYbb2yhZhl6GoqgYRslVL61QtXuFRv1DsX3SLvJFOzGGVJErSn+Qv Q429VuLSaKI02RRqnfTZwvy57+aj8w+Vte4lr8Ghz7BUDjAwCTmW/xbRcUT4tbJ/zVmuzvUvR1t CDUHniO6+tJX0dAP+ClGLkJN0shJ45XR6W+g2NXeiu4ZO0cq5kFCzBSkl0nh2BJ20KAwADAc9wR rh+dTAi2JZl9y64dv+IS5rGfbI0urRqT0K1TE+NZYQrloFqGgyqIjMCqgrG7L1EEelgZCgX2+GB LPAUq6NIQ7MBoRaWppA== X-Proofpoint-GUID: saqwws6qgfVwoY6RKE5VjFi59ugDAe1c X-Authority-Analysis: v=2.4 cv=NZDrFmD4 c=1 sm=1 tr=0 ts=6949fb82 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=kW7qbXk8jYSkC2qDlpcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-22_04,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 clxscore=1015 impostorscore=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512230017 On 12/22/2025 11:45 PM, Vladimir Zapolskiy wrote: > On 12/22/25 13:41, Wenmeng Liu wrote: >> >> >> On 12/22/2025 7:19 PM, Vladimir Zapolskiy wrote: >>> On 12/22/25 10:44, Wenmeng Liu wrote: >>>> Enable IMX577 via CCI on Taloss EVK Core Kit. >>>> >>>> The Talos EVK board does not include a camera sensor >>>> by default, this overlay reflects the possibility of >>>> attaching an optional camera sensor. >>>> For this reason, the camera sensor configuration is >>>> placed in talos-evk-camera.dtso, rather than >>>> modifying the base talos-evk.dts. >>>> >>>> Signed-off-by: Wenmeng Liu >>>> --- >>>>    arch/arm64/boot/dts/qcom/Makefile              |  2 + >>>>    arch/arm64/boot/dts/qcom/talos-evk-camera.dtso | 64 ++++++++++++++++ >>>> ++++++++++ >>>>    arch/arm64/boot/dts/qcom/talos.dtsi            | 21 +++++++++ >>> >>> Please split QCS615 MCLK definitions change into a separate commit. >> ACK.> >>>>    3 files changed, 87 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/ >>>> qcom/Makefile >>>> index >>>> 60121f133078b2754f98e6f45a3db4031b478cc8..b1d85b1f4a94714f2a5c976d162482d70ae920f2 100644 >>>> --- a/arch/arm64/boot/dts/qcom/Makefile >>>> +++ b/arch/arm64/boot/dts/qcom/Makefile >>>> @@ -325,7 +325,9 @@ dtb-$(CONFIG_ARCH_QCOM)    += sm8650-qrd.dtb >>>>    dtb-$(CONFIG_ARCH_QCOM)    += sm8750-mtp.dtb >>>>    dtb-$(CONFIG_ARCH_QCOM)    += sm8750-qrd.dtb >>>>    dtb-$(CONFIG_ARCH_QCOM)    += talos-evk.dtb >>>> +talos-evk-camera-dtbs        := talos-evk.dtb talos-evk-camera.dtbo >>>>    talos-evk-lvds-auo,g133han01-dtbs    := talos-evk.dtb talos-evk- >>>> lvds-auo,g133han01.dtbo >>>> +dtb-$(CONFIG_ARCH_QCOM)    += talos-evk-camera.dtb >>>>    dtb-$(CONFIG_ARCH_QCOM)    += talos-evk-lvds-auo,g133han01.dtb >>>>    x1e001de-devkit-el2-dtbs    := x1e001de-devkit.dtb x1-el2.dtbo >>>>    dtb-$(CONFIG_ARCH_QCOM)    += x1e001de-devkit.dtb x1e001de-devkit- >>>> el2.dtb >>>> diff --git a/arch/arm64/boot/dts/qcom/talos-evk-camera.dtso b/arch/ >>>> arm64/boot/dts/qcom/talos-evk-camera.dtso >>>> new file mode 100644 >>>> index >>>> 0000000000000000000000000000000000000000..ae1a02295b4dc48212aad40980a329ff458fe69a >>>> --- /dev/null >>>> +++ b/arch/arm64/boot/dts/qcom/talos-evk-camera.dtso >>>> @@ -0,0 +1,64 @@ >>>> +// SPDX-License-Identifier: BSD-3-Clause >>>> +/* >>>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >>> >>> Please add a missing year of the change. >> Now our requirement is a yearless copyright.> > > Ack. It's a lawyers' domain anyway. > >>>> + */ >>>> + >>>> +/dts-v1/; >>>> +/plugin/; >>>> + >>>> +#include >>>> +#include >>>> + >>>> +&camss { >>>> +    vdd-csiphy-1p2-supply = <&vreg_l11a>; >>>> +    vdd-csiphy-1p8-supply = <&vreg_l12a>; >>>> + >>>> +    status = "okay"; >>>> + >>>> +    ports { >>>> +        #address-cells = <1>; >>>> +        #size-cells = <0>; >>>> + >>>> +        port@1 { >>>> +            reg = <1>; >>>> + >>>> +            csiphy1_ep: endpoint { >>>> +                clock-lanes = <7>; >>> >>> Please remove 'clock-lanes' property. >> ACK.> >>>> +                data-lanes = <0 1 2 3>; >>>> +                remote-endpoint = <&imx577_ep1>; >>>> +            }; >>>> +        }; >>>> +    }; >>>> +}; >>>> + >>>> +&cci { >>>> +    status = "okay"; >>>> +}; >>>> + >>>> +&cci_i2c1 { >>>> +    #address-cells = <1>; >>>> +    #size-cells = <0>; >>>> + >>>> +    camera@1a { >>>> +        compatible = "sony,imx577"; >>>> +        reg = <0x1a>; >>>> + >>>> +        reset-gpios = <&tlmm 29 GPIO_ACTIVE_LOW>; >>>> +        pinctrl-0 = <&cam2_default>; >>>> +        pinctrl-names = "default"; >>>> + >>>> +        clocks = <&camcc CAM_CC_MCLK2_CLK>; >>>> +        assigned-clocks = <&camcc CAM_CC_MCLK2_CLK>; >>>> +        assigned-clock-rates = <24000000>; >>>> + >>>> +        avdd-supply = <&vreg_s4a>; >>> >>> Just one voltage supply? >> yes, 22pin camera module only have one pin for power.> > > It's common that mezzanine boards are supplied with power from S4A or VBAT, > I've never seen a camera module supplied with just one voltage regulator, > that's why it attracts attention. > > What is a camera module here, is it on an attachable vision mezzanine like > on RBx series or a part of Talos EVK PCB like on QRD series? > > If it is a mezzanine, the support of mezzanine boards should be done as > a DT overlay. > It`s like RBx series, does not include a camera sensor by default. Thanks, Wenmeng