From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gax-c <zichenxie0106@gmail.com>,
srinivas.kandagatla@linaro.org, lgirdwood@gmail.com,
broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
rohitkr@codeaurora.org
Cc: alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Zijie Zhao <zzjas98@gmail.com>,
Chenyuan Yang <chenyuan0y@gmail.com>
Subject: Re: [PATCH] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()
Date: Tue, 1 Oct 2024 21:45:27 +0200 [thread overview]
Message-ID: <a78e1fa4-3e13-466e-a0ae-04912e90c09a@kernel.org> (raw)
In-Reply-To: <20241001002409.11989-1-zichenxie0106@gmail.com>
On 01/10/2024 02:24, Gax-c wrote:
> A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could possibly return NULL pointer.
> NULL Pointer Dereference may be triggerred without addtional check.
> Add a NULL check for the returned pointer.
>
> Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers")
> Signed-off-by: Zichen Xie <zichenxie0106@gmail.com>
> Reported-by: Zichen Xie <zichenxie0106@gmail.com>
> Reported-by: Zijie Zhao <zzjas98@gmail.com>
> Reported-by: Chenyuan Yang <chenyuan0y@gmail.com>
Commit still needs improvements.
You ignored also Bjorn's review.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-01 19:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 0:24 [PATCH] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe() Gax-c
2024-10-01 19:45 ` Krzysztof Kozlowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-10-01 21:02 Gax-c
2024-10-02 5:47 ` Krzysztof Kozlowski
2024-10-02 16:12 Gax-c
2024-10-03 5:54 ` Greg KH
2024-10-03 15:27 ` Gax-c
2024-10-05 15:40 ` Markus Elfring
2024-10-06 8:29 ` Greg Kroah-Hartman
2024-10-06 8:56 ` Markus Elfring
2024-10-06 10:08 ` Greg Kroah-Hartman
2024-10-06 20:23 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a78e1fa4-3e13-466e-a0ae-04912e90c09a@kernel.org \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=chenyuan0y@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rohitkr@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=zichenxie0106@gmail.com \
--cc=zzjas98@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).