From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6344A289E08 for ; Thu, 4 Sep 2025 10:15:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756980936; cv=none; b=qp8Zq4DC6hZLNc1QCj2Vd97rc74BJzrmRGbwrsmqp39UguRDEinO13gzq2AUFdCpJf4CL2s44elmftB1g9mnJvys5q+2KQBR7wr0YoOkaWEvRwKJpkmkFmrx93308NpCWmLcNjaFzNAoSxcopeIdll+BmO3fanhhSjIHtdzO7+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756980936; c=relaxed/simple; bh=02YS+hRybT7AYqzhQAWsNOqiFU614c1kM6JJq7QCT0Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IcxlQZBKT16ZDqi4Cag55Is88fwF/f4tXBtaye9UOqIhNSu57wM8XxDL5JDWDkQis2IuUbCn3mh7SuaveccEp7XnxEN2URK6a+unuY1eKZSQauIIE7k9Ng6qr/WZ3jZkUM6oeooYANldBbXaoybiIMZA8VpCPDYYTg/Kmzf4l4s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WV+yoPqS; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WV+yoPqS" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3e2055ce973so206236f8f.0 for ; Thu, 04 Sep 2025 03:15:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756980933; x=1757585733; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ITTyrcjLlcY8/CcZ1bPQJZjvz7X9rDFNo6l00OOhKdM=; b=WV+yoPqS60xk0I/piZS1i+p49G2TEReiEaB/x1gL4RFBqnaDX0opfpvFt5QPecLeEl jIqdRyQCaBfHM/jQHLb3Sc4AaJErVNpvGRFu9w0b2OgfimTMOY5gUHB9JCiJwkzeoDdx OG6bxAkSbHF2YNlWVYOGRkxNS2+pIZRnZkmXgLCfDBzziqteIqhJ/hsEZsLGFA4VX8qo UeBs+c1WhDUXX6rJfESsyFgn4ublXrYm2pwpi+NrX3p91fWuw+Q7pN1r0UGUGvrycTrR IduUPP+B709hmBc3Q3QOpFEaapV6RLlHAdyBDqLxAwG1CxUgB5QOVFTmcIEXW9BcZkMy MoPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756980933; x=1757585733; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ITTyrcjLlcY8/CcZ1bPQJZjvz7X9rDFNo6l00OOhKdM=; b=ql7TZjlJvE0gXk1yldSnv1otYmyRb//oNHdaqddqvCR8PpgsYlZz0EQJeSSYW4vgWN z4MtYO3xqFiPe7CTQAwu4B6noWoQhCX97jiugyDpjnDk7GmzJ87c1hfbvNmdC39P0OM0 lvf6lAeb1oVlQ0/+WzYPJD89rEJp+IcK0EWTYJNhxO5v5W7yjGZme0P0pjvLJYeVAcmp xqu3m5jnvziLG3SCGxO7VKH8cevK4A3qjMHA9NdK8athF9H4dVrMqTb2CETDcJDkfZgE S4z9wjz7fqM6T/6uItBxE/msP6FH1vgF9D/6ebIVA4kPoXEqpaG9xcLw+XbcltuBFgc9 EXWg== X-Forwarded-Encrypted: i=1; AJvYcCUzYIyXZVY8JAvnBdFND46eohWVhkz1KgMSR56WBJPoF9YyzeLiUZL1zACFrQHD85Igf+xAbG8LMjOwWisa@vger.kernel.org X-Gm-Message-State: AOJu0YzAwhOOwRVke8Rh93EqX8zPW7vVEE7HPwCzTy2cU3ey65nmeu7r PZMxm2Re1XGt+mUJ5FSqu/97ai6OM89PWd0Qzj4ez9j/CvnFwX5KPCtXcuBAET6j0vI= X-Gm-Gg: ASbGncsNfUaPFAFlotR7jQYvd7kBfXqyzZ4QIcC7PwrujZMq/pMFaLYXSHLNrmtF1kR 6efyiom0fuK++I7wH2nvkRGu2aWn3C/8XVIvoesA5RbK8FI73UPxiaWwv8mDo+jE6G+Nopyw6nQ 8z397yCdOGySuqIpzmRVrg8hIcsxf3D0v2jw1dMI8p7xnA6pxWDfg9zHY+3Ba0xRHbrjhv8I653 rxZ0qNGi8YciAs0cd7jPyCdHSO09JgUFLwz7Y+nEwf0XAfOC1Zmk0UnHmDLMnFutY8+xBIRXn0v GnnO2qmZj8vbLkm/JJpFl5WR6ZnYFrL0RE7K4EfFDaLYNq3Cy3fVW7JqZ6JOqgyPRxrYWPnAxTM z8BBmgvrrmelDbq8qsgimpIALfz0PVAw1GhlFL6H1j56a2dBnImjk0pY7A5jZVZSh+os1KIhbni hlldQWnOkXAsP+wL45v4s= X-Google-Smtp-Source: AGHT+IHN3+S37G8tZIj+/ejyO1j55iGkRMCn39gBM1gwQQqKT5FKmj84TFJBcgmeeHOEkPQvZICy+g== X-Received: by 2002:a05:6000:1449:b0:3df:c5e3:560e with SMTP id ffacd0b85a97d-3dfc5e36062mr2281362f8f.7.1756980932655; Thu, 04 Sep 2025 03:15:32 -0700 (PDT) Received: from [192.168.0.19] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3d21a32dbc5sm24323510f8f.11.2025.09.04.03.15.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Sep 2025 03:15:32 -0700 (PDT) Message-ID: Date: Thu, 4 Sep 2025 11:15:29 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/11] soc: qcom: mdtloader: Add context aware qcom_mdt_pas_load() helper To: Mukesh Ojha Cc: Bjorn Andersson , Konrad Dybcio , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Mathieu Poirier , Abhinav Kumar , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, linux-remoteproc@vger.kernel.org References: <20250819165447.4149674-1-mukesh.ojha@oss.qualcomm.com> <20250819165447.4149674-3-mukesh.ojha@oss.qualcomm.com> <0b4472cb-0c73-4eb8-a360-22b40aae44f5@linaro.org> <20250904095215.ekkhrt5ql65ap74k@hu-mojha-hyd.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20250904095215.ekkhrt5ql65ap74k@hu-mojha-hyd.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04/09/2025 10:52, Mukesh Ojha wrote: >> So is it really the intention of this patch to change the callsites where >> qcom_mdt_pas_load() away from the init version to the no_init version ? >> >> Maybe its a symptom of patch collision but hmm, having a hard time >> cherry-picking this to test. > My intention is to unify all subsystems whether it's remoteproc, video, > or others using Secure PIL, so that they all use the same set of APIs > via context (cxt). > > Like, we first initialize the context, and then use it for other PIL-related > SMC calls such as pas_init, mem_setup, auth_and_reset, or even for the > new rsc_table SMC call. This way, everything is connected, and it > becomes clear which functions need to be called and it will also be > extensible via a small handling for SHMbridge on gunyah absence. Similar > changes would also apply to the MDT loader APIs. > > That's why I asked here after "---" in this patch if this approach is > preferred, I will apply it consistently and eliminate redundant APIs. > > Let me know your thought. For me its a question of digesting the change. Your series says "Add context aware qcom_mdt_pas_load()" but, it does more than add - it changes logic. At a minimum I'd suggest splitting the addition of the function from the changing of the existing logic so that the two could be disambiguated. The other comment I have is, is this change really required to enable pil loading @ EL2 ? You could for example structure this series to implement the changes you need for EL2 - and then have a last patch at the end to make the code "more beautiful" or even a second series to do that. So I'd suggest one of 1. Splitting the addition of the new helper and its use into separate patches in the same series. or 2. Doing the full EL2 conversion and then applying the "make the code look nice" patch last. So that we could for example take 11 of 13 patches or 3. Making the EL2 conversion and the posting a second series with your proposed tidy up Either way for me splicing both the addition and the usage here is a bit hard to parse, especially since I can't seem to find a public SHA where this series cleanly applies. --- bod