From: Neil Armstrong <neil.armstrong@linaro.org>
To: Rob Clark <robdclark@gmail.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8650: setup gpu thermal with higher temperatures
Date: Mon, 6 Jan 2025 10:02:33 +0100 [thread overview]
Message-ID: <a7c8e50c-0884-4315-ae00-9c5d35c2b258@linaro.org> (raw)
In-Reply-To: <CAF6AEGtVFo8BBUeg=UQDTCP=LLRHLc-V1roa=wHECpLm=Mh_gg@mail.gmail.com>
On 03/01/2025 21:00, Rob Clark wrote:
> On Fri, Jan 3, 2025 at 6:38 AM Neil Armstrong <neil.armstrong@linaro.org> wrote:
>>
>> On the SM8650, the dynamic clock and voltage scaling (DCVS) for the GPU
>> is done in an hardware controlled loop by the GPU Management Unit (GMU).
>>
>> Since the GMU does a better job at maintaining the GPUs temperature in an
>> acceptable range by taking in account more parameters like the die
>> characteristics or other internal sensors, it makes no sense to try
>> and reproduce a similar set of constraints with the Linux devfreq thermal
>> core.
>>
>> Instead, set higher temperatures in the GPU trip points corresponding to
>> the temperatures provided by Qualcomm in the dowstream source, which will
>> trigger the devfreq thermal core if the GMU cannot handle the temperature
>> surge, and try our best to avoid reaching the critical temperature trip
>> point which should trigger an inevitable thermal shutdown.
>
> to we need something like this on other recent SoCs, like x1e?
Probably yes, but I don't have physical access to the platorm..
Neil
>
> BR,
> -R
>
>> Fixes: 497624ed5506 ("arm64: dts: qcom: sm8650: Throttle the GPU when overheating")
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/sm8650.dtsi | 48 ++++++++++++++++++------------------
>> 1 file changed, 24 insertions(+), 24 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
>> index 448374a32e07151e35727d92fab77356769aea8a..ddcb57886eb5eac2a70d28e6ad68fc6820b5dcf1 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
>> @@ -6507,19 +6507,19 @@ map0 {
>>
>> trips {
>> gpu0_alert0: trip-point0 {
>> - temperature = <85000>;
>> + temperature = <95000>;
>> hysteresis = <1000>;
>> type = "passive";
>> };
>>
>> trip-point1 {
>> - temperature = <90000>;
>> + temperature = <115000>;
>> hysteresis = <1000>;
>> type = "hot";
>> };
>>
>> trip-point2 {
>> - temperature = <110000>;
>> + temperature = <125000>;
>> hysteresis = <1000>;
>> type = "critical";
>> };
>> @@ -6540,19 +6540,19 @@ map0 {
>>
>> trips {
>> gpu1_alert0: trip-point0 {
>> - temperature = <85000>;
>> + temperature = <95000>;
>> hysteresis = <1000>;
>> type = "passive";
>> };
>>
>> trip-point1 {
>> - temperature = <90000>;
>> + temperature = <115000>;
>> hysteresis = <1000>;
>> type = "hot";
>> };
>>
>> trip-point2 {
>> - temperature = <110000>;
>> + temperature = <125000>;
>> hysteresis = <1000>;
>> type = "critical";
>> };
>> @@ -6573,19 +6573,19 @@ map0 {
>>
>> trips {
>> gpu2_alert0: trip-point0 {
>> - temperature = <85000>;
>> + temperature = <95000>;
>> hysteresis = <1000>;
>> type = "passive";
>> };
>>
>> trip-point1 {
>> - temperature = <90000>;
>> + temperature = <115000>;
>> hysteresis = <1000>;
>> type = "hot";
>> };
>>
>> trip-point2 {
>> - temperature = <110000>;
>> + temperature = <125000>;
>> hysteresis = <1000>;
>> type = "critical";
>> };
>> @@ -6606,19 +6606,19 @@ map0 {
>>
>> trips {
>> gpu3_alert0: trip-point0 {
>> - temperature = <85000>;
>> + temperature = <95000>;
>> hysteresis = <1000>;
>> type = "passive";
>> };
>>
>> trip-point1 {
>> - temperature = <90000>;
>> + temperature = <115000>;
>> hysteresis = <1000>;
>> type = "hot";
>> };
>>
>> trip-point2 {
>> - temperature = <110000>;
>> + temperature = <125000>;
>> hysteresis = <1000>;
>> type = "critical";
>> };
>> @@ -6639,19 +6639,19 @@ map0 {
>>
>> trips {
>> gpu4_alert0: trip-point0 {
>> - temperature = <85000>;
>> + temperature = <95000>;
>> hysteresis = <1000>;
>> type = "passive";
>> };
>>
>> trip-point1 {
>> - temperature = <90000>;
>> + temperature = <115000>;
>> hysteresis = <1000>;
>> type = "hot";
>> };
>>
>> trip-point2 {
>> - temperature = <110000>;
>> + temperature = <125000>;
>> hysteresis = <1000>;
>> type = "critical";
>> };
>> @@ -6672,19 +6672,19 @@ map0 {
>>
>> trips {
>> gpu5_alert0: trip-point0 {
>> - temperature = <85000>;
>> + temperature = <95000>;
>> hysteresis = <1000>;
>> type = "passive";
>> };
>>
>> trip-point1 {
>> - temperature = <90000>;
>> + temperature = <115000>;
>> hysteresis = <1000>;
>> type = "hot";
>> };
>>
>> trip-point2 {
>> - temperature = <110000>;
>> + temperature = <125000>;
>> hysteresis = <1000>;
>> type = "critical";
>> };
>> @@ -6705,19 +6705,19 @@ map0 {
>>
>> trips {
>> gpu6_alert0: trip-point0 {
>> - temperature = <85000>;
>> + temperature = <95000>;
>> hysteresis = <1000>;
>> type = "passive";
>> };
>>
>> trip-point1 {
>> - temperature = <90000>;
>> + temperature = <115000>;
>> hysteresis = <1000>;
>> type = "hot";
>> };
>>
>> trip-point2 {
>> - temperature = <110000>;
>> + temperature = <125000>;
>> hysteresis = <1000>;
>> type = "critical";
>> };
>> @@ -6738,19 +6738,19 @@ map0 {
>>
>> trips {
>> gpu7_alert0: trip-point0 {
>> - temperature = <85000>;
>> + temperature = <95000>;
>> hysteresis = <1000>;
>> type = "passive";
>> };
>>
>> trip-point1 {
>> - temperature = <90000>;
>> + temperature = <115000>;
>> hysteresis = <1000>;
>> type = "hot";
>> };
>>
>> trip-point2 {
>> - temperature = <110000>;
>> + temperature = <125000>;
>> hysteresis = <1000>;
>> type = "critical";
>> };
>>
>> --
>> 2.34.1
>>
>>
next prev parent reply other threads:[~2025-01-06 9:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 14:38 [PATCH 0/2] arm64: dts: qcom: sm8650: rework CPU & GPU thermal zones Neil Armstrong
2025-01-03 14:38 ` [PATCH 1/2] arm64: dts: qcom: sm8650: setup cpu thermal with idle on high temperatures Neil Armstrong
2025-01-06 23:39 ` Bjorn Andersson
2025-01-07 8:13 ` Neil Armstrong
2025-01-08 3:11 ` Bjorn Andersson
2025-01-08 9:15 ` Neil Armstrong
2025-01-09 15:18 ` Konrad Dybcio
2025-01-10 9:41 ` neil.armstrong
2025-01-09 21:01 ` Bjorn Andersson
2025-01-10 9:40 ` Neil Armstrong
2025-01-03 14:38 ` [PATCH 2/2] arm64: dts: qcom: sm8650: setup gpu thermal with higher temperatures Neil Armstrong
2025-01-03 20:00 ` Rob Clark
2025-01-06 9:02 ` Neil Armstrong [this message]
2025-01-03 14:43 ` [PATCH 0/2] arm64: dts: qcom: sm8650: rework CPU & GPU thermal zones Konrad Dybcio
2025-01-03 14:49 ` Neil Armstrong
2025-01-09 15:20 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7c8e50c-0884-4315-ae00-9c5d35c2b258@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox