From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: Fritz Koenig <frkoenig@chromium.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vikash Garodia <vgarodia@codeaurora.org>,
Alexandre Courbot <acourbot@chromium.org>
Subject: Re: [PATCH v2 4/8] venus: helpers: Calculate properly compressed buffer size
Date: Mon, 30 Nov 2020 09:52:20 +0200 [thread overview]
Message-ID: <a7e3e582-93c7-d0e8-41a0-71d89a16fc70@linaro.org> (raw)
In-Reply-To: <CAMfZQbwMwPkQzakC+6aLqCnoHnjEL7ZhSn_WngcycAF0=6MFxg@mail.gmail.com>
On 11/29/20 8:07 AM, Fritz Koenig wrote:
> On Wed, Nov 11, 2020 at 6:38 AM Stanimir Varbanov
> <stanimir.varbanov@linaro.org> wrote:
>>
>> For resolutions below 720p the size of the compressed buffer must
>> be bigger. Correct this by checking the resolution when calculating
>> buffer size and multiply by four.
>
> I'm confused because the commit message doesn't appear to line up with
> the code. It says multiply by four here, but the code has by eight.
Yes, it is confusing. I will correct it in next version.
>
>>
>> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
>> ---
>> drivers/media/platform/qcom/venus/helpers.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c
>> index 688e3e3e8362..490c026b58a3 100644
>> --- a/drivers/media/platform/qcom/venus/helpers.c
>> +++ b/drivers/media/platform/qcom/venus/helpers.c
>> @@ -986,6 +986,8 @@ u32 venus_helper_get_framesz(u32 v4l2_fmt, u32 width, u32 height)
>>
>> if (compressed) {
>> sz = ALIGN(height, 32) * ALIGN(width, 32) * 3 / 2 / 2;
>> + if (width < 1280 || height < 720)
>> + sz *= 8;
>> return ALIGN(sz, SZ_4K);
>> }
>>
>> --
>> 2.17.1
>>
--
regards,
Stan
next prev parent reply other threads:[~2020-11-30 7:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 14:37 [PATCH v2 0/8] Venus stateful encoder compliance Stanimir Varbanov
2020-11-11 14:37 ` [PATCH v2 1/8] venus: hfi: Use correct state in unload resources Stanimir Varbanov
2020-11-29 6:02 ` Fritz Koenig
2020-11-11 14:37 ` [PATCH v2 2/8] venus: helpers: Add a new helper for buffer processing Stanimir Varbanov
2020-11-29 6:03 ` Fritz Koenig
2020-11-11 14:37 ` [PATCH v2 3/8] venus: hfi_cmds: Allow null buffer address on encoder input Stanimir Varbanov
2020-11-29 6:05 ` Fritz Koenig
2020-11-11 14:37 ` [PATCH v2 4/8] venus: helpers: Calculate properly compressed buffer size Stanimir Varbanov
2020-11-29 6:07 ` Fritz Koenig
2020-11-30 7:52 ` Stanimir Varbanov [this message]
2020-11-11 14:37 ` [PATCH v2 5/8] venus: pm_helpers: Check instance state when calculate instance frequency Stanimir Varbanov
2020-11-29 6:08 ` Fritz Koenig
2020-11-11 14:37 ` [PATCH v2 6/8] venus: venc: add handling for VIDIOC_ENCODER_CMD Stanimir Varbanov
2020-11-29 6:12 ` Fritz Koenig
2020-11-11 14:37 ` [PATCH v2 7/8] venus: venc: Handle reset encoder state Stanimir Varbanov
2021-01-02 0:13 ` Fritz Koenig
2021-01-07 10:09 ` Stanimir Varbanov
2020-11-11 14:37 ` [PATCH v2 8/8] venus: helpers: Delete unused stop streaming helper Stanimir Varbanov
2020-11-29 6:09 ` Fritz Koenig
2020-11-29 19:17 ` [PATCH v2 0/8] Venus stateful encoder compliance Fritz Koenig
2020-11-30 7:55 ` Stanimir Varbanov
2020-11-30 17:28 ` Fritz Koenig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7e3e582-93c7-d0e8-41a0-71d89a16fc70@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=acourbot@chromium.org \
--cc=frkoenig@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).