Re: [PATCH v1 2/2] arm64: dts: qcom: talos-evk: Add sound card support with DA7212 codec

[Le Qi <le.qi@oss.qualcomm.com>]

On 10/24/2025 3:59 PM, Konrad Dybcio wrote:
> On 10/24/25 4:37 AM, Le Qi wrote:
>> Add the sound card node for QCS615 Talos EVK with DA7212 codec
>> connected over the Primary MI2S interface. The configuration enables
>> headphone playback and headset microphone capture, both of which have
>> been tested to work.
>>
>> The sound card integrates:
>>   - DA7212 codec on I2C5
>>   - Primary MI2S playback and capture DAI links
>>   - Pin control for MI2S1 signals
>>
>> Signed-off-by: Le Qi <le.qi@oss.qualcomm.com>
>> ---
> 
> [...]
> 
>> +	sound {
>> +		compatible = "qcom,qcs615-sndcard";
>> +		model = "qcs615-snd-card";
>> +
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&mi2s1_data0>, <&mi2s1_data1>, <&mi2s1_sck>, <&mi2s1_ws>;
> 
> property-n
> property-names
> 
> in this order, please

Sure, will modify in next patch, thanks.

> 
> [...]
> 
>>   &tlmm {
>> +	mi2s1_data0: mi2s1-data0-state {
>> +		pins = "gpio110";
>> +		function = "mi2s_1";
>> +		drive-strength = <8>;
>> +		bias-disable;
>> +	};
>> +
>> +	mi2s1_data1: mi2s1-data1-state {
>> +		pins = "gpio111";
>> +		function = "mi2s_1";
>> +		drive-strength = <8>;
>> +		bias-disable;
>> +	};
>> +
>> +	mi2s1_sck: mi2s1-sck-state {
>> +		pins = "gpio108";
>> +		function = "mi2s_1";
>> +		drive-strength = <8>;
>> +		bias-disable;
>> +	};
>> +
>> +	mi2s1_ws: mi2s1-ws-state {
>> +		pins = "gpio109";
>> +		function = "mi2s_1";
>> +		drive-strength = <8>;
>> +		bias-disable;
>> +	};
> 
> You can group these together (i.e. create a single entry with
> pins = "gpio108", "gpio109"...)  and move them to the SoC DTSI
> 
> Konrad


-- 
Thx and BRs,
Le Qi