From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f45.google.com (mail-dl1-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 570D83C943C for ; Fri, 20 Mar 2026 15:22:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774020144; cv=none; b=dnV/k9sPZ/mgs4Lbeq6WD6LCdTk7KFAAlPxqc384YtQUWKE1hUnL1+6B7quxOX2SiLgixp80TKh1wY1M3lgCKlXMacELKa6BYg6kyvuqPvDFvl2U/LyZlhrmcHS6KnRqgzxWQOPcDaB1STFZ5NZ2PP4E5jX84VdZSMjrR6AStZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774020144; c=relaxed/simple; bh=UgR6Ndg9uIN+GlcSMo5nrbnxzdPyRtxdyxaRymn3PjU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mhvtqXT27ct4hEV/9qOTPetYmFDQdq9J/yTI39Q6rGAor6cHB+MCLLDEC4gOCCV0Adp8weIqwxAHQYj3F1rmGFu2BHboLK8WVi7Qj3YXcvTZuiO07cvBt/fysredyaf2ruRmA/L/tBKpg5zkSy7wO+T0YLysFSnl9jj6RELXpWM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=etb/22JS; arc=none smtp.client-ip=74.125.82.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="etb/22JS" Received: by mail-dl1-f45.google.com with SMTP id a92af1059eb24-1279eced0b9so1061005c88.0 for ; Fri, 20 Mar 2026 08:22:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774020140; x=1774624940; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=wLivAihLgNnoUtQTgzoVTgm03POcgTePUmAJyh0fy7M=; b=etb/22JSbN7fvE0ycHXItKMqS+dhcRAYlzUA12l+sUaRynrkmLiqlrxOuARf8LP1IG xQK2Y7vYLXOie0loa6jTRlLiAwESQpNv4iv+/lJNoiWmtJkZS5//Rq/aIN4xoQ9g78wJ 4LeNsFLMFX5eoaaUxWXFx0bxyjlscdAeKKF10GutRwGpXpNmicIZRe/z8nvKjJ9Y7IF/ WZX1jM6sfUoJlZCgyKbqvt24/E4JeBf90cpEHiOtyVI3C1XHkZFAvTcaNPcLm6fx/Xto mjpNKNtXZX6lk0uenkalRzsKvhvTF7ODaD8GU35CppRI6hNgSL1LNGrwH4aYttvQb5KT kSyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774020140; x=1774624940; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wLivAihLgNnoUtQTgzoVTgm03POcgTePUmAJyh0fy7M=; b=mosh+B4mRVhHlgRDfCQ0bG2c+RLPAxuA9H5L7HVwT5AfHwF7iDY1nC44x+GD8I5DKt HUr+loZEG5GoMROeusGYdTLhSviCeNLGU61vFc4PukqERCi+ePgzWsidpZ1PC58c/UIT CSmxcdfJgSTb+ohVczEsMgNGT2V4vdddJ5My7iwYBWDLMwugptgp34m6ivvhbV9JqBaZ 9JhCSbXD0uqeDdGFepyLSx3JsU1v2pabM3Ldy3hIqgDsRmW00HKSxrm2x+mpQsVDJ+vn CAFQ6PIdlg1XXmcqzMjpKdgvtneFIVfBHipaEH1iYZXiD+qa4jcx3kUi36c79BOfsMTr B3xA== X-Forwarded-Encrypted: i=1; AJvYcCXeEFKMKQFQRVAlt2t2CXZcLiSyw84UuSGPPGVBx1JNvOpPcUDtu/193MuAjL1BCQ7DD7IxWJeOvp01gAPf@vger.kernel.org X-Gm-Message-State: AOJu0Yws3swWL2ePoY6yJlF7bFo3pmiAIu7JwXPFzvnTJydgK76L6zWC KF4LLlkMYO7waF7Un9683Eu62TBE/kUMoCKndfgeqOjb7sCdz1/lRr9F X-Gm-Gg: ATEYQzzDwIJomhJoXCiPxejlDQglJWEfa/UqPJlfbkjl/nCvcY/Vsf80Rok1fYQNq6Z VAK9ibWeg18kKss7+YI5XFG5/mtbiqu5ci4z/+io+MWQd6nvFp9iDHwlVMAMB/iM3CeazsN+L1p YsB0BoYldfHTPgOev5BO9kjbn02q04O5l5uQ601i9WucHAjydaQjJ1F921/SmJXWNBiSa7LBMjM KtmbQ9z7tD9AChqLaEbr5fCG4IXlBJlp3nyvE/UGu/sqYB+65oyRnK8N+Uf5LHeG0p4xwnUjzIc MuK8/kkoOoCbcwXQrknS8p0S8Jzwem8r2gFA67HCASrip/x05rp6UxHA6p94KoQ8JxiR1Llet6h kcJoJnFGren27JlFzTPlAYN+e6yLfYd7NJyTjRgs6g0DoxxbgJWhI+xwbmfMbwhLRcxIY7angOa HdQ2TQMzdn/oTy8lescaspT2YVdwN3Pw8eqTtHyj/qKiVBMm4k7VoQjNwjwXSFtxSsuxIumZga X-Received: by 2002:a05:693c:300b:b0:2be:1f56:ed21 with SMTP id 5a478bee46e88-2c109563b70mr1476492eec.7.1774020140180; Fri, 20 Mar 2026 08:22:20 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10aefd778sm4707452eec.0.2026.03.20.08.22.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Mar 2026 08:22:19 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Fri, 20 Mar 2026 08:22:17 -0700 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] hwmon: Add Qualcomm PMIC BCL hardware monitor driver To: Daniel Lezcano , Manaf Meethalavalappu Pallikunhi Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , amit.kucheria@oss.qualcomm.com, Daniel Lezcano , Gaurav Kohli , linux-hwmon@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260206-qcom-bcl-hwmon-v1-0-7b426f0b77a1@oss.qualcomm.com> <20260206-qcom-bcl-hwmon-v1-2-7b426f0b77a1@oss.qualcomm.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/20/26 07:52, Daniel Lezcano wrote: > Hi Manaf, > > On Fri, Feb 06, 2026 at 02:44:06AM +0530, Manaf Meethalavalappu Pallikunhi wrote: >> Add support for Qualcomm PMIC Battery Current Limiting (BCL) hardware >> monitor driver. The BCL peripheral is present in Qualcomm PMICs and >> provides real-time monitoring and protection against battery >> overcurrent and under voltage conditions. >> >> The driver monitors: >> - Battery voltage with configurable low voltage thresholds >> - Battery current with configurable high current thresholds >> - Two limit alarm interrupts (max/min, critical) > > Can you describe the behavior of the alarm ? > > I assume the alarm is raised when a threshold is crossed from normal > to anormal condition leading to a hwmon event. > > * Does the BCL trigger an interrupt when going back to the normal condition ? > > * When is the alarm flag reset ? > > * Can we have a flood of events if the current / voltage is wavering > around the thresholds ? > > Overall, the driver is too big, so hard to review. It is better to > provide a simplified version with one version supported. > >> The driver integrates with the Linux hwmon subsystem and provides >> standard hwmon attributes for monitoring battery conditions. >> >> Signed-off-by: Manaf Meethalavalappu Pallikunhi >> --- >> MAINTAINERS | 9 + >> drivers/hwmon/Kconfig | 9 + >> drivers/hwmon/Makefile | 1 + >> drivers/hwmon/qcom-bcl-hwmon.c | 982 +++++++++++++++++++++++++++++++++++++++++ >> drivers/hwmon/qcom-bcl-hwmon.h | 311 +++++++++++++ >> 5 files changed, 1312 insertions(+) > > [ ... ] > >> diff --git a/drivers/hwmon/qcom-bcl-hwmon.c b/drivers/hwmon/qcom-bcl-hwmon.c >> new file mode 100644 >> index 000000000000..a7e3b865de5c >> --- /dev/null >> +++ b/drivers/hwmon/qcom-bcl-hwmon.c >> @@ -0,0 +1,982 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Qualcomm pmic BCL hardware driver for battery overcurrent and >> + * battery or system under voltage monitor >> + * >> + * Copyright (c) 2026, Qualcomm Innovation Center, Inc. All rights reserved. >> + */ > > Old copyright format > >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include "qcom-bcl-hwmon.h" >> + >> +ADD_BCL_HWMON_ALARM_MAPS(in, min, lcrit); >> +ADD_BCL_HWMON_ALARM_MAPS(curr, max, crit); >> + >> +/* Interrupt names for each alarm level */ >> +static const char * const bcl_int_names[ALARM_MAX] = { >> + [LVL0] = "bcl-max-min", >> + [LVL1] = "bcl-critical", >> +}; > > IIUC there are three levels of alarms but the hwmon only has max/min > and critical. Would it make sense to do adaptative min / max ? So when hwmon has lcrit, min, max, and crit alarms for all sensor types, plus an additional _cap_alarm for power attributes and _emergency_alarm for temperature attributes. There is also a generic _alarm attribute for each sensor, which is supposed to be used if the specific alarm type is not known. What exactly are the three levels of alarms ? Thanks, Guenter