Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Jagadeesh Kona <quic_jkona@quicinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	Vinod Koul <vkoul@kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Taniya Das <quic_tdas@quicinc.com>,
	Satya Priya Kakitapalli <quic_skakitap@quicinc.com>,
	Imran Shaik <quic_imrashai@quicinc.com>,
	Ajit Pandey <quic_ajipan@quicinc.com>
Subject: Re: [PATCH V2 3/6] clk: qcom: clk-alpha-pll: Remove explicit CAL_L configuration for EVO PLL
Date: Thu, 1 Jun 2023 19:51:21 +0530	[thread overview]
Message-ID: <a97da679-7ac8-78f8-9b3d-5df8f690287f@quicinc.com> (raw)
In-Reply-To: <58310306-2d70-eab4-4564-e77e1fb638a1@linaro.org>

Hi Bryan,

Thanks for your review!

On 5/26/2023 9:27 PM, Bryan O'Donoghue wrote:
> On 26/05/2023 16:54, Bryan O'Donoghue wrote:
>> On 25/05/2023 18:21, Jagadeesh Kona wrote:
>>> Fixes: 260e36606a03 ("clk: qcom: clk-alpha-pll: add Lucid EVO PLL 
>>> configuration interfaces")
>>
>> Is this a "Fixes" without the previous patch to stuff the CAL_L_VAL 
>> and VAL_L fields ?
>>
>> [PATCH V2 3/6] clk: qcom: clk-alpha-pll: Remove explicit CAL_L 
>> configuration for EVO PLL
>>
>> Surely you need _both_ with this patch depending on the previous, per 
>> your comment ?
>>
>> -    .l = 0x3e,
>> +    /* .l includes CAL_L_VAL, L_VAL fields */
>> +    .l = 0x0044003e,
>>
>> ---
>> bod
> 
> i.e. if you pick up this patch on its own you won't populate 
> CAL_L_VAL... right ?
> 
> It would make more sense to squash the two patches.
> 
Sure, will squash both the patches in next series.
> ---
> bod

Thanks & Regards,
Jagadeesh

  reply	other threads:[~2023-06-01 14:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25 17:21 [PATCH V2 0/6] Add camera clock controller support for SM8550 Jagadeesh Kona
2023-05-25 17:21 ` [PATCH V2 1/6] dt-bindings: clock: qcom: Add SM8550 camera clock controller Jagadeesh Kona
2023-05-26 12:29   ` Bryan O'Donoghue
2023-05-25 17:21 ` [PATCH V2 2/6] clk: qcom: Update l value configuration for lucid ole and evo plls Jagadeesh Kona
2023-05-26 13:22   ` Bryan O'Donoghue
2023-06-01 14:20     ` Jagadeesh Kona
2023-05-25 17:21 ` [PATCH V2 3/6] clk: qcom: clk-alpha-pll: Remove explicit CAL_L configuration for EVO PLL Jagadeesh Kona
2023-05-26  9:33   ` Konrad Dybcio
2023-05-26 15:53     ` Dmitry Baryshkov
2023-06-01 14:33       ` Jagadeesh Kona
2023-06-01 14:43         ` Dmitry Baryshkov
2023-06-09 11:50           ` Jagadeesh Kona
2023-06-09 12:25             ` Dmitry Baryshkov
2023-06-14 11:53               ` Jagadeesh Kona
2023-06-14 12:26                 ` Dmitry Baryshkov
2023-06-23 16:35                   ` Jagadeesh Kona
2023-05-26 15:54   ` Bryan O'Donoghue
2023-05-26 15:57     ` Bryan O'Donoghue
2023-06-01 14:21       ` Jagadeesh Kona [this message]
2023-05-25 17:21 ` [PATCH V2 4/6] clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550 Jagadeesh Kona
     [not found]   ` <0ad16ac8-deac-41d3-9c36-885eb8be3fee@linaro.org>
2023-06-01 14:34     ` Jagadeesh Kona
2023-05-25 17:21 ` [PATCH V2 5/6] clk: qcom: camcc-sm8550: Add support for qdss, sleep and xo clocks Jagadeesh Kona
2023-05-25 17:21 ` [PATCH V2 6/6] arm64: dts: qcom: sm8550: Add camera clock controller Jagadeesh Kona

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a97da679-7ac8-78f8-9b3d-5df8f690287f@quicinc.com \
    --to=quic_jkona@quicinc.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=quic_ajipan@quicinc.com \
    --cc=quic_imrashai@quicinc.com \
    --cc=quic_skakitap@quicinc.com \
    --cc=quic_tdas@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox