From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24F6E1B0435 for ; Thu, 24 Apr 2025 06:56:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745477805; cv=none; b=IVCZ4x83v6sRX7uqQeUD1VSJXRrvC8iI/K71rromxhWxFRJWBn5gZgwbUDb+7LymZglHjeRUd6pUxdiMCYOsHU3g74JaZC2HihDxTV5lqH3n+PqcxGh/+sQLUxmgt/pqXCcwMs+ro4/SMVynDh+9VR7UA7PKHFHl1e4Ku8uHJxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745477805; c=relaxed/simple; bh=KaDurauswI188KUjZ3KNQvsryIeiaUhlpIHOyWF2O0o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MRdt6GkyN61a9yi1+abyuYom/eBtPRBHW/IntvG9GD0d/U3tNhOB54JZNvjjMklkR3PXrCX1D953/2xLzdlfvCZE3ZiYqIl4cScai3Qfa7n5WpqEjpQyk+n3wJSoO9T8WSdv3nCaL7yvwSNxJb4sScaDvIjaOd9iUhCQYNNM8p4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=QpAcP0ul; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QpAcP0ul" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5efe8d9eb12so940524a12.1 for ; Wed, 23 Apr 2025 23:56:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745477802; x=1746082602; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7kzVv79whvRhzEeD6JG5Yuqa4/y4qdCf+2FXelQG1Yg=; b=QpAcP0ull37osyzz0lwmfHbM6xwEU6yYa1hORanq77BXJc36z1RgOTaQPsXD2k8122 bO9/CqpUcrK07DTpAeexhlaDBbeOJyKUw+CkmrSztl0By8FCn28+32swlC6BAzjGd3uK Ju36Alpzn+KeDeAWQQSpT1vF9VInhuMsLBu6BhSXifDq9h+wT9J5Ve+UDwg+9WWiP4mQ 3wucdPs4KneMVdSxlJ6/VilaaWKpUrutOSJdEjVu8dZA+zPVsSPTpCSx5/hN759fXjyx Aq6TqNJWgzbWmJK7s6fRO1BFovKuMhhfCobqB6YeJ1JWgGul3Mk2vZ+i91oQU8wPqLyi DJCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745477802; x=1746082602; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7kzVv79whvRhzEeD6JG5Yuqa4/y4qdCf+2FXelQG1Yg=; b=BadK5hVZuNUjZsHA8Te/KPQoB8GgB8Rq7BlqZUjvVohOF6U5ZJI+wTkigXxE+6S7hX 0HLHh4wg8ySOcDBsT/G90wX0w7Lr+8KuLTaEx0CZIXirqAwX7I/Dob+ldZPL717cgaM1 UlvKi2+DOtrRdBo3s5pzfHzEGdBBONh0VXqyV39+eE5RzJr7kViUeuB70cV5qy9VhFvN QjfzKemDrfGAc5MS+OENHapOorkZV+Zhr8O74Yl6I5JCR1kLgz4q3JA6bsJSt/O6oB8B DMKA7O5q51njJpInDqHkAj0adErtQT3zfhE9LD4DSC9bgSfze/jy7Qctu7YgWQs2LLFM nGUQ== X-Forwarded-Encrypted: i=1; AJvYcCV96vJtRqngc+TdZQbdB+gpPremIPkKW1W4NcGjgiAGFYiSCW1VenClmd/ggOdVfbYiRbblU9EvYbOx92DA@vger.kernel.org X-Gm-Message-State: AOJu0YzExDAZ1YWj4T0HuXzFmVW12LxM39OxwqhmQjsq/0HDb9zk7Lnd D95IwkPh7Z1VClTfA40LayzE+Y4dWrctm8TrXVFJ7XNIGGivGxc+W45joqgzEU1XAxB5TW4VXkR / X-Gm-Gg: ASbGncvUf4ZCuiEUARQ9HoUkl/ItmL6nGBfSLvufcTZNkIk6SURpFbEJFuuaDWqm7h6 J+0HvwTTGEJouOMgFRGXa6ggaqGxZpluk0Ld5M5qbQd8GCxfRWIAE9mRZ4N4baOP2W5pSGzJDJO h4eEyYIQgVJkebdIdU2/2q+u0zNhbMYnSisuwVEXzHBfHkeQTJcSpWAPGDLELjbTcvTCQFpp3PJ lzJ1cQz0F8/HDU5BIViL1680nHPm8qgpVB5A9OWASKJLqYeeEfxqgF2pvfw1nwusW9ZRCQiZbbi ABjf22kV40ODREbma8pn1HA9lHM1a3h8ftrbxQ== X-Google-Smtp-Source: AGHT+IHGr9cBdHuxjSZWLqVT9rmChGPepYhM4CQE7w0ih4cdp+SrjuSnVfBVqnG9DIEOEXWf/Vdtbw== X-Received: by 2002:a05:6402:254b:b0:5f4:c499:54e8 with SMTP id 4fb4d7f45d1cf-5f6de697effmr1551743a12.15.1745477802488; Wed, 23 Apr 2025 23:56:42 -0700 (PDT) Received: from linaro.org ([62.231.96.41]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5f6ed9e0936sm674611a12.71.2025.04.23.23.56.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 23:56:41 -0700 (PDT) Date: Thu, 24 Apr 2025 09:56:40 +0300 From: Abel Vesa To: Maulik Shah Cc: Bjorn Andersson , Linus Walleij , Melody Olvera , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: qcom: Fix PINGROUP defination for sm8750 Message-ID: References: <20250424-pinctrl_sm8750-v1-1-b070790ccbce@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250424-pinctrl_sm8750-v1-1-b070790ccbce@oss.qualcomm.com> On 25-04-24 10:17:10, Maulik Shah wrote: > On newer SoCs intr_target_bit position is at 8 instead of 5. Fix it. > > Also add missing intr_wakeup_present_bit and intr_wakeup_enable_bit which > enables forwarding of GPIO interrupts to parent PDC interrupt controller. > > Fixes: afe9803e3b82 ("pinctrl: qcom: Add sm8750 pinctrl driver") > Signed-off-by: Maulik Shah Nitpick: in commit subject, fix spelling of definition. With that fixed, LGTM: Reviewed-by: Abel Vesa