From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B59781BE23F for ; Thu, 8 May 2025 15:37:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746718632; cv=none; b=ihEgcg7roP89fvjbnvwgUUfpFYem9XCn35ryv3luxWHxjXUcDmHAWmGUIAHbmAe5CdtbgEtMLRzfnxLu1bLL+apxUcVW3WY2CaTlboyPu3QB2CwOXit2RucczR2i1PkPzrE/4Im2/NJg/wvFwPYxPlZNTAgdLyuZxVjbKnerSnk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746718632; c=relaxed/simple; bh=KIJoKuXbOWQ1OYetx9oJLxCS+VoWimRs1SlFvXoImcw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=m+KuE6UvdWvXbBRdSA1Ccn35R1QgTkcryTdB6HqZYU9HvwjYKYlGG8U6c5OyBU+11DTAcKXLrawHbxjTdUC0yZmpQe7E10ZeUANafOCP+W07OUVeNqzF4Tv0t70ZdpFqJzbKKusXqeBGpCBSBs48uOHJW74FJhJ6Hl7gnrqxMvE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WmRlHQwD; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WmRlHQwD" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 548DWqAS022749 for ; Thu, 8 May 2025 15:37:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=RmEnv08TV/oKkS/GPCZOm8Rd 6FwX+L2I8PDAwGfsX1A=; b=WmRlHQwDqi5iLO38gGkdi6rirq/iXBIX33sgmsK5 cTGYryP5wysPFs7id6Mse8LgJEgZr7VLUGCiC3k9tUYGzvxCFDrqExwx1Pct2Zl1 gxNQcF9bKRgral28ZDRYf3qFe7Pc5oqrEAUOyvlAsBvePKau5rsIYd+Q4M7l8k17 ol6a4X62DlnVoNLMUyd9f+WZZ1pJmiwshs9bQ4yGcrHbOKrNYVbr7VxgO0k0o+eu vJiSAPDNTAHq4ygZVyShFzuCBxCNrtCmK9FIzaYYjsVmiaw1mL1DF7xCd9ESJGmo DW0Q7W/v1gFm1JyKl5UdY5AkQht2ketff+HjnoWNn+Wl5g== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46gnp81tua-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 08 May 2025 15:37:09 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-73e0094706bso1870798b3a.3 for ; Thu, 08 May 2025 08:37:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746718629; x=1747323429; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RmEnv08TV/oKkS/GPCZOm8Rd6FwX+L2I8PDAwGfsX1A=; b=Yn7k+XWjnWgomuCvH2U//57zBTGBXvgr/PFSyPl6W+UTZRVSfhKU4X/R1iZRr+V8FW OWe6RPXL06NbP1JPYWcsw1LAy7kev3m4YtxZNHg/CW9kfzNWtkYamIG0pBThC5DW9i7z DmUrRZ7pJsKbG6k15wq1/fOEJKhilfbcId3Nu+TuYjpGqfndxVNN7ksnMocy0FcTeGmV YNWC2kd70DhqhvMKtAE9fy8AiqsH1nJKImcf5/AeAn55PGNeLc1zmEHdAqfqYz34Z6cU q/P3VjR6u0ZWEF3LCigpAyHEdz1VQqAQIRBNxzqLOssGH/3zHVabDHEy0BqOM8baRPfl xoXA== X-Forwarded-Encrypted: i=1; AJvYcCWg7L9/364lJJMRMH08GjK1ZIESl9JwU3bTqKfCqfUFCesW3cFmO1pTgTXgbQReM7uXHAy75UxWu/tozI08@vger.kernel.org X-Gm-Message-State: AOJu0YwV+Yo3csE53Juv21tH/snF5ulBB/ui3vlEj8FtT+9uKQKuy+1+ HYkxbevHQIkDYp8RHeB2jJynGb4snJmA73/fiqSr9ZTJ7TRkmAWdb+8sMLqkuUD8++OtaYmEBj6 tcd9BlpSLw13L3Cx4sD8sFrwg0ZZJKYFWIYnZ372Z7IQFAVR1po7fMoIlOOYfeuKs X-Gm-Gg: ASbGnct+zdWGR87gSwtMH/JygwDHCnMlqKmvZaBwXaKZzmX0tD4Jk/5ClbniVDXJnvG d54cqtalJ4RPnPZXKCS6fmdlrlyZ5rlmilALutMymvm+SCBQzMPnQcpu4LghGP/H35gcmryn4oW 5lljloI9GbvpIWUIDAfKtsCKjshlJ6i/Uha9dgDvLZ0NPDWa5dmgTdmM5+B5W7aNu7rYSHQb+3o 0I+7c3KWeK7FPQZNAwb4zhTo+YFO+nlChFzRqNbKrIObhRgfiC02fmOEg6z//EEvoXzF9tscenf bRZeoCTZLvbahEIreZm2k9z04DsnQCsUhHF8ZJk= X-Received: by 2002:aa7:8190:0:b0:740:aa33:c6f8 with SMTP id d2e1a72fcca58-740aa33c770mr4023680b3a.7.1746718628768; Thu, 08 May 2025 08:37:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGBuHs8eff+nm/YQYKx7SCqM7aiZdpEv9rjxEoFtDm6bDzLVik9n2O/69qr3z1oRa7Rjfte4w== X-Received: by 2002:aa7:8190:0:b0:740:aa33:c6f8 with SMTP id d2e1a72fcca58-740aa33c770mr4023641b3a.7.1746718628305; Thu, 08 May 2025 08:37:08 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74237a97de2sm119972b3a.175.2025.05.08.08.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 May 2025 08:37:07 -0700 (PDT) Date: Thu, 8 May 2025 21:07:03 +0530 From: Mukesh Ojha To: Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] soc: qcom: socinfo: Add support for new fields in revision 21 Message-ID: References: <20250425135946.1087065-1-mukesh.ojha@oss.qualcomm.com> <20250425135946.1087065-2-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Authority-Analysis: v=2.4 cv=M7xNKzws c=1 sm=1 tr=0 ts=681ccfa5 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=dt9VzEwgFbYA:10 a=EUspDBNiAAAA:8 a=tTqnaQ_goHMJMu8gR3YA:9 a=CjuIK1q_8ugA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-ORIG-GUID: Ga0pTWhKnWnvOXO_-R4A1rsaXx27qHW8 X-Proofpoint-GUID: Ga0pTWhKnWnvOXO_-R4A1rsaXx27qHW8 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA4MDEzNiBTYWx0ZWRfX0EwgR0FKj9SV S+07EombZdW96X4SaVYWraEnSphBKuCCfR4kLz8tuJtLrNXDR10Rj96nzdKc4e1MYWBehRuUGv6 MJhVRE9eTvOZG54R9Jth2nBQzZK3ZPicavD8XtLT145ZA/aVy5WUzgE7MutOWpaAEznCh4kpTIs 7lEQ9+/DyXbqQk0CObHQOl5YIX2wRAlo84SzNQs6zR7rdxe7IXJtkfLZyu7RGrOCjiu64Mdz5Eh f98TCcveis4cTCQK51kXB50E5YQpQ12BeK/Cri+B0PZKWoYrMseHHM8mjMpG58eQozVrxHl5CkO 4LzErZZxS7VuAY2HuFGL94uFBqto8sG2BCxgBB/hHoHIZtRo4F0zgzKwZ51ouCDr65ocKwxn4w4 ZjuElvH0V7gEvw/hHtwzylSPfrWv19qI++k0omlaxbmH6n8h6SVlJPljm9mBH7z6kbqgd8x1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-08_05,2025-05-08_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 malwarescore=0 mlxscore=0 priorityscore=1501 spamscore=0 mlxlogscore=999 bulkscore=0 impostorscore=0 clxscore=1015 suspectscore=0 adultscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2505080136 On Fri, Apr 25, 2025 at 08:28:51PM +0300, Dmitry Baryshkov wrote: > On Fri, Apr 25, 2025 at 07:29:45PM +0530, Mukesh Ojha wrote: > > Add the subpartfeature offset field to the socinfo structure > > which came for version 21 of socinfo structure. > > > > Subpart_feat_offset is subpart like camera, display, etc., > > and its internal feature available on a bin. > > > > Signed-off-by: Mukesh Ojha > > --- > > Changes in v2: > > - Added debugfs entry and described more about the field in commit. > > > > drivers/soc/qcom/socinfo.c | 6 ++++++ > > include/linux/soc/qcom/socinfo.h | 2 ++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c > > index 5800ebf9ceea..bac1485f1b27 100644 > > --- a/drivers/soc/qcom/socinfo.c > > +++ b/drivers/soc/qcom/socinfo.c > > @@ -154,6 +154,7 @@ struct socinfo_params { > > u32 boot_cluster; > > u32 boot_core; > > u32 raw_package_type; > > + u32 nsubpart_feat_array_offset; > > }; > > > > struct smem_image_version { > > @@ -608,6 +609,11 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo, > > &qcom_socinfo->info.fmt); > > > > switch (qcom_socinfo->info.fmt) { > > + case SOCINFO_VERSION(0, 21): > > + qcom_socinfo->info.nsubpart_feat_array_offset = > > + __le32_to_cpu(info->nsubpart_feat_array_offset); > > + debugfs_create_u32("nsubpart_feat_array_offset", 0444, qcom_socinfo->dbg_root, > > + &qcom_socinfo->info.nsubpart_feat_array_offset); > > An offset into what? If this provides additional data, then the data > should be visible in the debugfs. Not sure, what's the point in dumping > the offset here. offset into info(struct socinfo) object. I agree to you and I said the same in first version this is just offset and does not provide any debug info we would look from userspace. For parity with other fields I did it for all newly added fields. I have dropped it in latest patch. -Mukesh