linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Acayan <mailingradian@gmail.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm670-google-sargo: enable charger
Date: Tue, 1 Jul 2025 18:32:49 -0400	[thread overview]
Message-ID: <aGRiEdXs6pwRH5CH@radian> (raw)
In-Reply-To: <f931e284-6ae6-4177-83bf-c6eb1ce583f9@oss.qualcomm.com>

On Tue, Jul 01, 2025 at 12:55:14PM +0200, Konrad Dybcio wrote:
> 
> 
> On 01-Jul-25 00:41, Richard Acayan wrote:
> > The Pixel 3a has a rechargeable 3000 mAh battery. Describe it and enable
> > its charging controller in PM660.
> > 
> > Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> > ---
> >  .../arm64/boot/dts/qcom/sdm670-google-sargo.dts | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts b/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts
> > index 74b5d9c68eb6..d01422844fbf 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts
> > +++ b/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts
> > @@ -33,6 +33,14 @@ / {
> >  
> >  	aliases { };
> >  
> > +	battery: battery {
> > +		compatible = "simple-battery";
> > +
> > +		voltage-min-design-microvolt = <3312000>;
> > +		voltage-max-design-microvolt = <4400000>;
> 
> Does this match what downstream sets into the hw?

Actually, downstream sets the "empty" voltage to 2.6 V. This minimum is
closer to the "cutoff" voltage at 3.3 V.

The maximum voltage is consistent with downstream.

  reply	other threads:[~2025-07-01 22:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-30 22:41 [PATCH] arm64: dts: qcom: sdm670-google-sargo: enable charger Richard Acayan
2025-07-01 10:55 ` Konrad Dybcio
2025-07-01 22:32   ` Richard Acayan [this message]
2025-07-02 10:52     ` Konrad Dybcio
2025-08-12  3:04 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aGRiEdXs6pwRH5CH@radian \
    --to=mailingradian@gmail.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).