From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 718492FE300 for ; Thu, 17 Jul 2025 17:09:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752772142; cv=none; b=dNwTDlXDUx0PBVfCLcTNfCfKZiDUy8dum0+kVsznml3ha7rsJx2iulGQ/dLlatzMr1V6keodHdbc8H45VRxLjIKOuSizEcjH3m+2/Zh1I4sTUmvizVml5+A5tjMvfcg8RcqgMPDSTduuNu8y4L2/Q+9hA0lSToWXrhaE4YvWhUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752772142; c=relaxed/simple; bh=0Tma1iz8eUmqn+0ITGTty9g+3dbDSlSnl255hcwZ1/c=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rt6h/hygUvMa4eNmDfpKexrvvQQz7IjnQCIZ7xkbv4m41Q/9U2uPAbJUMD3JNHM8TnTLBJnuRWi/wE9u1WKRS9mF7tXCCdbqXwB2T0sFHhbFjNZUa7nJNI/NWJ8oAHtITRr7gl9X4NWEXyzWOuQRTWQtjBfewoiB+ISyNi7ZaUU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AZK6KhFC; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AZK6KhFC" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56HBun2S025180 for ; Thu, 17 Jul 2025 17:08:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NFXP0IrFoohUtJ59zS1dRcGAPyOKdx8dfTa98AL4DN8=; b=AZK6KhFC9FwAJw8E FqSlM1NlBdkhoCn/eSNrIP4zRoPQRIGoC454mhCqjt/nleCAOy+CQayjp74kKSlw CqHxoaJxrGZwO6OVjR+3KDO/An4eePjOCosKCiQls5TJKued8UwSEa6PM+onNvs2 1TVhTU6W7Vv9/bdF2/2+/MUMiO2EUji6kPZpeajmtBbzUM/ttdoalVwETTHTaEmt txXz2wQb5DCMiv3CYUi1JagqoKJNp9viErDalNE1iP2W+8cA7URLA+HMdZB7R9Rt zehIdEA0l6s3X2DsULfwrqHNEu+ww/wgKjMYfDw409SyRCFULku6rbSQzx09sCC1 JhCkaw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47xbsqcrbr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 17 Jul 2025 17:08:58 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ab4211ca00so24407261cf.0 for ; Thu, 17 Jul 2025 10:08:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752772138; x=1753376938; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NFXP0IrFoohUtJ59zS1dRcGAPyOKdx8dfTa98AL4DN8=; b=Z7RssNP9A/rOZuR35Cn9xgNCaR4kAnzK7XVrsJJDf1QxK6c+jkKOkRQEke9kE5H3i/ vr1nO5okSiFzxtU+tWzYqRlAMZJokLSHu1L6qd4Y2D/w4Hw23IBXc2uR3aJPLjGfsj5C 5FJ9uaLo0jHVuyZj+PDSo6l9K3XTKnexMe4mSolZe7GHrIINYVRs9GVKmv4gXxAv6iyL 3v4hYB8LkIhvcxDq+whT8WxUgojA5jRGwayI89uYLaGbvaXO1cUNBCyrA8ilz8SRqgUF m79Jp7srA8J+OJtaV/O8zsuRvHOqTJvbIxi3EkSS43XsD8PKd0NFKqzJhXcFC1m9AQ0C PZGA== X-Forwarded-Encrypted: i=1; AJvYcCWIQByfY0VxpKHQs/ape62gutdlAN7FvXc74d9tsz66oIllSjm5Zdc6bB0QUcilNpWzwlbjxbB3O6d3zxxe@vger.kernel.org X-Gm-Message-State: AOJu0YzZi8KIpJzuUvVK6Idw1Z9h5g40ZFue3WywKQGG0XjFCpe98ixw lXNWgtcnjLGSx+AesS7d/SKg0DGznbWAaZpiBxjM/f4UFVo5dv9N9D4h0NMwVnocL56pprgZ31Z lEgKNkGgf1DbgS+jjfYunS8uNuC28L1Q2qFNV+Dne9w17QX6AhTDOziEuO6Vyv0Cbu+uY X-Gm-Gg: ASbGncttKPYo7znu3dJPaM55zPbZpsGg0Cz7MdkShQjdsPL1Vt6dThQVMkWYgN1ipWJ G1eZIh5MlPCZ+SKjs0+B+vJ48Ly6iTSKXnRBncqQ5W0Tp9mDwashKJhT/x0HHEuUHq+40NA1BE/ OekP0GQv7IQbAYSFs29s0LeSldcdGLysLOxzJ4pOENRkmtLNs0QW2p2rbOYBHpYmOtf8qGFuOpb BRxbpOD4zj0Qi2XzR46Yt+bTkraVqKDt8CKyDSXhD6pHFwMwTU2jkyjp3ZFUhNchpf1Lv1HDdSs aXi5BPgPNfEkYjuNovxf5hcgKRR60R7IcRpJrQsuiFROmeG3rURFBreSkrNbYySLejrxcqheZVI = X-Received: by 2002:ac8:5f0a:0:b0:4ab:5c2d:fb25 with SMTP id d75a77b69052e-4ab93c8bf96mr124297971cf.19.1752772137210; Thu, 17 Jul 2025 10:08:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEITysj2tJkRLvAb9+p0VY+EGEbopgJQYbTjJgWoH9NN/hppB3HlOgLIRM1vSCE6/5DgrGMIQ== X-Received: by 2002:ac8:5f0a:0:b0:4ab:5c2d:fb25 with SMTP id d75a77b69052e-4ab93c8bf96mr124296971cf.19.1752772136330; Thu, 17 Jul 2025 10:08:56 -0700 (PDT) Received: from trex (153.red-79-144-197.dynamicip.rima-tde.net. [79.144.197.153]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc2025sm21560881f8f.31.2025.07.17.10.08.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jul 2025 10:08:55 -0700 (PDT) From: Jorge Ramirez X-Google-Original-From: Jorge Ramirez Date: Thu, 17 Jul 2025 19:08:54 +0200 To: Jorge Ramirez Cc: Krzysztof Kozlowski , Bryan O'Donoghue , quic_vgarodia@quicinc.com, quic_dikshita@quicinc.com, krzk+dt@kernel.org, konradybcio@kernel.org, mchehab@kernel.org, andersson@kernel.org, conor+dt@kernel.org, amit.kucheria@oss.qualcomm.com, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 1/7] media: dt-bindings: venus: Add qcm2290 dt schema Message-ID: References: <20250715204749.2189875-1-jorge.ramirez@oss.qualcomm.com> <20250715204749.2189875-2-jorge.ramirez@oss.qualcomm.com> <8a63f517-a443-48e4-9b9c-0c4b362f59f8@linaro.org> <0bb2867a-393b-46f9-ad6f-1aeee5a3a9d4@kernel.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Authority-Analysis: v=2.4 cv=ad1hnQot c=1 sm=1 tr=0 ts=68792e2a cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=Ki5fnJvzvo7yLsyA0quaxQ==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=gEfo2CItAAAA:8 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=COk6AnOGAAAA:8 a=chJ0svP5d_1F8NzP0EgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=sptkURWiP4Gy88Gu7hUp:22 a=cvBusfyB2V15izCimMoJ:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: wnEphCyrZSshIpIgG9iqvgzhHU9YhhVz X-Proofpoint-GUID: wnEphCyrZSshIpIgG9iqvgzhHU9YhhVz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzE3MDE1MSBTYWx0ZWRfXzOPHKJNJqpkI 7uWWcOnNbjrAVyIyymmacrjhG21E3yiyqjXJbsFoOSZfaDJQAS2IMUHNpw0R41Fs5opQarEmmGL VU4glhwY7V4dx8NziC8Xe6ahI53yMHBlLgvt+hIgJC+xc+Vc+PppVduYDWXyoZtjZMw3DIh70of BdesqXVrHUobQHO5uKi3qsqJ7AbSJL9HlO5xzm23ROaKBQe9Y7a1l9fKgTrTTFQHkmfyqkmzEow dMhLEKlD0ROj+7MKnTvlMPuS15ZswCjrf+VppShammWYX+/ynXdO6t47e+P/zrgWRqymn393wJT 01LJfh3nRrFw3TlhBx1l7eQ/gWStyvnwlUb28/wJWNiHOPbof3T4zdj7a/PX0zmalAxJXeKdkk8 jAmOG5HGGt7VECKyhApPwUylwbgjA0edAnDzvC90aCVs6KFyvPByT2jtxynQJRDV39rlembR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-17_02,2025-07-17_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 spamscore=0 malwarescore=0 phishscore=0 mlxscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507170151 On 17/07/25 19:00:22, Jorge Ramirez wrote: > On 17/07/25 13:16:31, Jorge Ramirez wrote: > > On 17/07/25 08:45:17, Krzysztof Kozlowski wrote: > > > On 17/07/2025 08:35, Jorge Ramirez wrote: > > > > On 17/07/25 00:22:53, Bryan O'Donoghue wrote: > > > >> On 15/07/2025 21:47, Jorge Ramirez-Ortiz wrote: > > > >>> Add a schema for the venus video encoder/decoder on the qcm2290. > > > >>> > > > >>> Signed-off-by: Jorge Ramirez-Ortiz > > > >>> Reviewed-by: Krzysztof Kozlowski > > > >>> Reviewed-by: Bryan O'Donoghue > > > >>> --- > > > >>> .../bindings/media/qcom,qcm2290-venus.yaml | 127 ++++++++++++++++++ > > > >>> 1 file changed, 127 insertions(+) > > > >>> create mode 100644 Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml > > > >>> > > > >>> diff --git a/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml b/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml > > > >>> new file mode 100644 > > > >>> index 000000000000..0371f8dd91a3 > > > >>> --- /dev/null > > > >>> +++ b/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml > > > >>> @@ -0,0 +1,127 @@ > > > >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > >>> +%YAML 1.2 > > > >>> +--- > > > >>> +$id: http://devicetree.org/schemas/media/qcom,qcm2290-venus.yaml# > > > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > >>> + > > > >>> +title: Qualcomm QCM2290 Venus video encode and decode accelerators > > > >>> + > > > >>> +maintainers: > > > >>> + - Vikash Garodia > > > >> > > > >> Shouldn't you be on this list ? If you upstream a file I think you should > > > >> list yourself as responsible for its glory or its mess. > > > > > > > > happy to do it. The MAINTAINER's file covered all the files named > > > > > > This should be the person(s) interested and caring about this hardware, > > > which means: > > > 1. Subsystem maintainers: no > > > 2. Driver maintainers: usually yes > > > 3. Author(s) of new hardware support: usually yes > > > > perfect, will do > > > > > > > > > schemas/media/*venus* so my understanding was that I shouldn't. > > > > > > I cannot comment why people decided to go one way or another in other > > > code, but it as well could be just incorrect choice thinking only people > > > in MAINTAINERS care about hardware. > > > > > > ... > > > > > > >>> + > > > >>> + memory-region = <&pil_video_mem>; > > > >>> + iommus = <&apps_smmu 0x860 0x0>, > > > >>> + <&apps_smmu 0x880 0x0>, > > > >>> + <&apps_smmu 0x861 0x04>, > > > >>> + <&apps_smmu 0x863 0x0>, > > > >>> + <&apps_smmu 0x804 0xe0>; > > > >> > > > >> You're listing five iommus. > > > >> > > > >> I understand there's some disagreement about whether or not to list all of > > > >> the potential use-cases but, TBH I don't think those are good arguments. > > > >> > > > >> Unless there's some technical prohibition I can't think of listing all five > > > >> maxItems:5 .. let's just do that. > > > > > > > > since the device tree should describe hardware and not policy, and the > > > > driver seems to be able to ignore the unused SIDs I think this is the > > > > right thing to do. > > > > > > > > > It was never about the driver but about whether you should describe in > > > DTS for non-secure world the entries which are secure world. The answer > > > in general is that you can and there will be benefits (e.g. sharing DTS > > > with secure world implementations). > > > > all right, sounds good then, thanks > > Not sure if I’ve shared this before, but following an internal > discussion, I think it’s worth highlighting a functional dependency in > the current kernel: > > - the driver only works if the first two IOMMUs in the list — the > non-secure ones — are placed at the beginning. Reordering them breaks > functionality, which introduces unexpected fragility. by "the driver only works" I mean the firmware will fail to load otherwise (should have been clear about the failure mode). > > Regardless, this seems like a valid concern to me — a driver shouldn't > rely on the order of phandles — and I just wanted to make sure you're > aware of it before I post a v8 (likely sometime next week or the > following, as I’ll be taking a short break soon). > > Do you consider this serious enough to be called out in the commit > message, or is this kind of behavior accepted as-is - ie, do you know if > the DT binding for iommus rely on the order? >