Re: [PATCH] clk: qcom: gcc-ipq6018: rework nss_port5 clock to multiple conf

["Marko Mäkelä" <marko.makela@iki.fi>]

Sat, Aug 02, 2025 at 01:51:31PM +0200, Konrad Dybcio wrote:
>On 8/2/25 11:55 AM, Marko Mäkelä wrote:
>> Rework nss_port5 to use the new multiple configuration implementation
>> and correctly fix the clocks for this port under some corner case.
>>
>> In OpenWrt, this patch avoids intermittent dmesg errors of the form
>> nss_port5_rx_clk_src: rcg didn't update its configuration.
>>
>> This is a mechanical, straightforward port of
>> commit e88f03230dc07aa3293b6aeb078bd27370bb2594
>> ("clk: qcom: gcc-ipq8074: rework nss_port5/6 clock to multiple conf")
>> to gcc-ipq6018, with two conflicts resolved: different frequency of the
>> P_XO clock source, and only 5 Ethernet ports.
>>
>> This was originally developed by JiaY-shi <shi05275@163.com>.
>
>Hmm.. I'm not sure what to think about this, given that person seems
>not to be using their full name (or maybe it is the full name, I don't
>know) and hasn't provided a sign-off, but on the other hand this isn't
>a very inventive change, so I don't *really* mind - up to you, Bjorn

This basically is the result of executing the following and resolving 
the rather trivial conflicts:

git show e88f03230dc07aa3293b6aeb078bd27370bb2594|
patch drivers/clk/qcom/gcc-ipq6018.c

I actually did that and compared the result to the original patch.

I believe that my Signed-off-by is valid and sufficient due to 
Developer's Certificate of Origin 1.1 (b), "The contribution is based 
upon previous work."  That "previous work" would be the gcc-ipq8074 fix 
that this is a subset of.  This is what I tried to convey in my commit 
message.  In the name of openness, I wanted to credit the person who 
provided the patch to the OpenWrt community; see 
<https://github.com/openwrt/openwrt/pull/14950> and 
<https://forum.openwrt.org/t//232618/4>.

I did play with the thought of modifying the patch a little so that I 
could without hesitation submit it as my own work.  Namely, I could have 
replaced two ".num_parents = 7" with equivalent ARRAY_SIZE expressions, 
similar to gcc-ipq8074.c.  However, that would have violated the 
"Separate your changes" guideline.

>FWIW for the patch contents:
>
>Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Thank you!

	Marko