From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A989314B6B for ; Fri, 29 Aug 2025 14:17:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756477079; cv=none; b=hWWg2nAFEhh8/zR7d7LNVw3ZSnshqGiZAYByJ4I/292jMYvRKpNyhokrLzWvS5SB7fKmH40LM55cs92gV13zSGd/6l2Ub0LKSh/KGGhnvuG/7jl+lw7dX4gJ2AJcJfmHFLuUIVHcf68hDnl+aeD7zCrG4oWAii29InTstrwbq1c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756477079; c=relaxed/simple; bh=jL7e0H9l7oWIUOWsTHCRgC8GOaaqt4s2mWR0NDrqIeI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sSt+3XK2Sx9BsQeecdL0/OO/yGF2Y7hqPY93GSx0I56Uzdu7VVIEGgk3LjrmXIvzhFJhMWmW+P2mzda0cl+LQ34jexcE5HCUG4pn7uugC3aEyk6Czpiu3pGY5bu+gaDZxBeIk3R9LbiU8qhi0mT5vUpXQ/xgSjC85r33iBBv25s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=iDJCUt00; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iDJCUt00" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3d0dd9c9229so534403f8f.1 for ; Fri, 29 Aug 2025 07:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756477074; x=1757081874; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0UKM7Hh31pGB257PcQYyxWg4WwmJZnesfP8m107J2rg=; b=iDJCUt00Zgh3BuW/C42aYbn9tZ4lJSJ2nY6VAi7mWY+oFOi5a4+M2Lf837+yE5D5z0 66C03abwX5uTrdIZRNBHe/F6CYtVuMvSMfRCDB2HG9zV6cV5YvB5B7wLHtGlkldXCUCr IyUwMTVAt4WXRWWcXaE2gF0Ayrc15o+i7axIiTffN3mB4uKfcm4AO8b5gCcgZmnghbzD E4YEpE+Ky3UxWUNuyagwInHqT5gOQH9Y9QdRn8S63yWpDAomzXL9Lfzct2Vx61HkW/SI rgyF7qZvmVGPdq3IlOUE576bTG86TL8e1XlxYFebW07vLFU+H9ABdw+fMjh2F28XQe7u bkfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756477074; x=1757081874; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0UKM7Hh31pGB257PcQYyxWg4WwmJZnesfP8m107J2rg=; b=n/d3I6Qet1v+/SZYcdk5M3M5OtQCXPnsuMyVRipqa/6wvZJtNLxwJiJL2V4u3NKgc4 4zLy9f/XeM7Nux8f7nLTwtRnD0q27NcUHEkHeNNfSpIz2De1C5ExACZmr5j1MIKIddry g1aDw3yAQo8p5EkJQzcnQZ7FMR8Dl1Isd0yQuW+fXq3IOGQz5u4WUvJ8fVFJq4Z+wfMp l10cmqYu8U1DZbBsAnVT+W2rF+73nBDxvYK1/pFmy2xA4MX/B1Gr4E3q4hDKEyCrXUhw PKz9gmPI+sNlcQykBWzo4p8fZXqnqXuFF+Z+N1iIx6JSIwZjJxv3n5K59CyJYvqsK2K2 fSlw== X-Forwarded-Encrypted: i=1; AJvYcCV1jM5b8yhvRIJ1i888Ia0CMVKMrJkuMh6AnU2o9b5prxyMtgVJ9+ylSOg2wPwmPUC/GwRcy4moy0NolOjU@vger.kernel.org X-Gm-Message-State: AOJu0YwcWFWVjsnTn68t2pYBZy16KBv1JgHpd9fDTSEuk4WXJx5qLA16 9N6vuUHaCr7wFVgr4VBq94tiyxwxn3VqcUs9FzvnCpwHs1e06oSIDWte0jagQWUWupw= X-Gm-Gg: ASbGncugrY8AnAUbEk4wcVasLobDva6YNl08IglK4RQQ9u4pzPDkzJ8eR+LOmq1O8sY B26gGePQzb0YMmA6IjRW2lILFEPdaGvcYZ5pBHSSghhroeSBte2bTbxKt0QJg4xCNHtdfS+bSTh 7SM4dvvgcJ5gANAWfWB2zUJaj0XdTASRB/XqM+UIbuHkYS/JLxnuX+IiZIKxaOqKa+KsjX8/qS6 rkvk24cQWphcgqvjo3jmWzSuGV/+umQbVFJ8HuvBKuVmFAjdhXMHLwWy1ed7J7UeotUWsTU1Fuj hqFoWh0FYkj2RmQ/7BbdIA6prePY3RzFy+qZr1ChStcuqrN/uxW4gWhdGRGwOnliw+NO4yvLSQo AzDo6suOXorQQeEAZn6WzXHxOYAc= X-Google-Smtp-Source: AGHT+IGRlrJL/hMg2fvOfjrwxfuiOfMWO4VNgYqpwRsWHXMQIhRsVFY7GAkc+zMu0TB3KTQQDEX5sw== X-Received: by 2002:a05:6000:288e:b0:3b7:895c:1562 with SMTP id ffacd0b85a97d-3c5da83c60dmr22817307f8f.11.1756477074430; Fri, 29 Aug 2025 07:17:54 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-45b74950639sm94583545e9.17.2025.08.29.07.17.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Aug 2025 07:17:53 -0700 (PDT) Date: Fri, 29 Aug 2025 17:17:50 +0300 From: Dan Carpenter To: stable@vger.kernel.org Cc: djakov@kernel.org, naresh.kamboju@linaro.org, lkft@linaro.org, nathan@kernel.org, kees@kernel.org, konradybcio@kernel.org, quic_okukatla@quicinc.com, quic_rlaggysh@quicinc.com, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] interconnect: qcom: icc-rpm: Set the count member before accessing the flex array Message-ID: References: <20241203223334.233404-1-djakov@kernel.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241203223334.233404-1-djakov@kernel.org> Hi Greg, Could you pick up this commit for 6.12 and 6.6: 00a973e093e9 ("interconnect: qcom: icc-rpm: Set the count member before accessing the flex array") It just silences a UBSan warning so it doesn't affect regular users, but it helps in testing to silence those warnings. It is a clean cherry-pick. regards, dan carpenter On Wed, Dec 04, 2024 at 12:33:34AM +0200, djakov@kernel.org wrote: > From: Georgi Djakov > > The following UBSAN error is reported during boot on the db410c board on > a clang-19 build: > > Internal error: UBSAN: array index out of bounds: 00000000f2005512 [#1] PREEMPT SMP > ... > pc : qnoc_probe+0x5f8/0x5fc > ... > > The cause of the error is that the counter member was not set before > accessing the annotated flexible array member, but after that. Fix this > by initializing it earlier. > > Reported-by: Linux Kernel Functional Testing > Closes: https://lore.kernel.org/r/CA+G9fYs+2mBz1y2dAzxkj9-oiBJ2Acm1Sf1h2YQ3VmBqj_VX2g@mail.gmail.com > Fixes: dd4904f3b924 ("interconnect: qcom: Annotate struct icc_onecell_data with __counted_by") > Signed-off-by: Georgi Djakov > --- > drivers/interconnect/qcom/icc-rpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c > index a8ed435f696c..ea1042d38128 100644 > --- a/drivers/interconnect/qcom/icc-rpm.c > +++ b/drivers/interconnect/qcom/icc-rpm.c > @@ -503,6 +503,7 @@ int qnoc_probe(struct platform_device *pdev) > GFP_KERNEL); > if (!data) > return -ENOMEM; > + data->num_nodes = num_nodes; > > qp->num_intf_clks = cd_num; > for (i = 0; i < cd_num; i++) > @@ -597,7 +598,6 @@ int qnoc_probe(struct platform_device *pdev) > > data->nodes[i] = node; > } > - data->num_nodes = num_nodes; > > clk_bulk_disable_unprepare(qp->num_intf_clks, qp->intf_clks); >