Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Griffin Kroah-Hartman <griffin.kroah@fairphone.com>
Cc: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Tianshu Qiu <tian.shu.qiu@intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Luca Weiss <luca.weiss@fairphone.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH RFC 3/3] arm64: dts: qcom: qcm6490-fairphone-fp5: Add cam actuator
Date: Thu, 23 Oct 2025 14:36:40 +0300	[thread overview]
Message-ID: <aPoTSKCTfFmA9QFJ@kekkonen.localdomain> (raw)
In-Reply-To: <cd083217-27b1-4959-b80d-0189f178208d@fairphone.com>

Hi Griffin,

On Thu, Oct 23, 2025 at 10:37:50AM +0200, Griffin Kroah-Hartman wrote:
> Hi Konrad
> On 10/22/25 19:29, Konrad Dybcio wrote:
> > On 10/9/25 2:23 PM, Griffin Kroah-Hartman wrote:
> > > Add a node for Asahi Kasei AK7377 actuator, used for focus of the main
> > > back camera sensor.
> > > 
> > > Signed-off-by: Griffin Kroah-Hartman <griffin.kroah@fairphone.com>
> > > ---
> > >   arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 7 +++++++
> > >   1 file changed, 7 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> > > index e115b6a52b299ef663ccfb614785f8f89091f39d..49654f0f914fbe18080d2f55bb6877c8ab7baf0e 100644
> > > --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> > > +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> > > @@ -616,6 +616,13 @@ &cci0 {
> > >   };
> > >   &cci0_i2c0 {
> > > +	camera_imx800_ak7377: actuator@c {
> > > +		compatible = "asahi-kasei,ak7377";
> > > +		reg = <0x0c>;
> > > +		vdd-supply = <&vreg_l7p>;
> > > +		vio-supply = <&vreg_l7p>;
> > 
> > The dt-bindings suggest vdd is 2.8 V and vio is 1.8 V (at least
> > on AK7375, although this isn't stated explicitly..)
> 
> This AK7377 is integrated into a JHS-M15342-A2, which only takes in VDD as a
> power supply. VIO was only added to satisfy the dt-bindings, as we are not
> sure what the exact pin layout the AK7377 has.
> 
> > L7P on FP5 is 2.7 V (default) - 3.0 V (which you should probably
> > tighten to the actual operating value), please double-check this
> 
> I can confirm that L7P is supposed to be 2.8V on the FP5, I will update the
> dts in my next patchset.

This seems to be unrelated to the DTB/driver patches, which I presume I
could take from this version while you'd post an updated DTS only?

-- 
Regards,

Sakari Ailus

      reply	other threads:[~2025-10-23 11:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-09 12:23 [PATCH RFC 0/3] Add support for Asahi Kasei AK7377 driver Griffin Kroah-Hartman
2025-10-09 12:23 ` [PATCH RFC 1/3] dt-bindings: media: i2c: ak7375: Document AK7377 Griffin Kroah-Hartman
2025-10-09 14:04   ` Krzysztof Kozlowski
2025-10-09 12:23 ` [PATCH RFC 2/3] media: i2c: ak7375: Add support for ak7377 Griffin Kroah-Hartman
2025-10-09 12:23 ` [PATCH RFC 3/3] arm64: dts: qcom: qcm6490-fairphone-fp5: Add cam actuator Griffin Kroah-Hartman
2025-10-22 17:29   ` Konrad Dybcio
2025-10-23  8:37     ` Griffin Kroah-Hartman
2025-10-23 11:36       ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPoTSKCTfFmA9QFJ@kekkonen.localdomain \
    --to=sakari.ailus@linux.intel.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=griffin.kroah@fairphone.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=tian.shu.qiu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox