From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2DD9223705 for ; Fri, 12 Dec 2025 00:41:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765500087; cv=none; b=e+VCTyHcSvfB5+gLV1ZJG+stkzna2s2aUOpmJwY8vLVcePFMz/BE7P7XCBYo+PXBnJ67gj0LYYMEKD9bWVYJi6IFRw7Rce9GniwQS3hdoQWFVl44EoRE2EQ8IEKfH2YnFNLGcx5/eOHfVDxgK3rnCH225XbNdqai/8zKIQUoOt8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765500087; c=relaxed/simple; bh=DHD/lZHvN8tPqWWfOwqXtmcNxX6Jp50gNz2N0sxd6BY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZKJTzBl9ASTUcVd0L9IGcU1KAbCQRIwE5G8Ejd6px0Qa2oQNUCVEy0A4uZFNr5v/F+8f/jy2ZKN+BCQkpq7gDmZcjRQoc9GAJuBRzFg2soz2d8gWwXmBaj0IdfWyunVR5utqAWcfoPPnvWnq72gpkMoT1fOzJuvTkhpsnbr7FVA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kPxsSGrk; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kPxsSGrk" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-8b1bfd4b3deso57374485a.2 for ; Thu, 11 Dec 2025 16:41:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765500084; x=1766104884; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ITpyggKEhw2+s5AdOrWLt8yqrU4pVMFBZVM7vpDrXUk=; b=kPxsSGrk2hrgtCq8L+zd27mOU1I8UbZn9MExxOta19/8F1gomHw47RH6GOyGROfdh8 7NnDyxDT1H4THnqJqYLQN5SrJCVJfEEF2uWHsJjTU7G0hlid++SHUdAh13ts9Xdu1xaw wj8uDc+kaB7Rmwe9Kk1FfhjVBCOi3hRFFLLQYBdd4jTnWZUEnpA5/LpH01LtwSYmqlJe JEjMf6v48lh62bgy7zfYp/r5Ec7T0ae2pTL46Yo6FFhhbFsk7vJEqWGskSv4YtufFpbc UePg6HV1GVRAhxT97/xyuiCMPyHLMrZEhIHejUXStGAlxqvKfoKFeX8hhB6UCoTyWaW4 L07w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765500084; x=1766104884; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ITpyggKEhw2+s5AdOrWLt8yqrU4pVMFBZVM7vpDrXUk=; b=nCgJKFncDKNADhs966Nn3BNdjihmkXKvbwEvZJuZtO2IE23AsnUsHyL28gzYFGHX6d krEiQBipjlhkxuUfWbYyN83O1RE6BSTpL05SwyL0c67kHds1qQ5wVc5go81rJm76tdQN PvK3t0AZfBD1ogPHQAC9usDNHjRXLeC6LbmZxVrm/5Uxl+KdQ325Um33XXov54awtQvs F1FpFjpbFpbfH3WMBN75OJJtUI/TuWijesUZdZ5jUFwchIFmYf7sRio4IZQnEFWQ9Je1 Njb8gfqNRfi4BGpcsXxEuZsJLJ4YipKRb5Fec7h+EnphVsS+t/QWuvUOvrk4ky+KZwSC LpOA== X-Forwarded-Encrypted: i=1; AJvYcCWxXPZw6rKta6wRxxcScOFQCbY2l34AeYqIlNZVDJLZdisZBnbg62y7P43+Pd4kHp/L36bpfe1I81GyWMe+@vger.kernel.org X-Gm-Message-State: AOJu0YxVDrUEHTJc1vVGXjV24iTXPHdwn31Y6fTJYue0hZlDZxj9EqOc vk6jAah/4opuNAfjHGZcoxC0+58ZmlvIxppYsuJ8Ln/QX4myJr1Su8d3QlPI/A== X-Gm-Gg: AY/fxX4pBsVFbXPFKYbrjnKXz3j1OB8FtEutC7pJVqs97I0g7KsZOQn/MWNixY4vLPI qxzoGyloV28VnWlLe0nRkIPgb958F2X65wMmKQIWsZ+obc9vBNzcxlZv6upewviU1+cQfW2MAFW W8Xx4/65tlV8kdW5LVbJoLbbIME13fI/XZ5zt0HzNB8+ifB36A4xoTOjOjlvAeoVSDIJM6qVZHB 1sPDG3j7fBbGLwXl1qWfiIeJIBP69N0ZisbYsY/ch4jqajwAPtuX43lzbploPK2BVdGjHtDPTi+ sFinKx9h78mja2Kov1s9MC1wKwSwy+KffXssaIfAT+wzKJEOOolK2wl2qq8f8FkgYTUYiyTV8sh +raLJOLv3adcdP8/mb284Muv9tUpFU3Kz0h7Ij9g88+zbkRjn2CiEVooAi+GmRJVIeBBsancJBA 2cVUsIkMITDDQA6Q== X-Google-Smtp-Source: AGHT+IFqGwlA1Aoece/i0Mb65MshHc5N2WWOb7PZJ8AvXpskJF5JitQBe/NZIOlberhGhCtjhAltkg== X-Received: by 2002:a05:620a:1791:b0:8b2:dd5b:fe80 with SMTP id af79cd13be357-8bb3a39ba05mr56594185a.79.1765500083610; Thu, 11 Dec 2025 16:41:23 -0800 (PST) Received: from localhost ([184.144.58.243]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8886ec2ff9fsm35002926d6.12.2025.12.11.16.41.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 16:41:23 -0800 (PST) Date: Thu, 11 Dec 2025 19:41:37 -0500 From: Richard Acayan To: Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sakari Ailus , Tianshu Qiu , Mauro Carvalho Chehab , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org, Robert Mader , Vladimir Zapolskiy Subject: Re: [PATCH v4 5/5] arm64: dts: qcom: sdm670-google-sargo: add imx355 front camera Message-ID: References: <20251211014846.16602-1-mailingradian@gmail.com> <20251211014846.16602-6-mailingradian@gmail.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Dec 11, 2025 at 07:16:30AM +0200, Dmitry Baryshkov wrote: > On Wed, Dec 10, 2025 at 08:48:46PM -0500, Richard Acayan wrote: > > The Sony IMX355 is the front camera on the Pixel 3a, mounted in portrait > > mode. It is connected to CSIPHY1 and CCI I2C1, and uses MCLK2. Add > > support for it. > > > > Co-developed-by: Robert Mader > > Signed-off-by: Robert Mader > > Signed-off-by: Richard Acayan > > --- > > .../boot/dts/qcom/sdm670-google-sargo.dts | 107 ++++++++++++++++++ > > 1 file changed, 107 insertions(+) > > > > @@ -392,6 +420,64 @@ vreg_bob: bob { > > }; > > }; > > > > +&camss { > > + vdda-phy-supply = <&vreg_l1a_1p225>; > > + vdda-pll-supply = <&vreg_s6a_0p87>; > > + > > + status = "okay"; > > + > > + ports { > > + port@1 { > > + camss_endpoint1: endpoint { > > + clock-lanes = <7>; > > + data-lanes = <0 1 2 3>; > > + remote-endpoint = <&cam_front_endpoint>; > > + }; > > + }; > > + }; > > This would be much better: > > &camss_endpoint1: { > clock-lanes, data-lanes, remote-endpoint here > }; I'm not sure what you mean, there might be some typo. If this is about using the commonly-defined endpoints, Vladimir broke it in commit dcf6fb89e6f7 ("media: qcom: camss: remove a check for unavailable CAMSS endpoint"). If I do this again and go full circle, I'm afraid this could break a second time before even making it to linux-next.