From: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH v3] arm64: dts: qcom: monaco: add QCrypto node
Date: Wed, 24 Dec 2025 15:27:31 +0530 [thread overview]
Message-ID: <aUu5C+evZ/ECJbGQ@hu-arakshit-hyd.qualcomm.com> (raw)
In-Reply-To: <f11d339f-5400-42d0-bdd1-5723083285bf@kernel.org>
On Wed, Dec 24, 2025 at 09:42:03AM +0100, Krzysztof Kozlowski wrote:
> On 24/12/2025 09:33, Abhinaba Rakshit wrote:
> > Add Qualcomm Crypto Engine device node for Monaco platform.
> >
> > QCE and Crypto DMA nodes patch was applied as part of
> > commit a86d84409947 ("arm64: dts: qcom: qcs8300: add QCrypto nodes"),
> > however was partially reverted by commit cdc117c40537 ("arm64: dts: qcom:
> > qcs8300: Partially revert "arm64: dts: qcom: qcs8300: add QCrypto nodes"")
> > due to compatible string being mismatched against schema.
>
> ...due to Qualcomm engineer not ever bothering to build test the code.
>
> Was it build tested now? Typically this is implied by trusting people,
> but not here. Trust is lost.
>
Yes, the updated patch has now been build‑tested (including DT schema checks).
The previous issue happened due to an oversight on our end, and I agree that it should not have slipped through.
I’ll ensure future submissions are properly tested before sending them upstream.
next prev parent reply other threads:[~2025-12-24 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-24 8:33 [PATCH v3] arm64: dts: qcom: monaco: add QCrypto node Abhinaba Rakshit
2025-12-24 8:42 ` Krzysztof Kozlowski
2025-12-24 8:43 ` Krzysztof Kozlowski
2025-12-24 9:57 ` Abhinaba Rakshit [this message]
2025-12-29 12:52 ` Konrad Dybcio
2026-01-05 19:16 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUu5C+evZ/ECJbGQ@hu-arakshit-hyd.qualcomm.com \
--to=abhinaba.rakshit@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox