From: Johan Hovold <johan@kernel.org>
To: Rob Clark <robin.clark@oss.qualcomm.com>, Sean Paul <sean@poorly.run>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
Akhil P Oommen <akhilpo@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
Bjorn Andersson <andersson@kernel.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] drm/msm/a6xx: fix bogus hwcg register updates
Date: Wed, 21 Jan 2026 16:16:58 +0100 [thread overview]
Message-ID: <aXDt6v_iO4EFCqyw@hovoldconsulting.com> (raw)
In-Reply-To: <aWdaLF_A5fghNZhN@hovoldconsulting.com>
On Wed, Jan 14, 2026 at 09:56:12AM +0100, Johan Hovold wrote:
> On Sun, Dec 21, 2025 at 05:45:52PM +0100, Johan Hovold wrote:
> > The hw clock gating register sequence consists of register value pairs
> > that are written to the GPU during initialisation.
> >
> > The a690 hwcg sequence has two GMU registers in it that used to amount
> > to random writes in the GPU mapping, but since commit 188db3d7fe66
> > ("drm/msm/a6xx: Rebase GMU register offsets") they trigger a fault as
> > the updated offsets now lie outside the mapping. This in turn breaks
> > boot of machines like the Lenovo ThinkPad X13s.
> >
> > Note that the updates of these GMU registers is already taken care of
> > properly since commit 40c297eb245b ("drm/msm/a6xx: Set GMU CGC
> > properties on a6xx too"), but for some reason these two entries were
> > left in the table.
> >
> > Fixes: 5e7665b5e484 ("drm/msm/adreno: Add Adreno A690 support")
> > Cc: stable@vger.kernel.org # 6.5
> > Cc: Bjorn Andersson <andersson@kernel.org>
> > Cc: Konrad Dybcio <konradybcio@kernel.org>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
>
> This one does not seem to have been applied yet despite fixing a
> critical regression in 6.19-rc1. I guess I could have highlighted that
> further by also including:
>
> Fixes: 188db3d7fe66 ("drm/msm/a6xx: Rebase GMU register offsets")
>
> I realise some delays are expected around Christmas, but can you please
> try to get this fix to Linus now that everyone should be back again?
I haven't received any reply so was going to send another reminder, but
I noticed now that this patch was merged to the msm-next branch last
week.
Since it fixes a regression in 6.19-rc1 it needs to go to Linus this
cycle and I would have assumed it should have be merged to msm-fixes.
(MSM) DRM works in mysterious ways, so can someone please confirm that
this regression fix is heading into mainline for 6.19-final?
Johan
next prev parent reply other threads:[~2026-01-21 15:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-21 16:45 [PATCH] drm/msm/a6xx: fix bogus hwcg register updates Johan Hovold
2025-12-22 8:51 ` Konrad Dybcio
2025-12-22 19:36 ` Akhil P Oommen
2026-01-14 8:56 ` Johan Hovold
2026-01-21 15:16 ` Johan Hovold [this message]
2026-01-21 16:59 ` Rob Clark
2026-01-22 9:41 ` Johan Hovold
2026-01-22 14:48 ` Rob Clark
2026-01-23 20:01 ` Dmitry Baryshkov
2026-01-24 0:53 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXDt6v_iO4EFCqyw@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=akhilpo@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox