From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 342BE1F5821 for ; Wed, 11 Feb 2026 00:34:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770770084; cv=none; b=sYKzxXY7V9aeWt2q6zrxcJQ6tPwG2fwDDPe6hInuR56LKrk0OQoYbVMy2+uKl23NuuaPKkUjeG/wCAbT7k8cua1WQ0eWQ5Fy+CoLsJj+77Qlu7W53nqWfzbt5ZRv7v9Jyd8xJx7VWewjm4qkq40KwFfbRVuQJuUYhhEGTcobkm4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770770084; c=relaxed/simple; bh=bTtpRgxfW/n6ZJjf6LdyiaKudHmd2TDOMxlHxgHc+5k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mVg0s1dYaMpLHL5ouHwE1wKwEwdmvYNFcMs6I2ZgxWWOzHVy8b7A206Wu0ZqOHx1N0dN7mbLkinRFZq7tlmD17YsC45kfv4nQWW+AfWTmc5N4QPmn0hO+ADGd+RFTc/8NoYtIjymzIczSS3K6HWzrqQ2Z6rnEo9DhRou+dX0Ci0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MQRaVrdl; arc=none smtp.client-ip=209.85.219.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MQRaVrdl" Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-896f95e07f5so25377166d6.3 for ; Tue, 10 Feb 2026 16:34:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770770082; x=1771374882; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Boz6edoyIZU5smuJ/AF0BDFHkWzkwO1KjaswJcr0sLw=; b=MQRaVrdlkckPZ6pKHh+rMMg9oBPTPO0Lm829GnnIvc7noaA6d3mR/3TUGZXwkjuyhG KKMcLlcyLCRUW5ABXKFepuF26VARLRgQjsfizSYmA2aMgEw8cIglCCfYYc7QXLi62Sf1 v5gnFBu9a3ORqtt5N+NqP6m8+uSe6x/F12s+jSL8Vf0hjniZYyjVtwATPKl24F9blxix o6D92aJni2wYkdj8dDJ+hd2LHm8bfr4XIc4D397aRRxqQR/cyhSZC9arS5DAr37gdOsX k6seLLN8HDMUaMMDDbUvkDQmnOG+Wkk4SnOLnzqhp4mGsaambfVf1XreExcoWiAwntyY 03XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770770082; x=1771374882; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Boz6edoyIZU5smuJ/AF0BDFHkWzkwO1KjaswJcr0sLw=; b=h3FIZSk+0UhcwnrjvG1RI3GZs7kYHhp24Ro+5pEUGPdS/t7nXELwu0iiSJS/Qmp6lc okQLsn2E8y8zU5lrwQ7bsB1U74XhJHKgZdSfjJLTyYrJmMfw7WWtK0NKujjcJmikcaGn cSHvCox8BXJ/5iMVLurvCR2VNcL3cAHpHeiTUC/qLAAUmGWLYApiczeFq+Nz76Ht8Jck ZvawMDCbc1sUlUvJGBQ94S5k7nQYgl/SPz8gWPrfaykEnHGwFPx78qMreJ/IpCEws9of JfhTsFqWgOaWBh6dCWS5Bsk2+pHJ8Gz4WzG4l+SEmPKcpZE4m/JYPr0QHwIPFJXY+0LV iEfQ== X-Forwarded-Encrypted: i=1; AJvYcCX7y/3cVFKQSBdakTvhMZrm6dA75qnm2zEQ2xufBTvhuJv8g7oE0Y2ezeHroF24P8NqguPbazgv1lobH9vs@vger.kernel.org X-Gm-Message-State: AOJu0YwQzPwdVRErZ2ufu5789h/Oo0oR5msc6HkxIa9lVtK5QZDe2nek fBcujLkEcI/GR9etSFJCVUjTD7E8RzAFLHrXCNN7bm/evXaMmpr6L9jH X-Gm-Gg: AZuq6aL/dIXG7vc9tGqU3ZuqKNGEQewx623dih9/GeoSsOR91/Q6HjZPAu5OFJ4QfUm 4U9s0UB7XHteS/ttEY5C9dc/AD3i4SbBUjKPTGscGEpTvTayFKK9nF3+maZoLvAlD1qA1HwC4tj t+7/Up9NDwPz1KfELycmfCUU0x17+ZW6vgBYC3qyOb5oq3mDLEjPnJTFVgSlH322X1s+ubW3+9N qZMH3vcVvKKr2Owp2QR3uv5dJwXqVqRtNoErS+L/HBZ+1AIS2F7AEMsU1er49GM8vZaSjLrmpIC KpHZqAE6M/zR2HUWrv708eCLaWcrwzDrx737ZEE5zfuYphjHj53hyGCXC/LG0WHjfTaJumQ0jS4 T0raREgkOTC+AR1AE9JkdoCQnWAvV8rcFfi1VPix3Uw2bJwbGlW14mS/pQdPlK77RemTaAk0Yfk +5sCLut/Mr9qd8D8l+nNxXq6cdPQ== X-Received: by 2002:a05:6214:19e2:b0:894:64c1:6643 with SMTP id 6a1803df08f44-8970e258895mr59874666d6.19.1770770082188; Tue, 10 Feb 2026 16:34:42 -0800 (PST) Received: from localhost ([184.144.58.243]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8971cc823a4sm2104246d6.8.2026.02.10.16.34.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 16:34:41 -0800 (PST) Date: Tue, 10 Feb 2026 19:35:09 -0500 From: Richard Acayan To: Konrad Dybcio Cc: Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/3] pinctrl: qcom: add sdm670 lpi tlmm Message-ID: References: <20260210021109.11906-1-mailingradian@gmail.com> <20260210021109.11906-3-mailingradian@gmail.com> <5fa188b3-d060-4513-bda3-6608a9bdd7ef@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5fa188b3-d060-4513-bda3-6608a9bdd7ef@oss.qualcomm.com> On Tue, Feb 10, 2026 at 10:08:19AM +0100, Konrad Dybcio wrote: > On 2/10/26 3:11 AM, Richard Acayan wrote: > > The Snapdragon 670 has an Low-Power Island (LPI) TLMM for configuring > > pins related to audio. Add the driver for this. > > > > Signed-off-by: Richard Acayan > > --- > > [...] > > > +const struct lpi_pingroup sdm670_lpi_pinctrl_groups[] = { > > + LPI_PINGROUP(0, LPI_NO_SLEW, _, _, _, _), > > + LPI_PINGROUP(1, LPI_NO_SLEW, _, _, _, _), > > + LPI_PINGROUP(2, LPI_NO_SLEW, _, _, _, _), > > + LPI_PINGROUP(3, LPI_NO_SLEW, _, _, _, _), > > + LPI_PINGROUP(4, LPI_NO_SLEW, _, _, _, _), > > + LPI_PINGROUP(5, LPI_NO_SLEW, _, _, _, _), > > + LPI_PINGROUP(6, LPI_NO_SLEW, _, _, _, _), > > + LPI_PINGROUP(7, LPI_NO_SLEW, _, _, _, _), > > + > > + LPI_PINGROUP(8, LPI_NO_SLEW, _, _, sec_tdm, _), > > "i2s1_clk" > > > + LPI_PINGROUP(9, LPI_NO_SLEW, _, _, sec_tdm, _), > > "i2s1_ws" > > > + LPI_PINGROUP(10, LPI_NO_SLEW, _, _, _, sec_tdm_din), > > "i2s1_data" > > > + LPI_PINGROUP(11, LPI_NO_SLEW, _, sec_tdm_dout, _, _), > > "i2s1_data" What are the pinfunc numbers for these? Or are the pinfuncs the same between I2S and TDM? > > + > > + LPI_PINGROUP(12, LPI_NO_SLEW, _, _, _, _), > > + LPI_PINGROUP(13, LPI_NO_SLEW, _, _, _, _), > > + LPI_PINGROUP(14, LPI_NO_SLEW, _, _, _, _), > > + LPI_PINGROUP(15, LPI_NO_SLEW, _, _, _, _), > > + LPI_PINGROUP(16, LPI_NO_SLEW, _, _, _, _), > > + LPI_PINGROUP(17, LPI_NO_SLEW, _, _, _, _), > > + > > + LPI_PINGROUP(18, LPI_NO_SLEW, _, pdm_clk, _, _), > > "slimbus_clk" Again, what pinfunc? Is PDM, the protocol between analog and digital codec, using the SLIM clock?