Re: [PATCH 2/2] arm64: dts: qcom: qcs8300-ride: Enable PMIC peripherals

[Tingguo Cheng <quic_tingguoc@quicinc.com>]

On 11/26/2024 7:54 PM, Dmitry Baryshkov wrote:
> On Tue, Nov 26, 2024 at 05:35:06PM +0800, Tingguo Cheng wrote:
>> Enable PMIC and PMIC peripherals for qcs8300-ride board. The qcs8
>> 300-ride uses 2 pmics(pmm8620au:0,pmm8650au:1) on the board, which
>> are variants of pmm8654au used on sa8775p/qcs9100 -ride(4x pmics).
>>
>> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++
>>   1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> index 7eed19a694c39dbe791afb6a991db65acb37e597..9447efb9cd01654b74ec4c18dec58b1956ffe710 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> @@ -9,6 +9,7 @@
>>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>   
>>   #include "qcs8300.dtsi"
>> +#include "sa8775p-pmics.dtsi"
>>   / {
>>   	model = "Qualcomm Technologies, Inc. QCS8300 Ride";
>>   	compatible = "qcom,qcs8300-ride", "qcom,qcs8300";
>> @@ -223,6 +224,28 @@ &gcc {
>>   		 <0>;
>>   };
>>   
>> +&pmm8654au_0_pon_resin{
> 
> Missing space between the curve bracket (here and in all other entries).
Added a space here in next version:v2
> 
>> +	linux,code = <KEY_VOLUMEDOWN>;
>> +
>> +	status = "okay";
>> +};
>> +
>> +&pmm8654au_2{
>> +	status = "disabled";
>> +};
>> +
>> +&pmm8654au_2_thermal{
>> +	status = "disabled";
> 
> Does it work this way?
Yes, it works. functions are all working as expected. The result is the 
same as the way from writing the DTS nodes from scratch.
> 
>> +};
>> +
>> +&pmm8654au_3{
>> +	status = "disabled";
>> +};
>> +
>> +&pmm8654au_3_thermal{
>> +	status = "disabled";
>> +};
>> +
>>   &qupv3_id_0 {
>>   	status = "okay";
>>   };
>>
>> -- 
>> 2.34.1
>>
> 

-- 
Thank you & BRs
Tingguo