From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 713243750BC for ; Tue, 3 Mar 2026 02:25:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772504719; cv=none; b=iA/yFRBXbcku1B26etZP6ebSeMH4tOkSrI0W2EeftBm4IVSfF5/e56b/kd3O2KQawXVvXcqBcN1LgN/0p/T1qFdilfXlsHeoVAqWbeT19wnXO/ag7v/+HQkFj6qgbqPFUmECCkOIt/WJpM/4jr5x56pd133B3pbkCywzxGjMagQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772504719; c=relaxed/simple; bh=ifvNLhNdiL6AWdShIgX/PWLQhJhpX31rZnlJXn+DfJs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z8D/uR4aFhmYtia8hveE7lLTjs+5cKN+RrfqjV9MA8vmEn0bqBOEff52PKETgvmQ7kWiZeTXw19sYDqZ35bBSRe7A780Wzz8lFtQ1eq6MjtjAzGKiF7hv/3+4ky0QtXIB3Hjm0tUu0acphxwSiiSMl30iJSYaxd5DoqjWqP8fZk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HhrFmahQ; arc=none smtp.client-ip=209.85.160.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HhrFmahQ" Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-505a1789a27so31030331cf.3 for ; Mon, 02 Mar 2026 18:25:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772504717; x=1773109517; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=17vhc0Hs2JiBGh2C/Kc5owCSl8j4M6mqkAnMUAkK1nM=; b=HhrFmahQa772OYkgAUf5Re+bF1UNgnpryrs6sWqDM+VLX/LVTjarY3wGXoHhzXWAVb gufkibXJPdVSx/9LTI7O0rL88lx8m6mM/1vKwpR4Zgb5CwKbRHTRUQOMtRStSLHRcjC2 I93pLyX0byzAJOiVJg+BH8TIs3fGeSNMaEGfXN+nP3O/9Ww4j5ykPSNtYpyc998lxc5u gcouU2LIKtbBV59smYtTFV7iE92jy8k1AJgCsNBC9ApeNLIuIswVGUiV1Yb6F5dD3r85 +NynFBJz6JOpsdUlPt093AfSVeh1qO/9NEVnrGGPbrMJC97nTDQPia41fxf12klPz6sz vM7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772504717; x=1773109517; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=17vhc0Hs2JiBGh2C/Kc5owCSl8j4M6mqkAnMUAkK1nM=; b=XAGmuyAzQTf6IXoYdconmsLDeuPIc8pcE7IfRnCEB9TrOE4dfx8W93DKWlroVIwFrx Q3c/3HpI7/GXH4U2+Rmid+yu2plUf7MrPFK9zERKDOELHClQ7ppGuZegb7puh7yeEl4E S8EIWBXSWS9a1z+2VhyGdku74umJxswxHq0KwWM48H3cYZi9nZh9jb7qkRYdym3MvB79 ybAHvc/1Do8ZofYp68GK5nJPvgcB/ybAAcBdG+PRHck7+OEXQJgLCf+mryiACz7oVD89 eTYPpfMQDg7PQulmEHTYCSErggW17McF9aiVt9JfSJFOqNjfYfSvk5d2o7Iao9j6Ijtr 7M+Q== X-Forwarded-Encrypted: i=1; AJvYcCXWxOJ3zVnpsVVm6Fmrw7CM7Yx6nq3r29WPW87QdFooxNHcYYf83ukROUXbrMr4X64nTIE1+lC6Z3hrjL/2@vger.kernel.org X-Gm-Message-State: AOJu0YzulYRSd8Q3T0EJ6lh3OAuR4bjxOGqyuhiXmecgflBNgjdqMi0N XaRHXBSVVpAbCEQUzflPgLsYKG2dJ4rnV0gycYTk+zAGFEdqWobnbSz7 X-Gm-Gg: ATEYQzyIzWXQo3u2jF4DvtQEGTYUGNSY8q4Tq391rNQ03ZvRYR6Dj8URlDeaeYwbmFu SP0eGOkq7okqPO1MqcaEUwP6qtOFmawLFHegwW+kF5ZpjZ6sSqmFKu/gR0UUdwEIcFMo+rfmLT0 dBf/6tAockx7lhVEpOm1bkm6EXuy1bgUj3DtCJ7HlvIlOB7jL7DULHHBQ9gU9c0cs415AVRIorq /8JeN8h4eVwvhwo/Tco/Yu9CRBiOC53QJMQ9Y66Ec8aTHfMdgP8OOttq+y7/eOAJsJeLablG4Ov WmtDHFK5EFsZSIwBW0BpB42cvUgIUy3/0jhTQQzwnfSueCW4Y2UAjKA6sSLWy4oZmk4ZOym2Z/h uLO5VGDbaWI1X8uoENmDUAuP4snPkX048VYvKoAI3nfRsW/VPzRQKLxuB8XpZyBKXb5ZYEv5VeN NUAhmawzhCT7CFtGMTWg61PPCudw== X-Received: by 2002:a05:622a:190f:b0:4f1:e9f7:4dee with SMTP id d75a77b69052e-5075296e804mr188944351cf.35.1772504717149; Mon, 02 Mar 2026 18:25:17 -0800 (PST) Received: from localhost ([184.144.58.243]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-899ff659b75sm29430186d6.34.2026.03.02.18.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 18:25:16 -0800 (PST) Date: Mon, 2 Mar 2026 21:25:46 -0500 From: Richard Acayan To: Konrad Dybcio Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Stephen Boyd , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 3/3] arm64: dts: qcom: pm660: add thermal monitor Message-ID: References: <20260210021819.12673-1-mailingradian@gmail.com> <20260210021819.12673-4-mailingradian@gmail.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Feb 10, 2026 at 10:59:20AM +0100, Konrad Dybcio wrote: > On 2/10/26 3:18 AM, Richard Acayan wrote: > > The thermal monitor is used to monitor arbitrary ADC-based thermal > > sensors. It is suitable for use in thermal zones. Add support for it in > > PM660. > > > > Signed-off-by: Richard Acayan > > --- > > arch/arm64/boot/dts/qcom/pm660.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/pm660.dtsi b/arch/arm64/boot/dts/qcom/pm660.dtsi > > index 156b2ddff0dc..7cedf6980b34 100644 > > --- a/arch/arm64/boot/dts/qcom/pm660.dtsi > > +++ b/arch/arm64/boot/dts/qcom/pm660.dtsi > > @@ -197,6 +197,16 @@ channel@85 { > > }; > > }; > > > > + pm660_adc_tm: adc-tm@3400 { > > + compatible = "qcom,spmi-adc-tm-hc"; > > + reg = <0x3400>; > > + interrupts = <0x0 0x34 0x0 IRQ_TYPE_EDGE_RISING>; > > + #thermal-sensor-cells = <1>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + status = "disabled"; > > Can we enable it by default? This is for the ADC thermal monitor, and not the ADC itself. I don't see the need to allocate channels just so this can be enabled by default, since the thermal monitor's purpose is mostly to send interrupts when the ADC values go above or below a certain threshold.