Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Kaustubh Pandey <quic_kapandey@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: <andersson@kernel.org>, <konradybcio@kernel.org>,
	<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <quic_rpavan@quicinc.com>,
	<quic_sharathv@quicinc.com>, <quic_sarata@quicinc.com>
Subject: Re: [PATCH] arm64: dts: qcom: qcom6490-idp: Add IPA nodes
Date: Wed, 5 Mar 2025 21:24:59 +0530	[thread overview]
Message-ID: <ab08fdfb-9268-4d32-bf3a-552b0f5720a4@quicinc.com> (raw)
In-Reply-To: <7jupetl37t6nshmme5raxavvbjo3vo5eajusroh6j3ccdxnpo5@7qaz2nckghcf>

On 3/5/2025 2:28 AM, Dmitry Baryshkov wrote:
> On Tue, Mar 04, 2025 at 08:51:33PM +0530, Kaustubh Pandey wrote:
>> Add IPA nodes for Qualcomm qcm6490 board.
>>
>> Signed-off-by: Kaustubh Pandey <quic_kapandey@quicinc.com>
>> ---
>>  arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 8 +++++++-
>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> index 9209efcc49b5..ba47786d6474 100644
>> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> @@ -19,7 +19,6 @@
>>  #include "pm8350c.dtsi"
>>  #include "pmk8350.dtsi"
>>
>> -/delete-node/ &ipa_fw_mem;
>>  /delete-node/ &rmtfs_mem;
>>  /delete-node/ &adsp_mem;
>>  /delete-node/ &cdsp_mem;
>> @@ -515,6 +514,13 @@ &gpu_zap_shader {
>>  	firmware-name = "qcom/qcm6490/a660_zap.mbn";
>>  };
>>
>> +&ipa {
>> +	qcom,gsi-loader = "self";
>> +	memory-region = <&ipa_fw_mem>;
>> +	firmware-name = "qcom/qcm6490/ipa_fws.mdt";
> 
> "qcom/qcm6490/ipa_fws.mbn". There is no .mdt in linux-firmware.
> 
>> +	status = "okay";
>> +};
>> +
>>  &mdss {
>>  	status = "okay";
>>  };
> 

Sure, thanks for review.
Will post another patch with correct format.

Thanks,
Kaustubh

  reply	other threads:[~2025-03-05 15:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-04 15:21 [PATCH] arm64: dts: qcom: qcom6490-idp: Add IPA nodes Kaustubh Pandey
2025-03-04 20:58 ` Dmitry Baryshkov
2025-03-05 15:54   ` Kaustubh Pandey [this message]
2025-03-04 22:33 ` Rob Herring (Arm)
2025-03-05 15:56   ` Kaustubh Pandey
2025-03-08 14:30 ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab08fdfb-9268-4d32-bf3a-552b0f5720a4@quicinc.com \
    --to=quic_kapandey@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_rpavan@quicinc.com \
    --cc=quic_sarata@quicinc.com \
    --cc=quic_sharathv@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox