linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: qcom: Make GCC_6125 depend on QCOM_GDSC
@ 2024-10-02 23:16 Konrad Dybcio
  2024-10-03  8:05 ` Vladimir Zapolskiy
  2024-11-06  0:53 ` Bjorn Andersson
  0 siblings, 2 replies; 3+ messages in thread
From: Konrad Dybcio @ 2024-10-02 23:16 UTC (permalink / raw)
  To: Bjorn Andersson, Michael Turquette, Stephen Boyd
  Cc: Marijn Suijten, linux-arm-msm, linux-clk, linux-kernel,
	Konrad Dybcio, Kamil Gołda

From: Konrad Dybcio <quic_kdybcio@quicinc.com>

Like all other non-ancient Qualcomm clock drivers, QCOM_GDSC is
required, as the GCC driver defines and instantiates a bunch of GDSCs.

Add the missing dependency.

Reported-by: Kamil Gołda <kamil.golda@protonmail.com>
Signed-off-by: Konrad Dybcio <quic_kdybcio@quicinc.com>
---
 drivers/clk/qcom/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index a3e2a09e2105b2f0a43afce7987fdd65f9b08c92..c6642d31707d01c33e9c0cee7100074e4cffc15b 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -987,6 +987,7 @@ config SM_GCC_6115
 config SM_GCC_6125
 	tristate "SM6125 Global Clock Controller"
 	depends on ARM64 || COMPILE_TEST
+	select QCOM_GDSC
 	help
 	  Support for the global clock controller on SM6125 devices.
 	  Say Y if you want to use peripheral devices such as UART,

---
base-commit: cea5425829f77e476b03702426f6b3701299b925
change-id: 20241003-topic-6125kconfig-647a38512867

Best regards,
-- 
Konrad Dybcio <quic_kdybcio@quicinc.com>


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: qcom: Make GCC_6125 depend on QCOM_GDSC
  2024-10-02 23:16 [PATCH] clk: qcom: Make GCC_6125 depend on QCOM_GDSC Konrad Dybcio
@ 2024-10-03  8:05 ` Vladimir Zapolskiy
  2024-11-06  0:53 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Vladimir Zapolskiy @ 2024-10-03  8:05 UTC (permalink / raw)
  To: Konrad Dybcio, Bjorn Andersson, Michael Turquette, Stephen Boyd
  Cc: Marijn Suijten, linux-arm-msm, linux-clk, linux-kernel,
	Konrad Dybcio, Kamil Gołda

Hi Konrad,

On 10/3/24 02:16, Konrad Dybcio wrote:
> From: Konrad Dybcio <quic_kdybcio@quicinc.com>
> 
> Like all other non-ancient Qualcomm clock drivers, QCOM_GDSC is
> required, as the GCC driver defines and instantiates a bunch of GDSCs.
> 
> Add the missing dependency.
> 
> Reported-by: Kamil Gołda <kamil.golda@protonmail.com>
> Signed-off-by: Konrad Dybcio <quic_kdybcio@quicinc.com>

Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>

An identical change but for SM8150 GCC is also welcome.

--
Best wishes,
Vladimir

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: qcom: Make GCC_6125 depend on QCOM_GDSC
  2024-10-02 23:16 [PATCH] clk: qcom: Make GCC_6125 depend on QCOM_GDSC Konrad Dybcio
  2024-10-03  8:05 ` Vladimir Zapolskiy
@ 2024-11-06  0:53 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2024-11-06  0:53 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd, Konrad Dybcio
  Cc: Marijn Suijten, linux-arm-msm, linux-clk, linux-kernel,
	Konrad Dybcio, Kamil Gołda


On Thu, 03 Oct 2024 01:16:27 +0200, Konrad Dybcio wrote:
> Like all other non-ancient Qualcomm clock drivers, QCOM_GDSC is
> required, as the GCC driver defines and instantiates a bunch of GDSCs.
> 
> Add the missing dependency.
> 
> 

Applied, thanks!

[1/1] clk: qcom: Make GCC_6125 depend on QCOM_GDSC
      commit: 04bad0c91743c8f3753c35750ffe4ddb1bf22489

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-11-06  0:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-02 23:16 [PATCH] clk: qcom: Make GCC_6125 depend on QCOM_GDSC Konrad Dybcio
2024-10-03  8:05 ` Vladimir Zapolskiy
2024-11-06  0:53 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).