From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DC5BC64ED6 for ; Fri, 17 Feb 2023 21:44:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229663AbjBQVoH (ORCPT ); Fri, 17 Feb 2023 16:44:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229921AbjBQVoG (ORCPT ); Fri, 17 Feb 2023 16:44:06 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 469233B20F for ; Fri, 17 Feb 2023 13:44:05 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id be32so3141451lfb.10 for ; Fri, 17 Feb 2023 13:44:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9whoLgYkr95I0qmzXxoT8Zd23sf4lcMepCK7U4SK1Ys=; b=uuhvqZnn4VGWdAwMrVDsiJOb+OngVD49lR7BaqumkAZlmSVVZ+bO1BBC1XshQ3i/Ng sLkP966ekriU9WGhjdx43i41ZaKO1qzKRYu7z7LK8uqj20q3l9/hV2sWGK8zAVdQCTcj 6MoSJ57P0YrGj56XmL/WU5Zxv6yJriy/YhQDCYnd8ljvl9s2x41tyu4LdD7Zz/xEhSzn /TPVgIedtB6M8THj+z1p64u7fHvHXTOtubWu9eRBt1/bYf6/5oAIuC2GftNZ+zSmwXiq Z55Gx2OX9yXui6OAappzqczS0ubsq2LJbe8G7fgCzTe4YUU12gu6x8dk+myZVC+MQNTW /RWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9whoLgYkr95I0qmzXxoT8Zd23sf4lcMepCK7U4SK1Ys=; b=qM51Y3eYz25rxDYwmrOwSMAafaPmCoKSG6uTk4chFEXSBIiYI9rh8kqxMhdR/SH2eY PdEXW2Mz+wkxdwcWXhVoP7MSsQI+JXTgge7iWuWA+nnTV869Qd4xpvryVOh1S0zYJLLx o6WULJtvDTIzuKjwadSyG8A24K5DUy2MfO+Tavl6Z8+C0u1rtEPBG6f8wGKgyn4MULPM i4CdEKyCbCDviXHfR9pDeNjGRmO9H8i042Z2cGtdkqVNtkYZe7tnm+uDJo2AgBvuIoJQ XgoBGbJ6z5JqGsWQrUTeAilpkVc5DPPX61xDE0jGNBpHr9+c2DuZWPivGKSVifzxc0ZH SEfA== X-Gm-Message-State: AO0yUKUB9mTzcBbarwwpv6FcCf6UlWeC5KGlbC0jLnPy+1w5Jje3gQdp b/JmwutdZvDHa8wQk0UPrT/77Q== X-Google-Smtp-Source: AK7set9P7pckgC1TAH5/lIS/YQtMX5b7b17rnIuijGqF+/f/RFGYFN1NPluvCm3J/1jazGtHEUduuw== X-Received: by 2002:ac2:51c7:0:b0:4d8:82d9:3c10 with SMTP id u7-20020ac251c7000000b004d882d93c10mr454459lfm.63.1676670243521; Fri, 17 Feb 2023 13:44:03 -0800 (PST) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id v12-20020ac2592c000000b004db4b7ad6d1sm788429lfi.31.2023.02.17.13.44.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Feb 2023 13:44:03 -0800 (PST) Message-ID: Date: Fri, 17 Feb 2023 23:44:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2 03/14] drm/msm/a6xx: Introduce GMU wrapper support Content-Language: en-GB To: Konrad Dybcio , linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org Cc: marijn.suijten@somainline.org, Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Akhil P Oommen , Geert Uytterhoeven , Douglas Anderson , Chia-I Wu , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20230214173145.2482651-1-konrad.dybcio@linaro.org> <20230214173145.2482651-4-konrad.dybcio@linaro.org> <1c2f6e03-8b16-1ee2-bdbd-8f84219acb36@linaro.org> From: Dmitry Baryshkov In-Reply-To: <1c2f6e03-8b16-1ee2-bdbd-8f84219acb36@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 17/02/2023 23:41, Konrad Dybcio wrote: > > > On 17.02.2023 22:37, Dmitry Baryshkov wrote: >> On 14/02/2023 19:31, Konrad Dybcio wrote: >>> Some (particularly SMD_RPM, a.k.a non-RPMh) SoCs implement A6XX GPUs >>> but don't implement the associated GMUs. This is due to the fact that >>> the GMU directly pokes at RPMh. Sadly, this means we have to take care >>> of enabling & scaling power rails, clocks and bandwidth ourselves. >>> >>> Reuse existing Adreno-common code and modify the deeply-GMU-infused >>> A6XX code to facilitate these GPUs. This involves if-ing out lots >>> of GMU callbacks and introducing a new type of GMU - GMU wrapper. >>> This is essentially a register region which is convenient to model >>> as a device. We'll use it for managing the GDSCs. >> >> Why do you call it a wrapper? > That's what Qualcomm calls it.. The GMU-less GPUs have (almost) all the > same GMU GX/CX registers as the real GMUs in this 'wrapper' region, so > that lets us reuse some code with gmu_(read/write/rmw) calls. > Ack. If you can add this to the commit message, it would be great. -- With best wishes Dmitry