From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3 2/3] usb: dwc3: qcom: Implement glue callbacks to facilitate runtime suspend
Date: Thu, 7 Aug 2025 14:56:55 +0200 [thread overview]
Message-ID: <abcbdb9a-f067-4bd1-be17-fe11b24dfacc@oss.qualcomm.com> (raw)
In-Reply-To: <233c62be-c0fa-499e-9f8f-e90cf0b23aa3@oss.qualcomm.com>
On 8/7/25 7:17 AM, Krishna Kurapati wrote:
>
>
> On 8/6/2025 4:02 PM, Konrad Dybcio wrote:
>> On 8/6/25 11:58 AM, Krishna Kurapati wrote:
>
[...]
>>> + if (qcom->mode == USB_DR_MODE_HOST) {
>>> + qcom->current_role = USB_ROLE_HOST;
>>> + } else if (qcom->mode == USB_DR_MODE_PERIPHERAL) {
>>> + qcom->current_role = USB_ROLE_DEVICE;
>>> + dwc3_qcom_vbus_override_enable(qcom, true);
>>> + } else {
>>> + if ((device_property_read_bool(dev, "usb-role-switch")) &&
>>> + (usb_get_role_switch_default_mode(dev) == USB_DR_MODE_HOST))
>>
>> currently this will never be true on any qcom dt ("role-switch-default-mode" is
>> not present anywhere)
>
> Agree. But I wrote for the sake of covering all cases and just in case anyone uses this property tomorrow.
This is fine, just wanted to make sure this is intended
Konrad
next prev parent reply other threads:[~2025-08-07 12:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 9:58 [PATCH v3 0/3] usb: dwc3: Modify role-switching QC drd usb controllers Krishna Kurapati
2025-08-06 9:58 ` [PATCH v3 1/3] usb: dwc3: core: Introduce glue callbacks for flattened implementations Krishna Kurapati
2025-08-07 1:08 ` Thinh Nguyen
2025-08-06 9:58 ` [PATCH v3 2/3] usb: dwc3: qcom: Implement glue callbacks to facilitate runtime suspend Krishna Kurapati
2025-08-06 10:32 ` Konrad Dybcio
2025-08-07 5:17 ` Krishna Kurapati
2025-08-07 12:56 ` Konrad Dybcio [this message]
2025-08-06 9:58 ` [PATCH v3 3/3] usb: xhci: plat: Facilitate using autosuspend for xhci plat devices Krishna Kurapati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abcbdb9a-f067-4bd1-be17-fe11b24dfacc@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=krishna.kurapati@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox