From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>
Cc: andersson@kernel.org, konrad.dybcio@linaro.org, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org, djakov@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/2] clk: qcom: add IPQ9574 interconnect clocks support
Date: Fri, 22 Mar 2024 06:45:33 +0100 [thread overview]
Message-ID: <abd29b47-a8ab-4e2a-8147-d5d8ded98065@linaro.org> (raw)
In-Reply-To: <ZfwEMUBdlQHYz/+h@hu-varada-blr.qualcomm.com>
On 21/03/2024 10:56, Varadarajan Narayanan wrote:
> On Thu, Mar 21, 2024 at 08:25:15AM +0100, Krzysztof Kozlowski wrote:
>> On 21/03/2024 05:31, Varadarajan Narayanan wrote:
>>> Unlike MSM platforms that manage NoC related clocks and scaling
>>> from RPM, IPQ SoCs dont involve RPM in managing NoC related
>>> clocks and there is no NoC scaling.
>>
>> If these are clocks, expose them as clocks, not as interconnects.
>
> Earlier IPQ9574 PCIe patches were NAK-ed when these were exposed
> as clocks. Please refer to the following discussions
>
> https://lore.kernel.org/linux-arm-msm/CAA8EJpq0uawrOBHA8XHygEpGYF--HyxJWxKG44iiFdAZZz7O2w@mail.gmail.com/
> https://lore.kernel.org/linux-arm-msm/CAA8EJppabK8j9T40waMv=t-1aksXfqJibWuS41GhruzLhpatrg@mail.gmail.com/
>
> Dmitry had said
> <quote>
> I'd kindly suggest implementing the NoC attachment
> properly. In the end, other Qualcomm platforms use ICC
> drivers, so by following this pattern we will have more
> common code paths.
> </quote>
>
> Hence posted these patches to get feedback.
Then explain the rationale in commit msg.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-22 5:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 4:31 [PATCH 0/2] Add interconnect driver for IPQ9574 SoC Varadarajan Narayanan
2024-03-21 4:31 ` [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm IPQ9574 support Varadarajan Narayanan
2024-03-21 7:23 ` Krzysztof Kozlowski
2024-03-21 9:57 ` Varadarajan Narayanan
2024-03-21 14:35 ` Rob Herring
2024-03-21 15:50 ` Varadarajan Narayanan
2024-03-21 4:31 ` [PATCH 2/2] clk: qcom: add IPQ9574 interconnect clocks support Varadarajan Narayanan
2024-03-21 7:25 ` Krzysztof Kozlowski
2024-03-21 9:56 ` Varadarajan Narayanan
2024-03-22 5:45 ` Krzysztof Kozlowski [this message]
2024-03-22 5:55 ` kernel test robot
2024-03-22 11:33 ` kernel test robot
2024-03-23 0:29 ` Konrad Dybcio
2024-03-25 10:22 ` Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abd29b47-a8ab-4e2a-8147-d5d8ded98065@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_varada@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox