From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0768254B18; Thu, 19 Mar 2026 02:43:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773888182; cv=none; b=EAUaeYmjE+LSCwV7/ehLSw1FfmG1aylWJdpr8owWkZs2iFfrLaxsvZWRU77A/c9gnJnmmCgpE95tSvFM0I9ZTxTcyr+uZAy0CZL0GRs3ISpQqB5xCVdFtYRhwSdHknvhkjHM5gKj4iEH9YFlf+7B+vFkC+UflhHuoT2npoiEjo4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773888182; c=relaxed/simple; bh=npVrlqBDwGCD4Hc4bqr13i45zGItkx5/qDmz+8tCmY0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mSbO4+TiG6gu4VdT7iDUbdvQkcH4AFoVnZs9wEecTHxf/H3WprLQgM45nmW/1E73MrHmdnZMBcI84+PqWWYWuX0n67LrGjW5ypvWjftno+EQyGHCJwnzJdDEzS06SidJV+1EvulvichrddR5hfVHIExZbNvCHSKLz+EsBhxgOs0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OHqt63tA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OHqt63tA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19971C19421; Thu, 19 Mar 2026 02:42:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773888182; bh=npVrlqBDwGCD4Hc4bqr13i45zGItkx5/qDmz+8tCmY0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OHqt63tAw5SoZO0sfsIbH5FqVtLK3UI8K3bMOJryV2ydkeDSJoYjikjnzf5a5npnG +w2TWiyW2XyPcsEQdPDETE1rMeoo+yq2kYtMGEuyL8O3EXLAcEZ1YZkhxxYcZqWSy0 MaLUoY0DQgfK2AWZxJQhEs02uIA3N1NMZSbPcKUI+f7aNMewNRwjJ9oPaFTAwBt7vs 1wnYcbY3WpWznPfcIeGInAjHALymoiuenxO9gudNruddy/Yqw5vRVZbOB+JVvuh6us xcOWtFpaAnzlYhP86yQWcsNvvGfFWYZceGO1E/ZGmL2PHH0ekjq55tUs0MwEsXL3ao T5KzQncjx39JA== Date: Wed, 18 Mar 2026 21:42:56 -0500 From: Bjorn Andersson To: Manivannan Sadhasivam Cc: Bjorn Helgaas , Ziyue Zhang , konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, jingoohan1@gmail.com, lpieralisi@kernel.org, kwilczynski@kernel.org, bhelgaas@google.com, johan+linaro@kernel.org, vkoul@kernel.org, kishon@kernel.org, neil.armstrong@linaro.org, abel.vesa@linaro.org, kw@linux.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-phy@lists.infradead.org, qiang.yu@oss.qualcomm.com, quic_krichai@quicinc.com, quic_vbadigan@quicinc.com Subject: Re: [PATCH v1 1/1] arm64: dts: qcom: hamoa: Move PCIe PERST and Wake GPIOs to port nodes Message-ID: References: <20260313094618.1361418-1-ziyue.zhang@oss.qualcomm.com> <20260313164542.GA1405513@bhelgaas> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Mar 16, 2026 at 08:50:12AM +0530, Manivannan Sadhasivam wrote: > On Sun, Mar 15, 2026 at 09:53:33PM -0500, Bjorn Andersson wrote: > > On Sat, Mar 14, 2026 at 07:50:50PM +0530, Manivannan Sadhasivam wrote: > > > On Fri, Mar 13, 2026 at 11:45:42AM -0500, Bjorn Helgaas wrote: > > > > On Fri, Mar 13, 2026 at 05:46:18PM +0800, Ziyue Zhang wrote: > > > > > Commit 960609b22be5 ("arm64: dts: qcom: hamoa: Move PHY, PERST, and Wake > > > > > GPIOs to PCIe port nodes and add port Nodes for all PCIe ports") did not > > > > > convert all Hamoa‑based platforms to the new method of defining PERST and > > > > > Wake GPIOs in the PCIe root port nodes. > > > > > > > > > > Without the change PCIe probe will fail. The probe failure happens because > > > > > the PHY stays in the controller node while the PERST/Wake GPIOs were moved > > > > > to the port nodes. > > > > > > > > > > This fixes probe failures seen on the following platforms: > > > > > - x1-hp-omnibook-x14 > > > > > - x1-microsoft-denali > > > > > - x1e80100-lenovo-yoga-slim7x > > > > > - x1e80100-medion-sprchrgd-14-s1 > > > > > - x1p42100-lenovo-thinkbook-16 > > > > > - x1-asus-zenbook-a14 > > > > > - x1-crd > > > > > - x1-dell-thena > > > > > > > > > > Fixes: 960609b22be5 ("arm64: dts: qcom: hamoa: Move PHY, PERST, and Wake GPIOs to PCIe port nodes and add port Nodes for all PCIe ports") > > > > > > > > Are you saying that DTs in the field broke because of some kernel > > > > change? That's not supposed to happen. Even though PHY, PERST, and > > > > Wake GPIOs should be described in Root Port nodes instead of the Root > > > > Complex node in *future* DTs, the kernel is still supposed to accept > > > > the old style with them described in the Root Complex node. > > > > > > > > > > This is not related to the driver change. The driver correctly parses all Root > > > Port properties either in the Root Complex node (old binding) or Root Port node > > > (new binding). But commit 960609b22be5, left converting mentioned board DTS to > > > the new binding, leaving those affected platforms in a half baked state i.e., > > > some properties in RC node and some in Root Port node. Driver cannot parse such > > > combinations, so it fails correctly so. > > > > > > > Are you saying that above listed machines has broken PCIe support in > > v7.0-rc? > > > > I haven't verified it, but I'm pretty sure PCIe is broken on these platforms. > In line with Bjorn's request, we shouldn't have to guess. > > It seems this is a (partial) revert of 960609b22be5, is this actually > > fixing that change, or is it only applicable once some other changes are > > applied? > > > > This change is fixing the issue in the respective board DTS and is a standalone > fix on top of v7.0-rc1. > So 960609b22be5 was broken when I merged it? The commit message says that the commit was incomplete, in that it didn't fully convert from the old to the new style, so it sounds like the offending commit was incomplete - but I believe the offending commit was a workaround for the new solution not being in place and this commit mostly reverts the changes in the offending commit. In other words, it's not clear to me, from the commit message, why this change is a -rc fix. Perhaps the author of the offending commit tricked me to merge that one, and that's what's being fixed? Also, is the lack of Tested-by telling us that nobody has tested any of the v7.0-rc on the 8 listed Hamoa devices? If it's actually needed, can we please have the commit message improved so that we can merge it into -rc? Regards, Bjorn > > Where should this be merged? > > > > Qcom tree for 7.0-rcX. > > - Mani > > -- > மணிவண்ணன் சதாசிவம்