From: Neil Armstrong <neil.armstrong@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bjorn Andersson <andersson@kernel.org>,
Luca Weiss <luca.weiss@fairphone.com>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] usb: typec-mux: nb7vpq904m: unregister typec switch on probe error and remove
Date: Fri, 7 Jun 2024 16:00:22 +0200 [thread overview]
Message-ID: <ac155efa-de85-4bc0-9af3-2190d4d1a60d@linaro.org> (raw)
In-Reply-To: <cnqpgfjcqqedk3xqkfbjacjikc5jwktev6c3kwmbq7cwut3eyk@xqyhgi5xgzgf>
On 07/06/2024 07:50, Dmitry Baryshkov wrote:
> On Thu, Jun 06, 2024 at 03:11:14PM +0200, Neil Armstrong wrote:
>> Add the missing call to typec_switch_put() when probe fails and
>> the nb7vpq904m_remove() call is called.
>>
>> Fixes: 348359e7c232 ("usb: typec: nb7vpq904m: Add an error handling path in nb7vpq904m_probe()")
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> drivers/usb/typec/mux/nb7vpq904m.c | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> I'd say:
>
> Fixes: 88d8f3ac9c67 ("usb: typec: add support for the nb7vpq904m Type-C Linear Redriver")
I should add both yes, it won't apply with only 88d8f3ac9c67
>
> Nevertheless:
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
>
>
next prev parent reply other threads:[~2024-06-07 14:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 13:11 [PATCH v2 0/4] usb: typec-mux: broadcast typec state to next mux for ptn36502 & nb7vpq904m retimers Neil Armstrong
2024-06-06 13:11 ` [PATCH v2 1/4] usb: typec-mux: ptn36502: unregister typec switch on probe error and remove Neil Armstrong
2024-06-07 5:48 ` Dmitry Baryshkov
2024-06-10 12:51 ` Heikki Krogerus
2024-06-06 13:11 ` [PATCH v2 2/4] usb: typec-mux: nb7vpq904m: " Neil Armstrong
2024-06-07 5:50 ` Dmitry Baryshkov
2024-06-07 14:00 ` Neil Armstrong [this message]
2024-06-07 14:49 ` Dmitry Baryshkov
2024-06-10 13:02 ` Heikki Krogerus
2024-06-06 13:11 ` [PATCH v2 3/4] usb: typec-mux: ptn36502: broadcast typec state to next mux Neil Armstrong
2024-06-07 5:51 ` Dmitry Baryshkov
2024-06-10 13:04 ` Heikki Krogerus
2024-06-06 13:11 ` [PATCH v2 4/4] usb: typec-mux: nb7vpq904m: " Neil Armstrong
2024-06-07 5:55 ` Dmitry Baryshkov
2024-06-10 13:06 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac155efa-de85-4bc0-9af3-2190d4d1a60d@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox