From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00DA426A1B4 for ; Tue, 25 Feb 2025 13:52:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740491563; cv=none; b=ebvNtTynrf6fwiRtjcpU3uZxSszAxV0/qaOgdjTBkihsy2eBKun7So4xD9ukEEUt+tVn2PhRIzngpzU2o47faJkWzCz+jhIDn0dW04GVdTihvp91dyO3l1kPIK7D+xa0pgbNELjfEe7PAcM15nPVcL8AkFroge+kR6kbnn7kW5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740491563; c=relaxed/simple; bh=SG8DHOJCeuSEggx0B2RENp3Asd1fFAb7tSeGnSgTABc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lOQEBWpUH/KGy8/z2ECBQOxa/KG5UjzpduEsghPAIuXfRHVEhOe3UCfVWI6yhpijYk0AjM7cOxp9qGrxye44m2x9IK4/kNdHpOtSC2ZfGXBRBwyuqjDFkYrtizAxGVfRJjVlWqRVzH4Ar1f2lvcCSG0qZnLo9WSziJuiX+Ahywo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CW4QPMex; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CW4QPMex" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51PCe39F001852 for ; Tue, 25 Feb 2025 13:52:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pkYjMjlyL9qlFVDtlQSmo2wWruGUfEQTSoc87Y2iaD4=; b=CW4QPMexAWZvghEj 3WTQxc9O/RPIZZWd24Z7nil+ysQswwuuWnSt0x2M90WkQB40r/kH6c3r32811qvZ AbKGEPwqBWdt0HPVTMTqdjRh2Gzu58zif7h6U2tDaFVlJ5j8JRTK8HupbDvUhWYB WjbdY4T3RCM0S+NdB3Lc/TaueuWuM5sERtdPnLLoQpVs8JXbA4jO3R+ZV6vHE+9w Tpewj+sh2SyBLUZRjMZwofd4VhLNjghvUe36FiXuxA5chZoJE4GzI+4ucrrRLwJa R9CwW/IsmfZak71eTCz8GonzQo/yB55hZP1xJsUhdf/gzonA784jCj6a4ZGNNou4 Aa91fQ== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4516nm9kmn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 25 Feb 2025 13:52:41 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6e67ac0f122so9861836d6.0 for ; Tue, 25 Feb 2025 05:52:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740491560; x=1741096360; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pkYjMjlyL9qlFVDtlQSmo2wWruGUfEQTSoc87Y2iaD4=; b=BriiysvKWhlOMY8a3FllYhPPmoc0F6uE+wpNnmfWqPUFuqxBjWj364D/5n5psZt/f1 ijz5qQNqURGs0/+WqOtFIQ+mwS/QTukSPlSADzbBR6dA6yXdYaX9SJIRAy14ZEhx2HWd VXx9zywgb44P/o1CLtyzQU+0y7b7Xr/3gYNTsqN5UOtCz9A4qoV8XHX6ZlHic9PlgLT7 lC2rxV0qjhCa6nr2lnyJwsq9x3vASa9Joow6rpL3KRlP6BRf/IKRDlqn9WYTEfm43QZX tR+RhhBRbrNIgOvbhlk/JgMSijdj8+2XwVQawbPgKcWq8wjnDaSkc6S3AvtkvYrMyzEx OdJQ== X-Gm-Message-State: AOJu0Yz0qNigMC/OqohdaGBF0yfsRECEY/Y8XeBXuHp40eZo6Nwm1Ew2 XLcvVjZ5nYh17186LECms1WywbO6EbgGBYU+F8WomiGa0JG+HN6Vs/mpf+Lnnqby5Rp91Ktv/im 3SIDOi/rYTtKJHpcglpd9X2mNiFMzZ7pKJsJcSnQ5PDtia3ag4HAsKog0o0Ys3+qo X-Gm-Gg: ASbGncuml7Y9pt1PPMWyfmmdlmikyyMU2Yq2zPSsQCj9O5U3Vv26EK8hwF30kvxJrh3 2e1J6IoFgWNV+ztfxzeOES4TXnlh8ZZYsZt/LOAOOkpP9/n1Krfpi9q7CLcUfgrNydxdWCTvveF sszdsqcwV6m8WGU1joN7ryy4W10xX85137CrVv4JtFODMrIEnBM4pLxDzNtdgnCvjTQeTHMTclv hNYYESTJHYcdqpL6ezafO92KDvsZ7zSlrv56H2Cv3lTvTCl05DXsZ8FXesv2fgEXzscNCr/+VvY elgdb9Ytd2/kfyvaCXsfX+AnUQam/ktQvG6DGD6bcIHJW7FPz6S43FDBGfHP4cUZXG0M8g== X-Received: by 2002:ad4:594d:0:b0:6e6:5d69:ec2f with SMTP id 6a1803df08f44-6e6ae9d2e05mr76539396d6.8.1740491559811; Tue, 25 Feb 2025 05:52:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IHdG6abw6+5nJUhZinHf+B2SwaAbatR9WjVdL2aV+/rZoPV2zlBUW+WrC4fHzaGB/EILXLE/Q== X-Received: by 2002:ad4:594d:0:b0:6e6:5d69:ec2f with SMTP id 6a1803df08f44-6e6ae9d2e05mr76539306d6.8.1740491559491; Tue, 25 Feb 2025 05:52:39 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abed20b6cfbsm144913566b.175.2025.02.25.05.52.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Feb 2025 05:52:39 -0800 (PST) Message-ID: Date: Tue, 25 Feb 2025 14:52:36 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: qcs615: add QCrypto nodes To: Abhinaba Rakshit , Thara Gopinath , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250224-enable-qce-for-qcs615-v1-0-e7c665347eef@quicinc.com> <20250224-enable-qce-for-qcs615-v1-2-e7c665347eef@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250224-enable-qce-for-qcs615-v1-2-e7c665347eef@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: XelHKEe5li74vA-dX-azaovBwZKXx1uR X-Proofpoint-GUID: XelHKEe5li74vA-dX-azaovBwZKXx1uR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-25_04,2025-02-25_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 mlxscore=0 phishscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 adultscore=0 clxscore=1015 spamscore=0 malwarescore=0 mlxlogscore=973 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2502250095 On 24.02.2025 11:04 AM, Abhinaba Rakshit wrote: > Add the QCE and Crypto BAM DMA nodes. > > Signed-off-by: Abhinaba Rakshit > --- > arch/arm64/boot/dts/qcom/qcs615.dtsi | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi > index f4abfad474ea62dea13d05eb874530947e1e8d3e..25e98d20ec1d941f0b45cc3d94f298065c9a5566 100644 > --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi > +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi > @@ -1114,6 +1114,31 @@ ufs_mem_phy: phy@1d87000 { > status = "disabled"; > }; > > + cryptobam: dma-controller@1dc4000 { > + compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0"; > + reg = <0x0 0x01dc4000 0x0 0x24000>; > + interrupts = ; > + #dma-cells = <1>; > + qcom,ee = <0>; > + qcom,controlled-remotely; > + num-channels = <16>; > + qcom,num-ees = <4>; > + iommus = <&apps_smmu 0x0104 0x0011>, > + <&apps_smmu 0x0114 0x0011>; (0x0114 & ~ 0x0011) == (0x0104 & ~0x0011), try dropping the second entry here and below and see if things still work > + }; > + > + crypto: crypto@1dfa000 { > + compatible = "qcom,qcs615-qce", "qcom,sm8150-qce", "qcom,qce"; > + reg = <0x0 0x01dfa000 0x0 0x6000>; > + dmas = <&cryptobam 4>, <&cryptobam 5>; > + dma-names = "rx", "tx"; > + iommus = <&apps_smmu 0x0104 0x0011>, > + <&apps_smmu 0x0114 0x0011>; > + interconnects = <&aggre1_noc MASTER_CRYPTO QCOM_ICC_TAG_ALWAYS > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; Please align the '&'s Konrad