From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 287FE3859FD for ; Mon, 2 Mar 2026 07:47:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772437632; cv=none; b=U+X8iapjNkQWVSxCoSBsJDN0TEwY9yllBQKhIsGRlkZf/MxCtMglfUX5aihy3Y2jfKRyM89A01Hqj8bFTOM0Y7Nzq0UE6aHGRxNfFv/PHTJruvcFB/SmViiqgn5ZG6/bo8zfBVV5WPCUJ3QaY08r6B9rB45DFpzCA8fgn0hbUOU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772437632; c=relaxed/simple; bh=xSIZpSl0bzT5ncKHIOJrQHcDCKTg9OSZ3st72BWj5dQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=six0DyQaneuQHOQVwW7GqzDTRob8yIKc2jtxcrgSh2gc5sEBhs87RuThxiCtrzzfNZx0mhyA8iZ3g57C96edzuyxhvZN5BNmsWenzh6XDIkUrg7cIE1zH+TGG8ueb5oGHyxFNvLy0ol9F2lBsnsZWrhkDVT6k3rql++Gye35ofw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EFjC6SVc; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EFjC6SVc" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-386b553c70eso62404431fa.0 for ; Sun, 01 Mar 2026 23:47:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772437629; x=1773042429; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=e68qiM5Z/tLR2me+b5hOCaInO/EcJkXq3qS1H6cb7Bs=; b=EFjC6SVc9p/eFXdAZNIgST336R2XCOSFernJ/n2gRKzFc1U2hrJxIruAKk4yhUIS+q H2nMCLm7FRMSFxb1533zLePDJ0iEUu/BpOfAdJs47hQQyhMrW8ONnrhEM9TGZqUST6HG ZKGJTe+3WIfVLmhjjd2AeCQb70W/CO7IONLAhiQTo/9XJd/s5N4u2Dz/6QTxBUvXfjH8 bM7ZejXHZMcGJ483hrWMsLalhV7cPIvSvyyINI8x8SCgJDI0K68Fy8uRAucfqeSYQeEe vZcqcWj1aAZCf2B1hCLw/UieKQ5Y3GWj5E7rZoOYKTaSCwOizhXxV29SEWvKJaWqyKIp ho1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772437629; x=1773042429; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e68qiM5Z/tLR2me+b5hOCaInO/EcJkXq3qS1H6cb7Bs=; b=ihDrlU+3fdP65QPPnHVwQCx8Aqvc9yJlqRb52uGmFqCvvoUnNed6hRIEhpk4yfd+dG J/IcBEI5ZPgIlawWOnrYnNft0EkExOKqmZaMMTN7NoaibFh815sZ+7iVB9G1atJnAZuN SChO2zvp5Jb/FnOCr1fvLfCGZ2d14UyiFAkOJ/7dmhcJBvy+uhxd9mXyJXLk9u7IPELH jKx2FgJgfndQZcsr+A+KwBm1D6vRwNm7yv6fE5f4unlq6Gv2Ayrh4uFqWVJCQdk+TWhh s1e7rkpIGpdCr7x886FgcsB6UoBqSMkWqjKs0ww2RSDSDpKHO8geAqaVltfuMDYFad1m cweg== X-Forwarded-Encrypted: i=1; AJvYcCWcO9esTdP/99hWnP2ZkTh91Qs00bE48D1hFw+zMBkPGRQ5WK0S5XILcGNrkFZk5UFfC78OG8KhkcXPW5wz@vger.kernel.org X-Gm-Message-State: AOJu0YzGyp0qT/9Xikouu7suDSoSNexV2dEbC5SB/ICVcJE++hKwgO8P ycTkSo4iTsmt54Y5LPvJ3AaJXUsOBJjcT6JvuOwkRGqExyWkG+R2QECe X-Gm-Gg: ATEYQzx/gDub0znTJik+Do+QsV/2cZxitfyIGEdbN1rpHiJapjewyWu4BwIGJKR1MIJ hG3I5XeKPu+tKEsuOIOHtukEMTzrbnwjE/xyRcCdnCbdecCgDZWJKBHEEElewebVWICh8NVejHg MykWdJbhs3wVqfuvkvzPTJ9kEUdeEMr26LqQJ2an2piWSr+3fCB3936m7OlyjFo5/Bi//XCAIhm Hiaj+U3JC3zwM7akCdpEcIteJRzFiENePBh7ctv0NgbEeJunArdhrJM1KMxkHyiNT0LZ22Co8xT PyZ0HPBUU7wOYhUQf7F18UVHr3XbO4CTjinLNYuKmq4ETsCZwyojftufEZkxS721rju1R1OV5AB oqkKG93McW/4KsXO2naYf9OmegVO4iDn56vg2axUhEVM8BNnOzmjWBMN1bGIiXbzzpusZ7uANfo Hs+Zngg4AX4Szoc+QaOMTmwfvUUg== X-Received: by 2002:a05:651c:1c7:b0:383:1c5f:84c7 with SMTP id 38308e7fff4ca-389ff130e18mr78428611fa.12.1772437628986; Sun, 01 Mar 2026 23:47:08 -0800 (PST) Received: from [10.38.18.76] ([213.255.186.37]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a10a319f05sm3299418e87.50.2026.03.01.23.47.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Mar 2026 23:47:08 -0800 (PST) Message-ID: Date: Mon, 2 Mar 2026 09:47:05 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/12] i2c: allow setting the parent device and OF node through the adapter struct To: Bartosz Golaszewski , Wolfram Sang , Mukesh Kumar Savaliya , Viken Dadhaniya , Andi Shyti , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Andreas Kemnade , Kevin Hilman , Roger Quadros , Geert Uytterhoeven , Magnus Damm , Patrice Chotard , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Frank Li Cc: Bartosz Golaszewski , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, Matti Vaittinen References: <20260223-i2c-adap-dev-config-v2-0-d78db0a6fcf7@oss.qualcomm.com> <20260223-i2c-adap-dev-config-v2-1-d78db0a6fcf7@oss.qualcomm.com> Content-Language: en-US From: Kalle Niemi In-Reply-To: <20260223-i2c-adap-dev-config-v2-1-d78db0a6fcf7@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/23/26 11:05, Bartosz Golaszewski wrote: > In order to stop i2c bus drivers from dereferencing the struct device > embedded in struct i2c_adapter, let's allow configuring the parent > device and OF-node of the adapter directly through dedicated fields. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/i2c/i2c-core-base.c | 5 +++++ > include/linux/i2c.h | 4 ++++ > 2 files changed, 9 insertions(+) > > diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c > index 9c46147e3506d15d53b9b7d6b592709de56e41b9..dd8cec9b04c64b8340d20e018ab5ba28f1f7f5c9 100644 > --- a/drivers/i2c/i2c-core-base.c > +++ b/drivers/i2c/i2c-core-base.c > @@ -1561,6 +1561,11 @@ static int i2c_register_adapter(struct i2c_adapter *adap) > adap->dev.type = &i2c_adapter_type; > device_initialize(&adap->dev); > > + if (!adap->dev.parent) > + adap->dev.parent = adap->parent; > + if (!adap->dev.of_node) > + adap->dev.of_node = adap->of_node; > + > /* > * This adapter can be used as a parent immediately after device_add(), > * setup runtime-pm (especially ignore-children) before hand. > diff --git a/include/linux/i2c.h b/include/linux/i2c.h > index 20fd41b51d5c85ee1665395c07345faafd8e2fca..72677f29aff161530bc3c497d1e07144a44eb9e4 100644 > --- a/include/linux/i2c.h > +++ b/include/linux/i2c.h > @@ -761,6 +761,10 @@ struct i2c_adapter { > struct irq_domain *host_notify_domain; > struct regulator *bus_regulator; > > + /* Device configuration. */ > + struct device *parent; > + struct device_node *of_node; > + > struct dentry *debugfs; > > /* 7bit address space */ > Hello, Automated driver test system bisected this commit to be the first bad commit, linux-next next-20260227 was tested. Failed tests include driver tests for ROHM PMIC and accelerometers, which are connected to BeagleBone Black. The failed driver tests all fail to first i2cget and the tests stop there: "Could not open file '/dev/i2c-2' or 'dev/i2c/2': No such file or directory". BR Kalle Niemi